From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id WCS0AR9Ck2QnZgAASxT56A (envelope-from ) for ; Wed, 21 Jun 2023 20:31:59 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id cLrEAR9Ck2TfHQEA9RJhRA (envelope-from ) for ; Wed, 21 Jun 2023 20:31:59 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id BB85B2A723 for ; Wed, 21 Jun 2023 20:31:57 +0200 (CEST) Authentication-Results: aspmx1.migadu.com; dkim=fail ("body hash did not verify") header.d=gmail.com header.s=20221208 header.b=iPat9fsF; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1687372317; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=xik/84o8XOgCnG77soGEF7NAqoT7DVDUh5K6xUIJqX0=; b=rp+SdrOTouVZpnb6+e2uu3R7Yp+vjGTrsA8M+GS93aI8YJejrwQosBZh/9xFxpgFha8vm6 gFeKA04jLIO4H0Fyc4rWSQ991w74/NY40GhWIlR09kJ0hWHE4RcKKG6q/wuIpG/EfjNFYa aGu8f6JSY+qEroVdz8Cl78jB9NWY8t2E1T4f+Rc5Rlsfzwu5vAs4wLFQU4V5pEZDyQXtfa RUnHYRrxEwtcVBq245wvzeMvYFi3DYgDrbQ6eeK9BzGzGE6hnPmDGZ4dkj2eg7qxmtfpMO g6bMREsU3giuKs9RzEGWZu1tNIsjCvYdiMfLYb8ZnLfK0GKdlc3MWSsnjWr0Kg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("body hash did not verify") header.d=gmail.com header.s=20221208 header.b=iPat9fsF; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" ARC-Seal: i=1; s=key1; d=yhetil.org; t=1687372317; a=rsa-sha256; cv=none; b=Iq2UK9E7jP0SLiqOTxw8+raIaLwEgzUgXJtyn6OpMp/IgipH7v/bZKpz/l7Y1ubwfG+U87 Q7GjTrURkLoibS34eNBqdUnaxu3JE3DzirtaXlBqgbAF9XQzxrhDuVX8N5MuFjQQZHoLUg OMqJjpOd3B/5BDfnU/xAxHOPb/rNEBOT8kVy0Z+ynfAltMLeE3PUgoEOyTVcBqLpKLMRJ6 BfePxegZu+XvYOykUdD4I850FBPOfuucx1yj0pObzk0FDw2zDthosImRXARj2ySzHblqkE XIcimh8Wn6PHDEsIBXQexUh15oydaElUjfibV8oKg+VAIONX/ZI5VAMzgyXMhQ== Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qC2bm-0007DF-92; Wed, 21 Jun 2023 14:31:10 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qC2bk-0007Ct-F0 for emacs-orgmode@gnu.org; Wed, 21 Jun 2023 14:31:08 -0400 Received: from mail-lj1-x235.google.com ([2a00:1450:4864:20::235]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qC2bi-00008O-KT for emacs-orgmode@gnu.org; Wed, 21 Jun 2023 14:31:08 -0400 Received: by mail-lj1-x235.google.com with SMTP id 38308e7fff4ca-2b07762d292so18602521fa.0 for ; Wed, 21 Jun 2023 11:31:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1687372265; x=1689964265; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=0JYMAJf7c5Sk4XRKRKI/uvnM0S24MYAE69FOOj1PEfQ=; b=iPat9fsFIXPj/Wj5xJ4Y5yWtN1K/6zuZrI7OLEddrQ2Ctdvysh3nCy4l8HNVUgu5oE VyjY7A8lmyohTSZ4Z50xwny5Gcjc8fkLb9r+/FO6OEPsugdS61a0VGXbMvHD5mHILQ5c 2Z3hGMMFSDk8KksbJIIKge03oxBF66QIEQWlJBTj65eq43ziInneVoRbnoDORk7AEaMt QfCqiZPlET2ByhNcB5uVmyeWz5Y16xF5J096fWr4a00yHUjIsvd7xScbA4CZtA1Bmb0B hZdpfJa+d6DdhKqvHpUvzJuexBPpLkFPHmZBEzKuX6kiZzsoYXO2rb4yVBVFPuA7yXaT /h6g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687372265; x=1689964265; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=0JYMAJf7c5Sk4XRKRKI/uvnM0S24MYAE69FOOj1PEfQ=; b=SVw05+ELgXPY+RLm+B5aRvXuc/dUNW/NXCRcTqeBcbwyUCwcH3YAlxNCX8NxSeLrBy sxG6KXBNzN2Ewv8nhZGt1uTCTjSTkPWAWszGbrYMoYMozTmIyVvEjMJsn6nTzg0+pymG jwPrtXtej6/1uvJnnHoXVPR2tzqw+FVIM1fK7vqEhvwXg57Il3dLmmWv/emh6fIbnpVn ePsSbyYboJCB0o4sYfKuzHTSt6SDHfK1TuVEb5g56tUYJY67V6KAkENvVOx38ROQX+8M TJNYB3cA74jYf9n1RXxFjOvoqmccgZEeKdLIbqemvvmofRCOTvdR7WwsCpRvx+rLxyFh EsJQ== X-Gm-Message-State: AC+VfDy3/03bNLSmmvvh2XJGmTXGEq7owA28zMQQ4u57XYc6TjpLvm2P /Ut0K+9DaqXqzMZj+f37dBGlZAlZ6moN0ZgaKfs= X-Google-Smtp-Source: ACHHUZ7Ow+0v6DYjca+5g/4FL75R1ZDK+27+DDmmskvbeJQ/3FVO0NYWUyjMHBUpfNC4xQWAOTfT5EYbYM0boDMC+9s= X-Received: by 2002:a2e:8e2f:0:b0:2b4:60c0:1ac9 with SMTP id r15-20020a2e8e2f000000b002b460c01ac9mr7135327ljk.2.1687372264376; Wed, 21 Jun 2023 11:31:04 -0700 (PDT) MIME-Version: 1.0 References: <87mt29zevs.fsf@localhost> <87jzvxf6js.fsf@localhost> <87352kerhb.fsf@localhost> In-Reply-To: <87352kerhb.fsf@localhost> From: Tim Visher Date: Wed, 21 Jun 2023 14:30:27 -0400 Message-ID: Subject: Re: [PATCH] org-capture.el: Allow `(here)' as a template target To: Ihor Radchenko Cc: Emacs Org Mode mailing list Content-Type: multipart/mixed; boundary="0000000000006c1eef05fea7f806" Received-SPF: pass client-ip=2a00:1450:4864:20::235; envelope-from=tim.visher@gmail.com; helo=mail-lj1-x235.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: emacs-orgmode-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN X-Migadu-Scanner: scn0.migadu.com X-Migadu-Spam-Score: -0.45 X-Spam-Score: -0.45 X-Migadu-Queue-Id: BB85B2A723 X-TUID: 4DG3FXhTuyoX --0000000000006c1eef05fea7f806 Content-Type: multipart/alternative; boundary="0000000000006c1eed05fea7f804" --0000000000006c1eed05fea7f804 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Wed, Jun 21, 2023 at 11:54=E2=80=AFAM Ihor Radchenko wrote: > Tim Visher writes: > > >> Also, may you update the docstring of `org-capture-templates' > > > > > > Good catch! This has been done in patch 0004 now. Look good? > > Yup. > =F0=9F=91=8D >> "10.1.3.1 Template elements" section of Org manual? > > > > I'm confused about what you're referring to here. Isn't that what 0002 > does? > > Yes, it does. I saw it, then noticed the missing `org-capture-templates' > docstring update, and somehow deduced that manual must be missing > :facepalm: > =F0=9F=91=8D > > Again, happy to squash and provide a single complete patch once we're a= ll > > done the review. Thanks again, Ihor! :) > > Please, also add all the necessary changelog entries to the final commit > message. > Will do! I've attached a prospective patch file but I'm not sure I follow what you mean by 'add all the necessary changelog entries to the final commit message'. Looking at this commit I'm guessing that I should have an `* =E2=80=A6` entry for every file excep= t `etc/NEWS` that I changed so I've done that but please do let me know if that was the wrong interpretation. :) --0000000000006c1eed05fea7f804 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
On Wed, Jun 21, 2023 at 11:54=E2=80=AFAM = Ihor Radchenko <yantar92@posteo.n= et> wrote:
Tim Visher <tim.visher@gmail.com> writes:

>> Also, may you update the docstring of `org-capture-templates'<= br> >
>
> Good catch! This has been done in patch 0004 now. Look good?

Yup.

=F0=9F=91=8D=C2=A0

<= /div>
>> "10.1.3.1 Template elements" section of Org manual?
>
> I'm confused about what you're referring to here. Isn't th= at what 0002 does?

Yes, it does. I saw it, then noticed the missing `org-capture-templates'= ;
docstring update, and somehow deduced that manual must be missing :facepalm= :

=F0=9F=91=8D
=C2=A0
> Again, happy to squash and provide a single complete patch once we'= ;re all
> done the review. Thanks again, Ihor! :)

Please, also add all the necessary changelog entries to the final commit message.

Will do! I've attached a p= rospective patch file but I'm not sure I follow what you mean by 'a= dd all the necessary changelog entries to the final commit

--0000000000006c1eed05fea7f804-- --0000000000006c1eef05fea7f806 Content-Type: application/octet-stream; name="0001-org-capture.el-Allow-here-as-a-template-target 3.patch" Content-Disposition: attachment; filename="0001-org-capture.el-Allow-here-as-a-template-target 3.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_lj61ufwc0 RnJvbSA0MmZiNTNkZTQ4ZTUxNjM5Y2ZkNmZjOWNjNWEyNGJkZTA1MWYyNGU1IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBUaW0gVmlzaGVyIDx0aW0udmlzaGVyQGdtYWlsLmNvbT4KRGF0 ZTogRnJpLCAxMiBNYXkgMjAyMyAxMTozMjoyMSAtMDQwMApTdWJqZWN0OiBbUEFUQ0hdIG9yZy1j YXB0dXJlLmVsOiBBbGxvdyBgKGhlcmUpJyBhcyBhIHRlbXBsYXRlIHRhcmdldAoKKiBsaXNwL29y Zy1jYXB0dXJlLmVsIChvcmctY2FwdHVyZS1zZXQtdGFyZ2V0LWxvY2F0aW9uKTogQWxsb3cKYCho ZXJlKScgYXMgYSB0ZW1wbGF0ZSB0YXJnZXQgaW4gYWRkaXRpb24gdG8gYGhlcmUnLgoKVGVtcGxh dGVzIGhhZCBubyB1c2VyIGFjY2Vzc2libGUgd2F5IHRvIHRhcmdldCB0aGUgY3VycmVudCBsb2Nh dGlvbgpkaXJlY3RseSBmcm9tIGEgY2FwdHVyZSB0ZW1wbGF0ZS4gQXR0ZW1wdGluZyB0byBkaXJl Y3RseSB1dGlsaXplIHRoZQpiZWhhdmlvciBhY2Nlc3NpYmxlIHRocm91Z2ggYSAwIHByZWZpeCBh cmcgZXhwb3NlZCB0aGUgaW5jb25zaXN0ZW50CnRyZWF0bWVudCBvZiB0aGUgYDp0YXJnZXRgIHBy b3BlcnR5IGluCmBvcmctY2FwdHVyZWAuIGBvcmctY2FwdHVyZS1zZXQtdGFyZ2V0LWxvY2F0aW9u YCB1bmRlcnN0b29kIHRoYXQgaXQKY291bGQgYmUgYm90aCBhIHN5bWJvbCBhbmQgYSBsaXN0LCB3 aGlsZSBgb3JnLWNhcHR1cmVgIGl0c2VsZiByZXF1aXJlZAppdCB0byBiZSBhIGxpc3QgdGhyb3Vn aCBpdHMgdXNlIG9mIGBjYXJgLgoKVGhpcyBjaGFuZ2Ugb3B0cyB0byBtYWtlIGBvcmctY2FwdHVy ZS1zZXQtdGFyZ2V0LWxvY2F0aW9uYCBtb3JlCmxpYmVyYWwgaW4gd2hhdCBpdCBhY2NlcHRzIHJh dGhlciB0aGFuIG1ha2luZyBgb3JnLWNhcHR1cmVgIGFncmVlIHRoYXQKdGFyZ2V0cyBjYW4gYmUg bGlzdHMuIFRoaXMgaXMgYmVjYXVzZSB0aGUgbWFudWFsIGltcGxpZXMsIGVzcGVjaWFsbHkKaW4g dGhlIGAoY2xvY2spJyBlbnRyeSwgdGhhdCB0YXJnZXRzIGFyZSBleHBlY3RlZCB0byBiZSBsaXN0 cyBldmVuIGlmCnRoZXkgYXJlIG1lYW50IGFzIHNwZWNpZmljIHBvaW50cy4KKiBkb2Mvb3JnLW1h bnVhbC5vcmcgKFRlbXBsYXRlIGVsZW1lbnRzKTogQWRkIGAoaGVyZSknIHRhcmdldApkb2N1bWVu dGF0aW9uCgpUSU5ZQ0hBTkdFCi0tLQogZG9jL29yZy1tYW51YWwub3JnICB8IDQgKysrKwogZXRj L09SRy1ORVdTICAgICAgICB8IDUgKysrKysKIGxpc3Avb3JnLWNhcHR1cmUuZWwgfCA2ICsrKysr LQogMyBmaWxlcyBjaGFuZ2VkLCAxNCBpbnNlcnRpb25zKCspLCAxIGRlbGV0aW9uKC0pCgpkaWZm IC0tZ2l0IGEvZG9jL29yZy1tYW51YWwub3JnIGIvZG9jL29yZy1tYW51YWwub3JnCmluZGV4IDIx NTgyZmU4ZS4uNzYxMzFmMTEwIDEwMDY0NAotLS0gYS9kb2Mvb3JnLW1hbnVhbC5vcmcKKysrIGIv ZG9jL29yZy1tYW51YWwub3JnCkBAIC03OTQ2LDYgKzc5NDYsMTAgQEAgTm93IGxldHMgbG9vayBh dCB0aGUgZWxlbWVudHMgb2YgYSB0ZW1wbGF0ZSBkZWZpbml0aW9uLiAgRWFjaCBlbnRyeSBpbgog CiAgICAgRmlsZSB0byB0aGUgZW50cnkgdGhhdCBpcyBjdXJyZW50bHkgYmVpbmcgY2xvY2tlZC4K IAorICAtID0oaGVyZSk9IDo6CisKKyAgICBUaGUgcG9zaXRpb24gb2YgPXBvaW50PS4KKwogICAt ID0oZnVuY3Rpb24gZnVuY3Rpb24tZmluZGluZy1sb2NhdGlvbik9IDo6CiAKICAgICBNb3N0IGdl bmVyYWwgd2F5OiB3cml0ZSB5b3VyIG93biBmdW5jdGlvbiB3aGljaCBib3RoIHZpc2l0cyB0aGUK ZGlmZiAtLWdpdCBhL2V0Yy9PUkctTkVXUyBiL2V0Yy9PUkctTkVXUwppbmRleCA5NGVmYThmYTgu LjAxZDI5NzVkMyAxMDA2NDQKLS0tIGEvZXRjL09SRy1ORVdTCisrKyBiL2V0Yy9PUkctTkVXUwpA QCAtMzAzLDYgKzMwMywxMSBAQCBza2lwcGVkICh3aXRoIGEgd2FybmluZykgaWYgdGhlIG94LWlj YWxlbmRhciBleHBvcnQgZW5jb3VudGVycyB0aGVtOgogQWxzbyBub3RlIHRoYXQgb25seSB2YW5p bGxhIHJlcGVhdGVycyBhcmUgY3VycmVudGx5IGV4cG9ydGVkOyB0aGUKIHNwZWNpYWwgcmVwZWF0 ZXJzIH4rK34gYW5kIH4uK34gYXJlIHNraXBwZWQuCiAKKyoqKiBDYXB0dXJlIHRlbXBsYXRlcyBu b3cgc3VwcG9ydCB+KGhlcmUpfiBhcyBhIHRhcmdldAorCitBIGNhcHR1cmUgdGVtcGxhdGUgY2Fu IHRhcmdldCB+KGhlcmUpfiB3aGljaCBpcyB0aGUgZXF1aXZhbGVudCBvZgoraW52b2tpbmcgYSBj YXB0dXJlIHRlbXBsYXRlIHdpdGggYSB6ZXJvIHByZWZpeC4KKwogKiogTWlzY2VsbGFuZW91cwog KioqID1vcmctY3J5cHQuZWw9IG5vdyBhcHBsaWVzIGluaXRpYWwgdmlzaWJpbGl0eSBzZXR0aW5n cyB0byBkZWNyeXB0ZWQgZW50cmllcwogCmRpZmYgLS1naXQgYS9saXNwL29yZy1jYXB0dXJlLmVs IGIvbGlzcC9vcmctY2FwdHVyZS5lbAppbmRleCBkNDMxMWRkMjAuLjQwYTdmNzhmMSAxMDA2NDQK LS0tIGEvbGlzcC9vcmctY2FwdHVyZS5lbAorKysgYi9saXNwL29yZy1jYXB0dXJlLmVsCkBAIC0y MjAsNiArMjIwLDkgQEAgdGFyZ2V0ICAgICAgIFNwZWNpZmljYXRpb24gb2Ygd2hlcmUgdGhlIGNh cHR1cmVkIGl0ZW0gc2hvdWxkIGJlIHBsYWNlZC4KICAgICAgICAgICAgICAoY2xvY2spCiAgICAg ICAgICAgICAgICAgRmlsZSB0byB0aGUgZW50cnkgdGhhdCBpcyBjdXJyZW50bHkgYmVpbmcgY2xv Y2tlZAogCisgICAgICAgICAgICAgKGhlcmUpCisgICAgICAgICAgICAgICAgVGhlIHBvc2l0aW9u IG9mIHBvaW50CisKICAgICAgICAgICAgICAoZnVuY3Rpb24gZnVuY3Rpb24tZmluZGluZy1sb2Nh dGlvbikKICAgICAgICAgICAgICAgICBNb3N0IGdlbmVyYWwgd2F5OiB3cml0ZSB5b3VyIG93biBm dW5jdGlvbiB3aGljaCBib3RoIHZpc2l0cwogICAgICAgICAgICAgICAgIHRoZSBmaWxlIGFuZCBt b3ZlcyBwb2ludCB0byB0aGUgcmlnaHQgbG9jYXRpb24KQEAgLTk5MSw3ICs5OTQsOCBAQCBTdG9y ZSB0aGVtIGluIHRoZSBjYXB0dXJlIHByb3BlcnR5IGxpc3QuIgogICAobGV0ICgodGFyZ2V0LWVu dHJ5LXAgdCkpCiAgICAgKHNhdmUtZXhjdXJzaW9uCiAgICAgICAocGNhc2UgKG9yIHRhcmdldCAo b3JnLWNhcHR1cmUtZ2V0IDp0YXJnZXQpKQotCShgaGVyZQorCSgob3IgYGhlcmUKKyAgICAgICAg ICAgICBgKGhlcmUpKQogCSAob3JnLWNhcHR1cmUtcHV0IDpleGFjdC1wb3NpdGlvbiAocG9pbnQp IDppbnNlcnQtaGVyZSB0KSkKIAkoYChmaWxlICxwYXRoKQogCSAoc2V0LWJ1ZmZlciAob3JnLWNh cHR1cmUtdGFyZ2V0LWJ1ZmZlciBwYXRoKSkKLS0gCjIuNDAuMQoK --0000000000006c1eef05fea7f806--