On Wed, Jun 21, 2023 at 6:29 AM Ihor Radchenko wrote: > Tim Visher writes: > > > I've now created patches for updating the manual and NEWS file. Let me > know > > how they look! > > Thanks! The patches look good, and the commit messages look excellent. > ٩( ᐛ )و > You could, however, squash the patches together Absolutely! Will do once we've approved the whole change. I will use the commit message of 0001 for the whole patch. > Also, may you update the docstring of `org-capture-templates' Good catch! This has been done in patch 0004 now. Look good? > "10.1.3.1 Template elements" section of Org manual? > I'm confused about what you're referring to here. Isn't that what 0002 does? ``` $ cat 0002-squash-doc-org-manual.org-Add-documentation-for-here.patch From 4b4bf944129635637c6fd57076f1c963b4c27bf6 Mon Sep 17 00:00:00 2001 From: Tim Visher Date: Tue, 20 Jun 2023 15:11:58 -0400 Subject: [PATCH 2/4] squash! doc/org-manual.org: Add documentation for `(here)` target --- doc/org-manual.org | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/doc/org-manual.org b/doc/org-manual.org index 21582fe8e..76131f110 100644 --- a/doc/org-manual.org +++ b/doc/org-manual.org @@ -7946,6 +7946,10 @@ Now lets look at the elements of a template definition. Each entry in File to the entry that is currently being clocked. + - =(here)= :: + + The position of =point=. + - =(function function-finding-location)= :: Most general way: write your own function which both visits the -- 2.40.1 ``` Again, happy to squash and provide a single complete patch once we're all done the review. Thanks again, Ihor! :)