From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id 8GQhGEn91V/+DAAA0tVLHw (envelope-from ) for ; Sun, 13 Dec 2020 11:38:49 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id kGuHE0n91V+HBAAA1q6Kng (envelope-from ) for ; Sun, 13 Dec 2020 11:38:49 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 36DE59402A5 for ; Sun, 13 Dec 2020 11:38:49 +0000 (UTC) Received: from localhost ([::1]:47734 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1koPiB-0003AU-LH for larch@yhetil.org; Sun, 13 Dec 2020 06:38:47 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:59434) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1koPhh-0003AO-Sa for emacs-orgmode@gnu.org; Sun, 13 Dec 2020 06:38:17 -0500 Received: from mail-ej1-x62c.google.com ([2a00:1450:4864:20::62c]:36250) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1koPhg-0007HU-37 for emacs-orgmode@gnu.org; Sun, 13 Dec 2020 06:38:17 -0500 Received: by mail-ej1-x62c.google.com with SMTP id lt17so18637414ejb.3 for ; Sun, 13 Dec 2020 03:38:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=LQLkP7g19psgpbqpOftzMdFtoyYKQiWK/pYFTD1+Vd8=; b=YN+Pnr0nIAdupqrbOUVPFpTzAuZpEUIgv6e+P4WP8aBrVZa5vKfCGSWG3S4vW/Z93q N4E5GjcHR3kgmxBgt2l+/bdPHYWHPYQkIcqHj9QWOtnN1xgj+Tvs01iAY2AgvDaFv4V/ R4TTLrGdzHdqTGP6jh54mryl6cH3bIl/lG6mRtu5PCDHboaWW9vtGX2wJwEiUnha2TtM 7eBMskvc9KHFsHEkCsIzyZ3bZ8Y68X8K50Nl1vtaacPgsRqMtP74MCCWIhEv6yodpZAS gEARk9htIqY8LtaS2/lESkOxTDBqmh0wEAVhvkpQBRoCy4a5KdGOJvHJLR4GNOLRnQU2 qICw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=LQLkP7g19psgpbqpOftzMdFtoyYKQiWK/pYFTD1+Vd8=; b=NjGYF8e5IDqhip2lJNLLBc0zUl5cq6B7hgAnGFmK/Q7+uvTZ6Srk86DZp9eVbrgGD7 oOnT/fcaA42Ptuqq8/HfV01bkoSN1hkUMKB5LMQm5LPbHLY54E4zXTXWRt0/eWhZ4EJn Ej2JsgoKZEiHoGHcIGrZQRkyptEHLbOOh7ItYbyqQFXigFbvh6lgbNNqiGjFLXYAAw3k VwiU4oUiR15lYCno9TfhrE9RADwMvJibzAiqaJ//6fZWnzeqPRCE0siP2IxnRaePmST7 G+BmXlMyyv9B7qKrqjV+ZwqlWtbaMY2uTUHO39D6lj5Pm3NX/EFfW03XEjL+v1ipNHAg 8RkA== X-Gm-Message-State: AOAM533iuvqQdp89UFmTdbteRJkRHwVHBNk4NFKBk+lpLkZlGsUhONOE kotbChcoDZliHvRFYTsWY7guN+O0qF8iq/ZZoIk= X-Google-Smtp-Source: ABdhPJwOemPHreMIKgnbx2k193W1qUiaPgeOwD4PcRHxG/2Epj0O7OCmyfNNheVSfbnRLQT3v+MdiZvRenQtz1ja9+E= X-Received: by 2002:a17:906:3daa:: with SMTP id y10mr18094077ejh.23.1607859493981; Sun, 13 Dec 2020 03:38:13 -0800 (PST) MIME-Version: 1.0 References: <87bleyurc3.fsf@kyleam.com> In-Reply-To: <87bleyurc3.fsf@kyleam.com> From: Fatih Aydin Date: Sun, 13 Dec 2020 11:38:02 +0000 Message-ID: Subject: Re: [PATCH] Margin added for overflow visibility problem To: Kyle Meyer Content-Type: multipart/alternative; boundary="000000000000fcd11805b656f5ba" Received-SPF: pass client-ip=2a00:1450:4864:20::62c; envelope-from=fataydin138@gmail.com; helo=mail-ej1-x62c.google.com X-Spam_score_int: -17 X-Spam_score: -1.8 X-Spam_bar: - X-Spam_report: (-1.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: emacs-orgmode@gnu.org Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -4.00 Authentication-Results: aspmx1.migadu.com; none X-Migadu-Queue-Id: 36DE59402A5 X-Spam-Score: -4.00 X-Migadu-Scanner: scn1.migadu.com X-TUID: JpGIsdA8qob8 --000000000000fcd11805b656f5ba Content-Type: text/plain; charset="UTF-8" Thanks for the suggestion, it's okay for me. I just wanted to make sure that the issue is clear for everyone by describing the steps. I also agree with waiting for CSS gurus. On Sun, Dec 13, 2020 at 6:56 AM Kyle Meyer wrote: > > Fatih Aydin writes: > > > Write a code block in an org file and publish it to a html file. You > > will see that only bottom part of the name of the programming language > > is visible when you hover on it because of the css of that block > > (overflow:auto) > > To fix this, a margin-top can be added. > > Ah, that's a nice visual improvement. Thanks! > > To more closely follow conventions for commit messages in this project > [1], I'd suggest to rewrite the message to something like this: > > --8<---------------cut here---------------start------------->8--- > Subject: [PATCH] ox-html: Add margin to fix overflow visibility problem > > * lisp/ox-html.el (org-html-style-default): Add the margin-top > property to pre.src:hover:before so that the programming language is > fully visible. > > TINYCHANGE > --8<---------------cut here---------------end--------------->8--- > > Does that look okay to you? If so, I can amend your commit when > applying. (I'll wait a few more days for any CSS gurus on the list to > weigh in.) > > [1] https://orgmode.org/worg/org-contribute.html#commit-messages > --000000000000fcd11805b656f5ba Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Thanks for the suggestion, it's okay for me. I ju= st wanted to make sure that the issue is clear for everyone by describing t= he steps.
I also agree with waiting for CSS gurus.

On Su= n, Dec 13, 2020 at 6:56 AM Kyle Meyer <kyle@kyleam.com> wrote:

Fatih Aydin writes:

> Write a code block in an org file and publish it to a html file. You > will see that only bottom part of the name of the programming language=
> is visible when you hover on it because of the css of that block
> (overflow:auto)
> To fix this, a margin-top can be added.

Ah, that's a nice visual improvement.=C2=A0 Thanks!

To more closely follow conventions for commit messages in this project
[1], I'd suggest to rewrite the message to something like this:

--8<---------------cut here---------------start------------->8---
Subject: [PATCH] ox-html: Add margin to fix overflow visibility problem

* lisp/ox-html.el (org-html-style-default): Add the margin-top
property to pre.src:hover:before so that the programming language is
fully visible.

TINYCHANGE
--8<---------------cut here---------------end--------------->8---

Does that look okay to you?=C2=A0 If so, I can amend your commit when
applying.=C2=A0 (I'll wait a few more days for any CSS gurus on the lis= t to
weigh in.)

[1] https://orgmode.org/worg/org-contrib= ute.html#commit-messages
--000000000000fcd11805b656f5ba--