emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Fatih Aydin <fataydin138@gmail.com>
To: Kyle Meyer <kyle@kyleam.com>
Cc: emacs-orgmode@gnu.org
Subject: Re: [PATCH] Margin added for overflow visibility problem
Date: Sun, 13 Dec 2020 11:38:02 +0000	[thread overview]
Message-ID: <CAHRQZ1wCPLoHzdnr78XBUZTbqUU3y_2VfDJ6bz9Xb+J0zmXZnA@mail.gmail.com> (raw)
In-Reply-To: <87bleyurc3.fsf@kyleam.com>

[-- Attachment #1: Type: text/plain, Size: 1352 bytes --]

Thanks for the suggestion, it's okay for me. I just wanted to make sure
that the issue is clear for everyone by describing the steps.
I also agree with waiting for CSS gurus.

On Sun, Dec 13, 2020 at 6:56 AM Kyle Meyer <kyle@kyleam.com> wrote:

> Fatih Aydin writes:
> > Write a code block in an org file and publish it to a html file. You
> > will see that only bottom part of the name of the programming language
> > is visible when you hover on it because of the css of that block
> > (overflow:auto)
> > To fix this, a margin-top can be added.
> Ah, that's a nice visual improvement.  Thanks!
> To more closely follow conventions for commit messages in this project
> [1], I'd suggest to rewrite the message to something like this:
> --8<---------------cut here---------------start------------->8---
> Subject: [PATCH] ox-html: Add margin to fix overflow visibility problem
> * lisp/ox-html.el (org-html-style-default): Add the margin-top
> property to pre.src:hover:before so that the programming language is
> fully visible.
> --8<---------------cut here---------------end--------------->8---
> Does that look okay to you?  If so, I can amend your commit when
> applying.  (I'll wait a few more days for any CSS gurus on the list to
> weigh in.)
> [1] https://orgmode.org/worg/org-contribute.html#commit-messages

[-- Attachment #2: Type: text/html, Size: 1900 bytes --]

  reply	other threads:[~2020-12-13 11:38 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-06  8:57 [PATCH] Margin added for overflow visibility problem Fatih Aydin
2020-12-13  6:56 ` Kyle Meyer
2020-12-13 11:38   ` Fatih Aydin [this message]
2020-12-16  5:48     ` Kyle Meyer
  -- strict thread matches above, loose matches on Subject: below --
2020-12-06  8:27 Fatih Aydin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAHRQZ1wCPLoHzdnr78XBUZTbqUU3y_2VfDJ6bz9Xb+J0zmXZnA@mail.gmail.com \
    --to=fataydin138@gmail.com \
    --cc=emacs-orgmode@gnu.org \
    --cc=kyle@kyleam.com \


* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox


This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).