From mboxrd@z Thu Jan 1 00:00:00 1970 From: Konstantin Kliakhandler Subject: Re: Weird behavior in `org-agenda-redo' and/or `org-mobile-push' Date: Thu, 22 May 2014 19:08:24 +0300 Message-ID: References: <87egzmkrk4.fsf@bzg.ath.cx> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary=047d7bdca66acaaa7704f9ff535f Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:43413) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WnVY7-0003Qv-3a for emacs-orgmode@gnu.org; Thu, 22 May 2014 12:08:59 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WnVXx-0005ek-GT for emacs-orgmode@gnu.org; Thu, 22 May 2014 12:08:55 -0400 Received: from mail-qc0-f171.google.com ([209.85.216.171]:48930) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WnVXx-0005eW-CQ for emacs-orgmode@gnu.org; Thu, 22 May 2014 12:08:45 -0400 Received: by mail-qc0-f171.google.com with SMTP id x13so6049892qcv.16 for ; Thu, 22 May 2014 09:08:44 -0700 (PDT) In-Reply-To: <87egzmkrk4.fsf@bzg.ath.cx> List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Bastien Cc: emacs-orgmode@gnu.org --047d7bdca66acaaa7704f9ff535f Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Hi Bastien, I'm willing to sign the FSF copyright papers, provided it isn't too big of a hassle :-). What do I need to do? The problem that the other part of the patch solves is as follows: org-batch-store-agenda-views writes all agendas (according to some criteria) to disk. To do this, it first generates all those agendas in a temporary buffer, which is killed at the end. This is done in a special environment, so as to not change the currently open agenda buffer (if there is one). The process is not hermetic - the plist of org-agenda-category-filter can get modified while generating the temporary agendas (when generating agendas with a category filter). If indeed modified, then at the end of the process, a user sees a filtered agenda buffer even when starting out from an unfiltered one. The patch addresses this by first saving the plist of the org-agenda-category-filter variable, then executing the regular functionality of org-batch-store-agenda-views, and finally restoring the plist of org-agenda-category-filter variable. In case something falls through with the FSF papers, I think this should be enough to implement a similar fix. Thanks, Kosta --=20 Konstantin Kliakhandler http://slumpy.org )=C2=B0) )=C2=B0( (=C2=B0( On Thu, May 22, 2014 at 1:59 PM, Bastien wrote: > Hi Konstantin, > > Konstantin Kliakhandler writes: > > > I also fixed the problems in both org-agenda.el and am including the > > patch. > > Thanks for the patch -- I applied the part that I understand: > http://orgmode.org/cgit.cgi/org-mode.git/commit/?id=3D445a8ec6 > > As for the other part, can you restate what bug it fixes in very > simple words? > > Also, we cannot accept it unless you signed the FSF copyright > assignment, so prepare to go this route if you want to submit > a consequent patch. Otherwise simply describe the problem and > a possible fix and we'll implement it. > > Thanks, > > -- > Bastien > --047d7bdca66acaaa7704f9ff535f Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
Hi Bastien,

I'm willing to sign the= FSF copyright papers, provided it isn't too big of a hassle :-). What = do I need to do?=C2=A0

The problem that the other = part of the patch solves is as follows:

org-batch-store-agenda-views writes all agendas (accord= ing to some criteria) to disk.
To do this, it first generates all= those agendas in a temporary buffer, which is killed at the end.
This is done in a special environment, so as to not change the current= ly open agenda buffer (if there is one).
The process is not herme= tic - the plist of org-agenda-category-filter can get modified while genera= ting the temporary agendas (when generating agendas with a category filter)= .
If indeed modified, then at the end of the process, a user sees = a filtered agenda buffer even when starting out from an unfiltered one.

The patch addresses this by first saving the plist of= the org-agenda-category-filter variable, then executing the regular functi= onality of org-batch-store-agenda-views, and finally restoring the plist of= org-agenda-category-filter variable.

In case something falls through with the FSF papers, I = think this should be enough to implement a similar fix.

Thanks,
Kosta
=C2=A0

--=C2=A0
Konstantin Kliakhandler=
=C2=A0 =C2=A0 http://sl= umpy.org
=C2=A0 =C2=A0 =C2=A0 =C2=A0=C2=A0=C2=A0 )=C2=B0) )=C2=B0( (= =C2=B0(


On Thu, May 22, 2014 at 1:59 PM, Bastien= <bzg= @gnu.org> wrote:
Hi Konstantin,

Konstantin Kliakhandler <kosta@slump= y.org> writes:

> I also fixed the problems in both org-agenda.el and am including the > patch.

Thanks for the patch -- I applied the part that I understand:
http://orgmode.org/cgit.cgi/org-mode.git/commit/?id=3D445= a8ec6

As for the other part, can you restate what bug it fixes in very
simple words?

Also, we cannot accept it unless you signed the FSF copyright
assignment, so prepare to go this route if you want to submit
a consequent patch. =C2=A0Otherwise simply describe the problem and
a possible fix and we'll implement it.

Thanks,

--
=C2=A0Bastien

--047d7bdca66acaaa7704f9ff535f--