From: Konstantin Kliakhandler <firstname.lastname@example.org>
To: Bastien <email@example.com>
Subject: Re: Weird behavior in `org-agenda-redo' and/or `org-mobile-push'
Date: Thu, 22 May 2014 19:08:24 +0300 [thread overview]
Message-ID: <CAH+LVpnvM8m8wzp5SG_AX3b4a1QBSrY_GjPozpKpCrKO3C0Ohw@mail.gmail.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 2015 bytes --]
I'm willing to sign the FSF copyright papers, provided it isn't too big of
a hassle :-). What do I need to do?
The problem that the other part of the patch solves is as follows:
org-batch-store-agenda-views writes all agendas (according to some
criteria) to disk.
To do this, it first generates all those agendas in a temporary buffer,
which is killed at the end.
This is done in a special environment, so as to not change the currently
open agenda buffer (if there is one).
The process is not hermetic - the plist of org-agenda-category-filter can
get modified while generating the temporary agendas (when generating
agendas with a category filter).
If indeed modified, then at the end of the process, a user sees a filtered
agenda buffer even when starting out from an unfiltered one.
The patch addresses this by first saving the plist of the
org-agenda-category-filter variable, then executing the regular
functionality of org-batch-store-agenda-views, and finally restoring the
plist of org-agenda-category-filter variable.
In case something falls through with the FSF papers, I think this should be
enough to implement a similar fix.
)°) )°( (°(
On Thu, May 22, 2014 at 1:59 PM, Bastien <firstname.lastname@example.org> wrote:
> Hi Konstantin,
> Konstantin Kliakhandler <email@example.com> writes:
> > I also fixed the problems in both org-agenda.el and am including the
> > patch.
> Thanks for the patch -- I applied the part that I understand:
> As for the other part, can you restate what bug it fixes in very
> simple words?
> Also, we cannot accept it unless you signed the FSF copyright
> assignment, so prepare to go this route if you want to submit
> a consequent patch. Otherwise simply describe the problem and
> a possible fix and we'll implement it.
[-- Attachment #2: Type: text/html, Size: 2895 bytes --]
next prev parent reply other threads:[~2014-05-22 16:08 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-06 11:00 Weird behavior in `org-agenda-redo' and/or `org-mobile-push' Konstantin Kliakhandler
2014-05-06 15:54 ` Konstantin Kliakhandler
2014-05-06 18:49 ` Konstantin Kliakhandler
2014-05-22 10:59 ` Bastien
2014-05-22 16:08 ` Konstantin Kliakhandler [this message]
2014-12-01 6:45 ` Konstantin Kliakhandler
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).