From mboxrd@z Thu Jan 1 00:00:00 1970 From: Konstantin Kliakhandler Subject: Weird behavior in `org-agenda-redo' and/or `org-mobile-push' Date: Tue, 6 May 2014 14:00:04 +0300 Message-ID: Mime-Version: 1.0 Content-Type: multipart/alternative; boundary=001a113550709ce8ad04f8b927f2 Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:35190) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Whd6w-0005VT-8v for emacs-orgmode@gnu.org; Tue, 06 May 2014 07:00:39 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Whd6n-0004SD-5G for emacs-orgmode@gnu.org; Tue, 06 May 2014 07:00:34 -0400 Received: from mail-qa0-f44.google.com ([209.85.216.44]:43677) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Whd6m-0004RY-Vl for emacs-orgmode@gnu.org; Tue, 06 May 2014 07:00:25 -0400 Received: by mail-qa0-f44.google.com with SMTP id j7so2773229qaq.31 for ; Tue, 06 May 2014 04:00:24 -0700 (PDT) List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: emacs-orgmode@gnu.org --001a113550709ce8ad04f8b927f2 Content-Type: text/plain; charset=UTF-8 Hello, [This behavior appears in a previous and the following org versions: Org-mode version 8.2.6 (8.2.6-14-g063c8b-elpa @ /home/kosta/.emacs.d/elpa/org-20140505/)] I recently began seeing weird behavior when trying to run `org-mobile-push' in an agenda buffer; It appears the files are indeed pushed, but at the end I get an error: "(wrong-type-argument arrayp nil)" This only happens when I attempt to push from an agenda buffer - if I push in a regular org buffer, everything works. The stack trace is: org-agenda-filter-apply(nil category) org-agenda-redo() org-mobile-push() where the `org-agenda-filter-apply' call is from this sexp in `org-agenda-redo': (and (or cat-filter cat-preset) (org-agenda-filter-apply cat-filter 'category)) And cat-filter, cat-preset are set in a let* form higher up in org-agenda-redo as (their values are included): (cat-filter org-agenda-category-filter) nil (cat-preset (get 'org-agenda-category-filter :preset-filter)) ("+Academic") When I start emacs or even look at the agenda, (get 'org-agenda-category-filter :preset-filter) always evaluates to nil (up to the point where I eval `org-mobile-push'). It gets set in `org-mobile-create-sumo-agenda', which is called at some point from `org-mobile-push' before `org-agenda-redo'. Apparently this started happening after I added the following custom agenda command: ("z" "All academic agenda items" alltodo "" ((org-agenda-overriding-header "Academic todos.") (org-agenda-category-filter-preset (quote ("+Academic"))) (org-agenda-todo-list-sublevels nil))) Now, I have two questions/comments: 1. It appears that `org-agenda-filter-apply' expects an array, and an array always evaluates to togical t (As far as I remember, have just checked). If this is the case, in the following sexp (from `org-agenda-filter-apply'): (and (or cat-filter cat-preset) (org-agenda-filter-apply cat-filter 'category)) why is the (or cat-filter cat-preset)? It seems that either `cat-filter' is an array, in which case it is (possibly) valid to pass it to `org-agenda-filter-apply', or is nil, in which case it isn't. What role does cat-preset play here? 2. It appears to me that `org-mobile-create-sumo-agenda' does not work entirely correctly, as it leaves some properties set that were not set before it ran? Ok, so after writing the last two questions, I looked into `org-agenda-filter-apply', and it appears that it expects a list of strings of the form "+cat" or "-cat", which is what `cat-preset' holds at this point. Changing (and (or cat-filter cat-preset) (org-agenda-filter-apply cat-filter 'category)) to (and (or cat-filter cat-preset) (org-agenda-filter-apply (or cat-filter cat-preset) 'category)) as a check and reevaling the defun makes org-mobile-push complete with no errors even when ran from an agenda buffer. Note however: 1. There are several more similar lines in org-agenda-redo, which I suspect also need to be checked. 2. After org-mobile-push, a category filter is applied to the agenda buffer ("+Academic"), despite the original agenda buffer having no such filter, so it seems that something is broken in `org-mobile-create-sumo-agenda' regardless. I found a (somewhat) relevant post here: http://thread.gmane.org/gmane.emacs.orgmode/57481 If what I wrote makes sense, let me know and I will submit a patch for `org-agenda-filter-apply', and if I figure out how to fix `org-mobile-create-sumo-agenda', for that as well. Thanks, Kosta --001a113550709ce8ad04f8b927f2 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
Hello,

[This behavior a= ppears in a previous and the following org versions: Org-mode version 8.2.6= (8.2.6-14-g063c8b-elpa @ /home/kosta/.emacs.d/elpa/org-20140505/)]

I recently began seeing weird behavior when trying to run `o= rg-mobile-push' in an agenda buffer; It appears the files are indeed pu= shed, but at the end I get an error: "(wrong-type-argument arrayp nil)= "

This only happens when I attempt to push from an agenda= buffer - if I push in a regular org buffer, everything works.
The stack trace is:
org-agenda-filter-apply(nil cate= gory)
org-agenda-redo()
org-mobile-push()

where the `org-agenda-filter-apply' call is from this sexp in `org-age= nda-redo':
(and (or cat-filter cat-preset) (org-agenda-filter= -apply cat-filter 'category))

And cat-filter, cat-preset are set in a let* form highe= r up in org-agenda-redo as (their values are included):

(cat-filter org-agenda-category-filter)
nil
(cat-preset (get 'org-agenda-category-filter :preset-filter))
("+Academic")

When I start emacs or= even look at the agenda,
(get 'org-agenda-category-filter :p= reset-filter) always evaluates to nil (up to the point where I eval `org-mo= bile-push'). It gets set in `org-mobile-create-sumo-agenda', which = is called at some point from `org-mobile-push' before `org-agenda-redo&= #39;.

Apparently this started happening after I added the fol= lowing custom agenda command:

("z" "= ;All academic agenda items" alltodo ""
=C2=A0((org= -agenda-overriding-header "Academic todos.")
=C2=A0 (org-agenda-category-filter-preset
=C2=A0 =C2=A0(quot= e
("+Acad= emic")))
(org-agenda-todo-list-sublevels nil)))
Now, I have two questions/comments:
1. It appears that `org-agenda-filter-apply' expects an array, and= an array always evaluates to togical t (As far as I remember, have just ch= ecked). If this is the case, in the following sexp (from `org-agenda-filter= -apply'): (and (or cat-filter cat-preset) (org-agenda-filter-apply cat-= filter 'category)) why is the (or cat-filter cat-preset)? It seems that= either `cat-filter' is an array, in which case it is (possibly) valid = to pass it to `org-agenda-filter-apply', or is nil, in which case it is= n't. What role does cat-preset play here?
2. It appears to me that `org-mobile-create-sumo-agenda' does not = work entirely correctly, as it leaves some properties set that were not set= before it ran?

Ok, so after writing the last two = questions, I looked into `org-agenda-filter-apply', and it appears that= it expects a list of strings of the form "+cat" or "-cat&qu= ot;, which is what `cat-preset' holds at this point.

Changing
(and (or cat-filter cat-preset) (org= -agenda-filter-apply cat-filter 'category))
to
(and= (or cat-filter cat-preset) (org-agenda-filter-apply (or cat-filter cat-pre= set) 'category))
as a check and reevaling the defun makes org-mobile-push complete with= no errors even when ran from an agenda buffer. Note however:
1. = There are several more similar lines in org-agenda-redo, which I suspect al= so need to be checked.
2. After org-mobile-push, a category filter is applied to the agenda b= uffer ("+Academic"), despite the original agenda buffer having no= such filter, so it seems that something is broken in `org-mobile-create-su= mo-agenda' regardless.

I found a (somewhat) relevant post here: http://thread.gmane.org/gma= ne.emacs.orgmode/57481
If what I wrote makes sense, let me kn= ow and I will submit a patch for `org-agenda-filter-apply', and if I fi= gure out how to fix `org-mobile-create-sumo-agenda', for that as well.<= /div>

Thanks,
Kosta
--001a113550709ce8ad04f8b927f2--