From mboxrd@z Thu Jan 1 00:00:00 1970 From: Konstantin Kliakhandler Subject: Re: Weird behavior in `org-agenda-redo' and/or `org-mobile-push' Date: Mon, 1 Dec 2014 08:45:08 +0200 Message-ID: References: <87egzmkrk4.fsf@bzg.ath.cx> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary=047d7bea306ac03668050921f4c5 Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:46757) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XvKjq-0003Y3-Ne for emacs-orgmode@gnu.org; Mon, 01 Dec 2014 01:45:42 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XvKjh-0006tm-FP for emacs-orgmode@gnu.org; Mon, 01 Dec 2014 01:45:38 -0500 Received: from mail-qc0-f179.google.com ([209.85.216.179]:64300) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XvKjh-0006sm-84 for emacs-orgmode@gnu.org; Mon, 01 Dec 2014 01:45:29 -0500 Received: by mail-qc0-f179.google.com with SMTP id c9so7031842qcz.38 for ; Sun, 30 Nov 2014 22:45:28 -0800 (PST) In-Reply-To: List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Bastien Cc: emacs-orgmode@gnu.org --047d7bea306ac03668050921f4c5 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Dear Bastien, Would you please consider incorporating my patch (or reimplementing it)? As it stands, the problem I described earlier (agenda buffer gets screwed up after org mobile push) persists and I need to repatch on every new version I install. I will also look into the FSF papers myself. Thanks in advance, Kosta --=20 Konstantin Kliakhandler http://slumpy.org )=C2=B0) )=C2=B0( (=C2=B0( On Thu, May 22, 2014 at 7:08 PM, Konstantin Kliakhandler wrote: > Hi Bastien, > > I'm willing to sign the FSF copyright papers, provided it isn't too big o= f > a hassle :-). What do I need to do? > > The problem that the other part of the patch solves is as follows: > > org-batch-store-agenda-views writes all agendas (according to some > criteria) to disk. > To do this, it first generates all those agendas in a temporary buffer, > which is killed at the end. > This is done in a special environment, so as to not change the currently > open agenda buffer (if there is one). > The process is not hermetic - the plist of org-agenda-category-filter can > get modified while generating the temporary agendas (when generating > agendas with a category filter). > If indeed modified, then at the end of the process, a user sees a filtere= d > agenda buffer even when starting out from an unfiltered one. > > The patch addresses this by first saving the plist of the > org-agenda-category-filter variable, then executing the regular > functionality of org-batch-store-agenda-views, and finally restoring the > plist of org-agenda-category-filter variable. > > In case something falls through with the FSF papers, I think this should > be enough to implement a similar fix. > > Thanks, > Kosta > > > -- > Konstantin Kliakhandler > http://slumpy.org > )=C2=B0) )=C2=B0( (=C2=B0( > > > On Thu, May 22, 2014 at 1:59 PM, Bastien wrote: > >> Hi Konstantin, >> >> Konstantin Kliakhandler writes: >> >> > I also fixed the problems in both org-agenda.el and am including the >> > patch. >> >> Thanks for the patch -- I applied the part that I understand: >> http://orgmode.org/cgit.cgi/org-mode.git/commit/?id=3D445a8ec6 >> >> As for the other part, can you restate what bug it fixes in very >> simple words? >> >> Also, we cannot accept it unless you signed the FSF copyright >> assignment, so prepare to go this route if you want to submit >> a consequent patch. Otherwise simply describe the problem and >> a possible fix and we'll implement it. >> >> Thanks, >> >> -- >> Bastien >> > > --047d7bea306ac03668050921f4c5 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
Dear Bastien,

Would you please consider= incorporating my patch (or reimplementing it)? As it stands, the problem I= described earlier (agenda buffer gets screwed up after org mobile push) pe= rsists and I need to repatch on every new version I install. I will also lo= ok into the FSF papers myself.

Thanks in advance,<= /div>
Kosta

--=C2=A0
Konstantin Kl= iakhandler
=C2=A0 =C2=A0 http://slumpy.org
=C2=A0 =C2=A0 =C2=A0 =C2=A0=C2=A0=C2=A0 )=C2=B0) = )=C2=B0( (=C2=B0(

On Thu, May 22, 2014 at 7:08 PM, Konstantin = Kliakhandler <kosta@slumpy.org> wrote:
Hi Bastien,

I'm willi= ng to sign the FSF copyright papers, provided it isn't too big of a has= sle :-). What do I need to do?=C2=A0

The problem t= hat the other part of the patch solves is as follows:

org-batch-store-agenda-views writes all agendas (accord= ing to some criteria) to disk.
To do this, it first generates all= those agendas in a temporary buffer, which is killed at the end.
This is done in a special environment, so as to not change the current= ly open agenda buffer (if there is one).
The process is not herme= tic - the plist of org-agenda-category-filter can get modified while genera= ting the temporary agendas (when generating agendas with a category filter)= .
If indeed modified, then at the end of the process, a user sees = a filtered agenda buffer even when starting out from an unfiltered one.

The patch addresses this by first saving the plist of= the org-agenda-category-filter variable, then executing the regular functi= onality of org-batch-store-agenda-views, and finally restoring the plist of= org-agenda-category-filter variable.

In case something falls through with the FSF papers, I = think this should be enough to implement a similar fix.

Thanks,
Kosta
=C2=A0

--=C2=A0
Konstantin Kliakhandler=
=C2=A0 =C2=A0 http://sl= umpy.org
=C2=A0 =C2=A0 =C2=A0 =C2=A0=C2=A0=C2=A0 )=C2=B0) )=C2=B0( (= =C2=B0(


On Thu, Ma= y 22, 2014 at 1:59 PM, Bastien <bzg@gnu.org> wrote:
Hi Konstantin,

Konstantin Kliakhandler <kosta@slumpy.org> writes:

> I also fixed the problems in both org-agenda.el and am including the > patch.

Thanks for the patch -- I applied the part that I understand:
http://orgmode.org/cgit.cgi/org-mode.git/commit/?id=3D445= a8ec6

As for the other part, can you restate what bug it fixes in very
simple words?

Also, we cannot accept it unless you signed the FSF copyright
assignment, so prepare to go this route if you want to submit
a consequent patch.=C2=A0 Otherwise simply describe the problem and
a possible fix and we'll implement it.

Thanks,

--
=C2=A0Bastien


--047d7bea306ac03668050921f4c5--