From: Konstantin Kliakhandler <kosta@slumpy.org>
To: Bastien <bzg@gnu.org>
Cc: emacs-orgmode@gnu.org
Subject: Re: Weird behavior in `org-agenda-redo' and/or `org-mobile-push'
Date: Mon, 1 Dec 2014 08:45:08 +0200 [thread overview]
Message-ID: <CAH+LVp=rCY5CXVe3EY3XCYU_7MbUFb4p3_ETU=YhhuCtVGY5Tw@mail.gmail.com> (raw)
In-Reply-To: <CAH+LVpnvM8m8wzp5SG_AX3b4a1QBSrY_GjPozpKpCrKO3C0Ohw@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 2611 bytes --]
Dear Bastien,
Would you please consider incorporating my patch (or reimplementing it)? As
it stands, the problem I described earlier (agenda buffer gets screwed up
after org mobile push) persists and I need to repatch on every new version
I install. I will also look into the FSF papers myself.
Thanks in advance,
Kosta
--
Konstantin Kliakhandler
http://slumpy.org
)°) )°( (°(
On Thu, May 22, 2014 at 7:08 PM, Konstantin Kliakhandler <kosta@slumpy.org>
wrote:
> Hi Bastien,
>
> I'm willing to sign the FSF copyright papers, provided it isn't too big of
> a hassle :-). What do I need to do?
>
> The problem that the other part of the patch solves is as follows:
>
> org-batch-store-agenda-views writes all agendas (according to some
> criteria) to disk.
> To do this, it first generates all those agendas in a temporary buffer,
> which is killed at the end.
> This is done in a special environment, so as to not change the currently
> open agenda buffer (if there is one).
> The process is not hermetic - the plist of org-agenda-category-filter can
> get modified while generating the temporary agendas (when generating
> agendas with a category filter).
> If indeed modified, then at the end of the process, a user sees a filtered
> agenda buffer even when starting out from an unfiltered one.
>
> The patch addresses this by first saving the plist of the
> org-agenda-category-filter variable, then executing the regular
> functionality of org-batch-store-agenda-views, and finally restoring the
> plist of org-agenda-category-filter variable.
>
> In case something falls through with the FSF papers, I think this should
> be enough to implement a similar fix.
>
> Thanks,
> Kosta
>
>
> --
> Konstantin Kliakhandler
> http://slumpy.org
> )°) )°( (°(
>
>
> On Thu, May 22, 2014 at 1:59 PM, Bastien <bzg@gnu.org> wrote:
>
>> Hi Konstantin,
>>
>> Konstantin Kliakhandler <kosta@slumpy.org> writes:
>>
>> > I also fixed the problems in both org-agenda.el and am including the
>> > patch.
>>
>> Thanks for the patch -- I applied the part that I understand:
>> http://orgmode.org/cgit.cgi/org-mode.git/commit/?id=445a8ec6
>>
>> As for the other part, can you restate what bug it fixes in very
>> simple words?
>>
>> Also, we cannot accept it unless you signed the FSF copyright
>> assignment, so prepare to go this route if you want to submit
>> a consequent patch. Otherwise simply describe the problem and
>> a possible fix and we'll implement it.
>>
>> Thanks,
>>
>> --
>> Bastien
>>
>
>
[-- Attachment #2: Type: text/html, Size: 3911 bytes --]
prev parent reply other threads:[~2014-12-01 6:45 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-06 11:00 Weird behavior in `org-agenda-redo' and/or `org-mobile-push' Konstantin Kliakhandler
2014-05-06 15:54 ` Konstantin Kliakhandler
2014-05-06 18:49 ` Konstantin Kliakhandler
2014-05-22 10:59 ` Bastien
2014-05-22 16:08 ` Konstantin Kliakhandler
2014-12-01 6:45 ` Konstantin Kliakhandler [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAH+LVp=rCY5CXVe3EY3XCYU_7MbUFb4p3_ETU=YhhuCtVGY5Tw@mail.gmail.com' \
--to=kosta@slumpy.org \
--cc=bzg@gnu.org \
--cc=emacs-orgmode@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).