From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alexander Vorobiev Subject: Re: [PATCH] org-compat: Support for getting data from Windows clipboard Date: Mon, 18 Nov 2013 22:53:16 -0600 Message-ID: References: <878uwn7837.fsf@bzg.ath.cx> <871u2et621.fsf@bzg.ath.cx> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary=047d7b6d9b1c80f01304eb807225 Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:36679) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VidJi-0005dI-LP for emacs-orgmode@gnu.org; Mon, 18 Nov 2013 23:53:39 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VidJh-00072i-5C for emacs-orgmode@gnu.org; Mon, 18 Nov 2013 23:53:38 -0500 In-Reply-To: List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Fabrice Popineau Cc: Bastien , emacs-orgmode --047d7b6d9b1c80f01304eb807225 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable I too was thinking of making the change to org-get-x-clipboard-compat instead, but somehow decided not to. It calls x-get-selection and the latter, while it does have w32-specific flavor (in w32-common-fns.el), doesn't seem to support clipboard and its primary purpose is stated as "Fix interface to (X-specific) mouse.el." As far as org-no-properties goes, I don't think it will make any difference on Windows because it looks like only plain text is supported (see e.g. http://www.mail-archive.com/help-emacs-windows@gnu.org/msg03026.html and the code in http://git.savannah.gnu.org/cgit/emacs.git/tree/src/w32select.c= ) anyway. So it is hard to say where the patch clearly belongs (w32-common-fns.el (x-get-selection) perhaps?). I can move it to org-get-x-clipboard-compat of course but some change would still need to be done to org-get-x-clipboard because it checks for (eq window-system 'x) explicitly. Let me know what works better. Thanks Alex On Mon, Nov 18, 2013 at 5:34 AM, Fabrice Popineau < fabrice.popineau@supelec.fr> wrote: > Yes, you could lift the patch up to `org-get-x-clipboard-compat', > but this way, =F2rg-no-properties' would be applied to the w32 data too. > Is that relevant? I don't know if w32 clipboard data can have text > properties. > > Fabrice > > > 2013/11/18 Bastien > >> Hi Alexander, >> >> Alexander Vorobiev writes: >> >> > Sorry for the mis-formatting. Here is the patch as an attachment. >> >> Thanks -- digging into this again, maybe we need to fix >> `org-get-x-clipboard-compat' directly? >> >> I'm not using Windows so I can't test the patch. >> >> Can a Windows user help here? >> >> -- >> Bastien >> >> > > > -- > Fabrice Popineau > ----------------------------- > SUPELEC > D=E9partement Informatique > 3, rue Joliot Curie > 91192 Gif/Yvette Cedex > Tel direct : +33 (0) 169851950 > Standard : +33 (0) 169851212 > ------------------------------ > > --047d7b6d9b1c80f01304eb807225 Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable
I too was thinking of making the change to=A0org-get-x-clipboard-compat= instead, but somehow decided not to. It calls x-get-selection and the latt= er, while it does have w32-specific flavor (in w32-common-fns.el), doesn= 9;t seem to support clipboard and its primary purpose is stated as "Fi= x interface to (X-specific) mouse.el."

As far a= s org-no-properties goes, I don't think it will make any difference on = Windows because it looks like only plain text is supported (see e.g.=A0http://www.mail-archive.com/help-= emacs-windows@gnu.org/msg03026.html and the code in=A0http://git.savan= nah.gnu.org/cgit/emacs.git/tree/src/w32select.c) anyway. So it is hard = to say where the patch clearly belongs (w32-common-fns.el (x-get-selection)= perhaps?). I can move it to org-get-x-clipboard-compat of course but some = change would still need to be done to=A0org-get-x-clipboard=A0because it checks for=A0(eq window-system 'x) explicitly. Let me kno= w what works better.

Tha= nks
Alex



On Mon, Nov 18, 2013 at 5:34 AM, Fabrice Popineau <= fabrice.popineau@supelec.fr> wrote:
Yes, you could lift the patch up to `org-get-x-clipboard= -compat',
but this way,= =A0=F2rg-no-properties&= #39; would be applied to the w32 data too.
Is that relevant? I don&#= 39;t know if w32 clipboard data can have text properties.
=
Fabrice


2013/11/18 Bastien <bzg@gnu.org>
Hi Alexander,

Alexander Vorobiev <alexander.vorobiev@gmail.com> writes:

> Sorry for the mis-formatting. Here is the patch as an attac= hment.

Thanks -- digging into this again, maybe we need to fix
`org-get-x-clipboard-compat' directly?

I'm not using Windows so I can't test the patch.

Can a Windows user help here?

--
=A0Bastien




--
Fabrice Popineau-----------------------------
SUPELEC
D=E9partement In= formatique
3, rue Joliot Curie
91192 Gif/Yvette Cedex
Tel direct : +33 (0) 169851950
------------------------------


--047d7b6d9b1c80f01304eb807225--