emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: "Christian Köstlin" <christian.koestlin@gmail.com>
To: emacs-orgmode@gnu.org
Subject: [PATCH] Ignore flaky ob-python tests
Date: Wed, 2 Nov 2022 01:41:08 +0100	[thread overview]
Message-ID: <CAG741+b=y2ae8T+7zqO2a35Mn7A2R9pRf4t+bxuhuB0HzLGFDA@mail.gmail.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 235 bytes --]

The new async feature of python seems to be implemented in a way
that can break with high CPU load. This patch still runs the 3 tests in
question, but does not fail the complete testsuite if any of those fail.

Kind regards,
Christian

[-- Attachment #2: 0001-testing-lisp-test-ob-python.el-Ignore-flaky-tests.patch --]
[-- Type: application/octet-stream, Size: 1506 bytes --]

From d351883f774cf90048b9adecee4c79c8e30ccd52 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Christian=20K=C3=B6stlin?= <christian.koestlin@gmail.com>
Date: Wed, 2 Nov 2022 01:02:05 +0100
Subject: [PATCH] testing/lisp/test-ob-python.el: Ignore flaky tests

TINYCHANGE
---
 testing/lisp/test-ob-python.el | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/testing/lisp/test-ob-python.el b/testing/lisp/test-ob-python.el
index 1f5674013..b45d2c05c 100644
--- a/testing/lisp/test-ob-python.el
+++ b/testing/lisp/test-ob-python.el
@@ -209,6 +209,7 @@ time.sleep(.1)
 	    (org-babel-execute-src-block)))))
 
 (ert-deftest test-ob-python/async-simple-session-output ()
+  :expected-result t
   (let ((org-babel-temporary-directory temporary-file-directory)
         (org-confirm-babel-evaluate nil))
     (org-test-with-temp-text
@@ -226,6 +227,7 @@ print('Yep!')
 			       (org-babel-read-result)))))))))
 
 (ert-deftest test-ob-python/async-named-output ()
+  :expected-result t
   (let (org-confirm-babel-evaluate
         (org-babel-temporary-directory temporary-file-directory)
         (src-block "#+begin_src python :async :session :results output
@@ -250,6 +252,7 @@ print(\"Yep!\")
                              (buffer-string)))))))
 
 (ert-deftest test-ob-python/async-output-drawer ()
+  :expected-result t
   (let (org-confirm-babel-evaluate
         (org-babel-temporary-directory temporary-file-directory)
         (src-block "#+begin_src python :async :session :results output drawer
-- 
2.38.0


             reply	other threads:[~2022-11-02  0:43 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-02  0:41 Christian Köstlin [this message]
2022-11-02  6:53 ` [PATCH] Ignore flaky ob-python tests Ihor Radchenko
2022-11-02 11:15   ` Christian Köstlin
2022-11-02 13:55     ` Jack Kamm
2022-11-02 14:12       ` Ihor Radchenko
2022-11-02 14:17         ` Ihor Radchenko
2022-11-03  7:14     ` Ihor Radchenko
2022-11-03 21:15       ` Christian Köstlin
2022-11-04  4:19         ` Ihor Radchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAG741+b=y2ae8T+7zqO2a35Mn7A2R9pRf4t+bxuhuB0HzLGFDA@mail.gmail.com' \
    --to=christian.koestlin@gmail.com \
    --cc=emacs-orgmode@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).