emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed

From: Kaushal Modi <kaushal.modi@gmail.com>
To: Jan Seeger <jan.seeger@thenybble.de>, emacs-orgmode@gnu.org
Subject: Re: [PATCH] Fixed bug in custom timestamps for date ranges.
Date: Thu, 06 Jul 2017 12:58:31 +0000	[thread overview]
Message-ID: <CAFyQvY3z+A_jFCeGAA+nC2z4-TEoF4xsJifhEFdHAj4uofLptg@mail.gmail.com> (raw)
In-Reply-To: <20170706090900.14204-1-jan.seeger@thenybble.de>

[-- Attachment #1: Type: text/plain, Size: 1468 bytes --]

Hi Jan,

I haven't reviewed the patch functionality, but I see that it is missing a
commit message. Please review this to learn about the required format for
commit messages:

http://orgmode.org/worg/org-contribute.html#commit-messages

Thanks.

On Thu, Jul 6, 2017, 5:10 AM Jan Seeger <jan.seeger@thenybble.de> wrote:

> Changed org-activate-dates to activate custom timestamps for both
> dates in date ranges. Formerly, only the second date would be
> activated. The reason was a misplaced "if". Replaced it with "when".
> ---
>  lisp/org.el | 8 +++++---
>  1 file changed, 5 insertions(+), 3 deletions(-)
>
> diff --git a/lisp/org.el b/lisp/org.el
> index ab0bde1ef..f000c8f24 100644
> --- a/lisp/org.el
> +++ b/lisp/org.el
> @@ -6105,9 +6105,11 @@ by a #."
>                                'keymap org-mouse-map))
>      (org-rear-nonsticky-at (match-end 0))
>      (when org-display-custom-times
> -      (if (match-end 3)
> -         (org-display-custom-time (match-beginning 3) (match-end 3))
> -       (org-display-custom-time (match-beginning 1) (match-end 1))))
> +      ;; If it's a date range, activate custom time for second date
> +      (when (match-end 3)
> +       (org-display-custom-time (match-beginning 3) (match-end 3)))
> +      ;; Always  activate custom time for first matched date
> +      (org-display-custom-time (match-beginning 1) (match-end 1)))
>      t))
>
>  (defvar-local org-target-link-regexp nil
> --
> 2.13.0
>
-- 

Kaushal Modi

[-- Attachment #2: Type: text/html, Size: 2143 bytes --]

next prev parent reply	other threads:[~2017-07-06 12:58 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-06  9:09 [PATCH] Fixed bug in custom timestamps for date ranges Jan Seeger
2017-07-06 12:58 ` Kaushal Modi [this message]
2017-07-06 15:19   ` [PATCH] org.el: Fix " Jan Seeger
2017-07-06 17:22     ` Nicolas Goaziou

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAFyQvY3z+A_jFCeGAA+nC2z4-TEoF4xsJifhEFdHAj4uofLptg@mail.gmail.com \
    --to=kaushal.modi@gmail.com \
    --cc=emacs-orgmode@gnu.org \
    --cc=jan.seeger@thenybble.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).