From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kaushal Modi Subject: Re: Bug or not a bug? dot expansion in ob-shell Date: Thu, 27 Feb 2020 09:25:55 -0500 Message-ID: References: <87eeur3p1p.fsf@ucl.ac.uk> <87a75eap8k.fsf@gnu.org> <87y2sy3kkl.fsf@ucl.ac.uk> <87r1yq4xiz.fsf@gnu.org> <875zg2kcy0.fsf@ucl.ac.uk> <874kvmsrpw.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="000000000000e050c8059f8f8142" Return-path: Received: from eggs.gnu.org ([2001:470:142:3::10]:46460) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j7K7b-0007Ku-Fp for emacs-orgmode@gnu.org; Thu, 27 Feb 2020 09:26:40 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j7K7a-0007Xf-E8 for emacs-orgmode@gnu.org; Thu, 27 Feb 2020 09:26:39 -0500 In-Reply-To: <874kvmsrpw.fsf@gnu.org> List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane-mx.org@gnu.org Sender: "Emacs-orgmode" To: Bastien Cc: Vladimir Nikishkin , "emacs-orgmode@gnu.org" , "Fraga, Eric" --000000000000e050c8059f8f8142 Content-Type: text/plain; charset="UTF-8" Hello all, On Wed, Feb 19, 2020 at 7:11 AM Bastien wrote: > Hi Eric, > > note that the previous behavior only _seemed_ right by chance: there > is no notion of getting the exit code of the shell command in > ob-shell.el, and returning "0" is just a hazard here, just because > (org-babel--string-to-number ".") returns "0", while it should return > nil. > Seems like I missed this long thread. After this change to org-babel--string-to-number, now (org-babel--string-to-number "1,3-5") is now returning 1 (instead of returning nil as before). Related thread that I just started: https://lists.gnu.org/r/emacs-orgmode/2020-02/msg00932.html --000000000000e050c8059f8f8142 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hello all,


On Wed, Feb 19, 202= 0 at 7:11 AM Bastien <bzg@gnu.org>= wrote:
Hi Eric,=

note that the previous behavior only _seemed_ right by chance: there
is no notion of getting the exit code of the shell command in
ob-shell.el, and returning "0" is just a hazard here, just becaus= e
(org-babel--string-to-number ".") returns "0", while it= should return
nil.

Seems like I missed this long thre= ad. After this change to org-babel--string-to-number, now (org-babel--strin= g-to-number "1,3-5") is now returning 1 (instead of returning nil= as before).

Related thread that I just started: <= a href=3D"https://lists.gnu.org/r/emacs-orgmode/2020-02/msg00932.html">http= s://lists.gnu.org/r/emacs-orgmode/2020-02/msg00932.html
--000000000000e050c8059f8f8142--