From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kaushal Modi Subject: Re: [PATCH] org-capture: Add a custom to control save target file or not. Date: Thu, 13 Dec 2018 10:24:47 -0500 Message-ID: References: <19dc1211.1e75.162b770bd5c.Coremail.tumashu@163.com> <87po34y2ya.fsf@nicolasgoaziou.fr> <77a63bcf.32cc.162bcc4a5d0.Coremail.tumashu@163.com> <877epap70f.fsf@nicolasgoaziou.fr> <875zyro5jz.fsf@gmail.com> <87sh1t5ots.fsf@nicolasgoaziou.fr> <87o9cg6ci3.fsf@nicolasgoaziou.fr> <87sh1szjhf.fsf@gmail.com> <3C79C151-715A-4BF7-8CBF-63614A723721@scratch.space> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="000000000000849026057ce8ec54" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:48450) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gXSrl-0006n6-Sv for emacs-orgmode@gnu.org; Thu, 13 Dec 2018 10:25:34 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gXSrj-00011a-Ua for emacs-orgmode@gnu.org; Thu, 13 Dec 2018 10:25:32 -0500 In-Reply-To: List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: "Emacs-orgmode" To: Nicolas Goaziou Cc: van@scratch.space, Eric Abrahamsen , emacs-org list , Bastien Guerry --000000000000849026057ce8ec54 Content-Type: multipart/alternative; boundary="000000000000849022057ce8ec52" --000000000000849022057ce8ec52 Content-Type: text/plain; charset="UTF-8" On Thu, Dec 13, 2018 at 10:08 AM Kaushal Modi wrote: > Hello Nicolas, > > While we are planning to cut Org 9.2 release this week, this one > regression in the Org Capture and auto-saving behavior comes to my mind, > that I think should be fixed. > > Summary: > > In Org 9.1.x, org-capture target files got auto-saved after C-c C-c when > ending the capture. In Org master branch, that stopped happening. > > As per your last proposal, we should revert > https://code.orgmode.org/bzg/org-mode/commit/b4422add3745c26ec3b2e11b8da425844b2e9d3d > and then add a :no-save option that skips that save-buffer call. > I have formatted 2 patches to address this (attached). If they look fine, I can commit them to master. --000000000000849022057ce8ec52 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
On Thu, Dec 13= , 2018 at 10:08 AM Kaushal Modi <kaushal.modi@gmail.com> wrote:
Hello Nicolas,

While we are= planning to cut Org 9.2 release this week, this one regression in the Org = Capture and auto-saving behavior comes to my mind, that I think should be f= ixed.

Summary:

In Org 9.1= .x, org-capture target files got auto-saved after C-c C-c when ending the c= apture. In Org master branch, that stopped happening.

<= div>As per your last proposal, we should revert https://code.orgmode.org/bzg/org-mode/commit/b4422add3745c26e= c3b2e11b8da425844b2e9d3d and then add a :no-save option that skips that= save-buffer call.

<= /div>
I have formatted 2 patches to address this (attached). If they lo= ok fine, I can commit them to master.
--000000000000849022057ce8ec52-- --000000000000849026057ce8ec54 Content-Type: application/octet-stream; name="0001-Revert-org-capture-Do-not-save-buffer-when-running-o.patch" Content-Disposition: attachment; filename="0001-Revert-org-capture-Do-not-save-buffer-when-running-o.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_jpmr84jv0 RnJvbSA1NDEyM2NkN2YyMDIyN2Q5Njc5MTMwYmVlOTA3ZWRlOWU0MmU3M2ZkIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBLYXVzaGFsIE1vZGkgPGthdXNoYWwubW9kaUBnbWFpbC5jb20+ CkRhdGU6IFRodSwgMTMgRGVjIDIwMTggMTA6MTE6MjUgLTA1MDAKU3ViamVjdDogW1BBVENIIDEv Ml0gUmV2ZXJ0ICJvcmctY2FwdHVyZTogRG8gbm90IHNhdmUgYnVmZmVyIHdoZW4gcnVubmluZwog YG9yZy1jYXB0dXJlLWZpbmFsaXplJyIKClRoaXMgcmV2ZXJ0cyBjb21taXQgYjQ0MjJhZGQzNzQ1 YzI2ZWMzYjJlMTFiOGRhNDI1ODQ0YjJlOWQzZC4KClJldmVydCB0aGUgcmVncmVzc2lvbiBpbiBP cmcgY2FwdHVyZSArIGF1dG8tc2F2aW5nIGJlaGF2aW9yLgoKUmVmOiBodHRwczovL2xpc3RzLmdu dS5vcmcvci9lbWFjcy1vcmdtb2RlLzIwMTgtMDkvbXNnMDAzMjUuaHRtbAotLS0KIGxpc3Avb3Jn LWNhcHR1cmUuZWwgfCAxICsKIDEgZmlsZSBjaGFuZ2VkLCAxIGluc2VydGlvbigrKQoKZGlmZiAt LWdpdCBhL2xpc3Avb3JnLWNhcHR1cmUuZWwgYi9saXNwL29yZy1jYXB0dXJlLmVsCmluZGV4IDI5 NDZiNmZjNS4uYTQ2M2UyOWZhIDEwMDY0NAotLS0gYS9saXNwL29yZy1jYXB0dXJlLmVsCisrKyBi L2xpc3Avb3JnLWNhcHR1cmUuZWwKQEAgLTc5Niw2ICs3OTYsNyBAQCBjYXB0dXJlZCBpdGVtIGFm dGVyIGZpbmFsaXppbmcuIgogCShvcmctZW5jcnlwdC1lbnRyeSkpKQogCiAgICAgOzsgS2lsbCB0 aGUgaW5kaXJlY3QgYnVmZmVyCisgICAgKHNhdmUtYnVmZmVyKQogICAgIChsZXQgKChyZXR1cm4t d2NvbmYgKG9yZy1jYXB0dXJlLWdldCA6cmV0dXJuLXRvLXdjb25mICdsb2NhbCkpCiAJICAobmV3 LWJ1ZmZlciAob3JnLWNhcHR1cmUtZ2V0IDpuZXctYnVmZmVyICdsb2NhbCkpCiAJICAoa2lsbC1i dWZmZXIgKG9yZy1jYXB0dXJlLWdldCA6a2lsbC1idWZmZXIgJ2xvY2FsKSkKLS0gCjIuMTguMC41 NDcuZzFkODkzMThjNAoK --000000000000849026057ce8ec54 Content-Type: application/octet-stream; name="0002-Add-no-save-keyword-for-Org-capture-templates.patch" Content-Disposition: attachment; filename="0002-Add-no-save-keyword-for-Org-capture-templates.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_jpmr84ka1 RnJvbSBjYmU3ZDAzYjQyN2IzMWYzMGFmMDQ3NjFlYWIwNGRkNzAxOTFiNjRiIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBLYXVzaGFsIE1vZGkgPGthdXNoYWwubW9kaUBnbWFpbC5jb20+ CkRhdGU6IFRodSwgMTMgRGVjIDIwMTggMTA6MTg6MTggLTA1MDAKU3ViamVjdDogW1BBVENIIDIv Ml0gQWRkIDpuby1zYXZlIGtleXdvcmQgZm9yIE9yZyBjYXB0dXJlIHRlbXBsYXRlcwoKU2V0dGlu ZyB0aGlzIHdpbGwgcHJldmVudCBjYXB0dXJlIHRhcmdldCBmaWxlIHNhdmluZyB1cG9uIGZpbmlz aGluZyBhCmNhcHR1cmUuCgpSZWY6IGh0dHBzOi8vbGlzdHMuZ251Lm9yZy9yL2VtYWNzLW9yZ21v ZGUvMjAxOC0wOS9tc2cwMDMyNS5odG1sCi0tLQogZG9jL29yZy1tYW51YWwub3JnICB8IDQgKysr KwogbGlzcC9vcmctY2FwdHVyZS5lbCB8IDggKysrKysrLS0KIDIgZmlsZXMgY2hhbmdlZCwgMTAg aW5zZXJ0aW9ucygrKSwgMiBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9kb2Mvb3JnLW1hbnVh bC5vcmcgYi9kb2Mvb3JnLW1hbnVhbC5vcmcKaW5kZXggMDUxZmZhYTRkLi5iMzAxZDBhNmEgMTAw NjQ0Ci0tLSBhL2RvYy9vcmctbWFudWFsLm9yZworKysgYi9kb2Mvb3JnLW1hbnVhbC5vcmcKQEAg LTczNTIsNiArNzM1MiwxMCBAQCBOb3cgbGV0cyBsb29rIGF0IHRoZSBlbGVtZW50cyBvZiBhIHRl bXBsYXRlIGRlZmluaXRpb24uICBFYWNoIGVudHJ5IGluCiAgICAgICAgICAgSWYgdGhlIHRhcmdl dCBmaWxlIHdhcyBub3QgeWV0IHZpc2l0ZWQgd2hlbiBjYXB0dXJlIHdhcyBpbnZva2VkLCBraWxs CiAgICAgICAgICAgdGhlIGJ1ZmZlciBhZ2FpbiBhZnRlciBjYXB0dXJlIGlzIGNvbXBsZXRlZC4K IAorICAgICAtIH46bm8tc2F2ZX4gOjoKKworICAgICAgICAgIERvIG5vdCBzYXZlIHRoZSB0YXJn ZXQgZmlsZSBhZnRlciBmaW5pc2hpbmcgdGhlIGNhcHR1cmUuCisKICoqKiogVGVtcGxhdGUgZXhw YW5zaW9uCiA6UFJPUEVSVElFUzoKIDpERVNDUklQVElPTjogRmlsbGluZyBpbiBpbmZvcm1hdGlv biBhYm91dCB0aW1lIGFuZCBjb250ZXh0LgpkaWZmIC0tZ2l0IGEvbGlzcC9vcmctY2FwdHVyZS5l bCBiL2xpc3Avb3JnLWNhcHR1cmUuZWwKaW5kZXggYTQ2M2UyOWZhLi4xZDgzNzQxZmMgMTAwNjQ0 Ci0tLSBhL2xpc3Avb3JnLWNhcHR1cmUuZWwKKysrIGIvbGlzcC9vcmctY2FwdHVyZS5lbApAQCAt MjY2LDYgKzI2Niw4IEBAIHByb3BlcnRpZXMgYXJlOgogICAgICAgICAgICAgICAgICAgICAgY2Fw dHVyZSB3YXMgaW52b2tlZCwga2lsbCB0aGUgYnVmZmVyIGFnYWluIGFmdGVyIGNhcHR1cmUKICAg ICAgICAgICAgICAgICAgICAgIGlzIGZpbmFsaXplZC4KIAorIDpuby1zYXZlICAgICAgICAgICAg RG8gbm90IHNhdmUgdGhlIHRhcmdldCBmaWxlIGFmdGVyIGZpbmlzaGluZyB0aGUgY2FwdHVyZS4K KwogVGhlIHRlbXBsYXRlIGRlZmluZXMgdGhlIHRleHQgdG8gYmUgaW5zZXJ0ZWQuICBPZnRlbiB0 aGlzIGlzIGFuCiBPcmcgbW9kZSBlbnRyeSAoc28gdGhlIGZpcnN0IGxpbmUgc2hvdWxkIHN0YXJ0 IHdpdGggYSBzdGFyKSB0aGF0CiB3aWxsIGJlIGZpbGVkIGFzIGEgY2hpbGQgb2YgdGhlIHRhcmdl dCBoZWFkbGluZS4gIEl0IGNhbiBhbHNvIGJlCkBAIC03OTUsOCArNzk3LDEwIEBAIGNhcHR1cmVk IGl0ZW0gYWZ0ZXIgZmluYWxpemluZy4iCiAJKGdvdG8tY2hhciAob3JnLWNhcHR1cmUtZ2V0IDpk ZWNyeXB0ZWQpKQogCShvcmctZW5jcnlwdC1lbnRyeSkpKQogCi0gICAgOzsgS2lsbCB0aGUgaW5k aXJlY3QgYnVmZmVyCi0gICAgKHNhdmUtYnVmZmVyKQorICAgICh1bmxlc3MgKG9yZy1jYXB0dXJl LWdldCA6bm8tc2F2ZSkKKyAgICAgIDs7IFNhdmUgdGhlIHRhcmdldCBmaWxlLgorICAgICAgKHNh dmUtYnVmZmVyKSkKKwogICAgIChsZXQgKChyZXR1cm4td2NvbmYgKG9yZy1jYXB0dXJlLWdldCA6 cmV0dXJuLXRvLXdjb25mICdsb2NhbCkpCiAJICAobmV3LWJ1ZmZlciAob3JnLWNhcHR1cmUtZ2V0 IDpuZXctYnVmZmVyICdsb2NhbCkpCiAJICAoa2lsbC1idWZmZXIgKG9yZy1jYXB0dXJlLWdldCA6 a2lsbC1idWZmZXIgJ2xvY2FsKSkKLS0gCjIuMTguMC41NDcuZzFkODkzMThjNAoK --000000000000849026057ce8ec54--