From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kaushal Modi Subject: Fix org.el compilation warnings Date: Thu, 25 May 2017 22:31:16 +0000 Message-ID: Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="f403045ff56813298f055060c8f7" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:44369) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dE1I2-0007zB-GV for emacs-orgmode@gnu.org; Thu, 25 May 2017 18:31:31 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dE1I1-0007tI-CZ for emacs-orgmode@gnu.org; Thu, 25 May 2017 18:31:30 -0400 Received: from mail-lf0-x234.google.com ([2a00:1450:4010:c07::234]:32863) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dE1I1-0007t7-4j for emacs-orgmode@gnu.org; Thu, 25 May 2017 18:31:29 -0400 Received: by mail-lf0-x234.google.com with SMTP id m18so91206554lfj.0 for ; Thu, 25 May 2017 15:31:28 -0700 (PDT) List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: "Emacs-orgmode" To: emacs-org list --f403045ff56813298f055060c8f7 Content-Type: text/plain; charset="UTF-8" Hello, I was trying to fix the org.el compilation warnings. I could fix just this one: >From 4e2de052dd05e66ed71ce070e4413859e2c13238 Mon Sep 17 00:00:00 2001 From: Kaushal Modi Date: Thu, 25 May 2017 18:24:34 -0400 Subject: [PATCH] org: Silence byte-compiler * lisp/org.el (org-agenda-include-inactive-timestamps): Silence byte-compiler. --- lisp/org.el | 2 ++ 1 file changed, 2 insertions(+) diff --git a/lisp/org.el b/lisp/org.el index 946d8af8c..d1c70ab97 100644 --- a/lisp/org.el +++ b/lisp/org.el @@ -175,6 +175,8 @@ Stars are put in group 1 and the trimmed body in group 2.") (declare-function org-export-get-environment "ox" (&optional backend subtreep ext-plist)) (declare-function org-latex-make-preamble "ox-latex" (info &optional template snippet?)) +(defvar org-agenda-include-inactive-timestamps) ;Silence byte-compiler + (defsubst org-uniquify (list) "Non-destructively remove duplicate elements from LIST." (let ((res (copy-sequence list))) (delete-dups res))) -- 2.13.0 There are still these 4 warnings for org.el: In org-goto-map: org.el:7502:9:Warning: function org-goto-map used to take 0+ arguments, now takes 0 In org-todo: org.el:12488:12:Warning: function org-todo used to take 0+ arguments, now takes 0-1 In org-store-log-note: org.el:13725:8:Warning: function org-store-log-note used to take 0+ arguments, now takes 0 In org-self-insert-command: org.el:20000:32:Warning: function org-self-insert-command used to take 0+ arguments, now takes 1 -- Kaushal Modi --f403045ff56813298f055060c8f7 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hello,

I was trying to fix the org.el c= ompilation warnings.

I could fix just this one:

From 4e2de052dd05e66ed71ce070e4413859e2c13238 M= on Sep 17 00:00:00 2001
From: Kaushal Modi <kaushal.modi@gmail.com>
Date: Thu,= 25 May 2017 18:24:34 -0400
Subject: [PATCH] org: Silence byte-co= mpiler

* lisp/org.el (org-agenda-include-inactive-= timestamps): Silence
=C2=A0 byte-compiler.
---
=C2=A0lisp/org.el | 2 ++
=C2=A01 file changed, 2 insertions(+)<= /div>

diff --git a/lisp/org.el b/lisp/org.el
i= ndex 946d8af8c..d1c70ab97 100644
--- a/lisp/org.el
+++ = b/lisp/org.el
@@ -175,6 +175,8 @@ Stars are put in group 1 and th= e trimmed body in group 2.")
=C2=A0(declare-function org-exp= ort-get-environment "ox" (&optional backend subtreep ext-plis= t))
=C2=A0(declare-function org-latex-make-preamble "ox-late= x" (info &optional template snippet?))
=C2=A0
= +(defvar org-agenda-include-inactive-timestamps) ;Silence byte-compiler
+
=C2=A0(defsubst org-uniquify (list)
=C2=A0 =C2= =A0"Non-destructively remove duplicate elements from LIST."
=
=C2=A0 =C2=A0(let ((res (copy-sequence list))) (delete-dups res)))
--=C2=A0
2.13.0


<= div>There are still these 4 warnings for org.el:

<= div>In org-goto-map:
org.el:7502:9:Warning: function org-goto-map= used to take 0+ arguments, now
=C2=A0 =C2=A0 takes 0
<= br>
In org-todo:
org.el:12488:12:Warning: function org-= todo used to take 0+ arguments, now
=C2=A0 =C2=A0 takes 0-1
=

In org-store-log-note:
org.el:13725:8:Warning= : function org-store-log-note used to take 0+ arguments,
=C2=A0 = =C2=A0 now takes 0

In org-self-insert-command:
org.el:20000:32:Warning: function org-self-insert-command used to ta= ke 0+
=C2=A0 =C2=A0 arguments, now takes 1

--

Kaushal Modi

--f403045ff56813298f055060c8f7--