emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed

From: Kaushal Modi <kaushal.modi@gmail.com>
To: emacs-org list <emacs-orgmode@gnu.org>
Subject: Fix org.el compilation warnings
Date: Thu, 25 May 2017 22:31:16 +0000	[thread overview]
Message-ID: <CAFyQvY38Yj-AnHVGtJW6cSobvy_=WMyL=zS8YHQaRpRXKzxGBQ@mail.gmail.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 1554 bytes --]

Hello,

I was trying to fix the org.el compilation warnings.

I could fix just this one:

From 4e2de052dd05e66ed71ce070e4413859e2c13238 Mon Sep 17 00:00:00 2001
From: Kaushal Modi <kaushal.modi@gmail.com>
Date: Thu, 25 May 2017 18:24:34 -0400
Subject: [PATCH] org: Silence byte-compiler

* lisp/org.el (org-agenda-include-inactive-timestamps): Silence
  byte-compiler.
---
 lisp/org.el | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/lisp/org.el b/lisp/org.el
index 946d8af8c..d1c70ab97 100644
--- a/lisp/org.el
+++ b/lisp/org.el
@@ -175,6 +175,8 @@ Stars are put in group 1 and the trimmed body in group
2.")
 (declare-function org-export-get-environment "ox" (&optional backend
subtreep ext-plist))
 (declare-function org-latex-make-preamble "ox-latex" (info &optional
template snippet?))

+(defvar org-agenda-include-inactive-timestamps) ;Silence byte-compiler
+
 (defsubst org-uniquify (list)
   "Non-destructively remove duplicate elements from LIST."
   (let ((res (copy-sequence list))) (delete-dups res)))
-- 
2.13.0


There are still these 4 warnings for org.el:

In org-goto-map:
org.el:7502:9:Warning: function org-goto-map used to take 0+ arguments, now
    takes 0

In org-todo:
org.el:12488:12:Warning: function org-todo used to take 0+ arguments, now
    takes 0-1

In org-store-log-note:
org.el:13725:8:Warning: function org-store-log-note used to take 0+
arguments,
    now takes 0

In org-self-insert-command:
org.el:20000:32:Warning: function org-self-insert-command used to take 0+
    arguments, now takes 1

-- 

Kaushal Modi

[-- Attachment #2: Type: text/html, Size: 2355 bytes --]

next             reply	other threads:[~2017-05-25 22:31 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-25 22:31 Kaushal Modi [this message]
2017-05-25 23:59 ` Fix org.el compilation warnings Kyle Meyer
2017-05-26  0:35   ` Kaushal Modi
2017-05-26  2:53     ` Kyle Meyer
2017-05-26  4:32       ` [PATCH] Silence byte-compiler under "make single" Kyle Meyer
2017-05-26 18:14       ` Fix org.el compilation warnings Kaushal Modi
2017-05-26 20:45         ` Kyle Meyer
2017-05-26 22:31           ` Kaushal Modi
2017-05-26 23:17             ` syncing with Emacs (was: Fix org.el compilation warnings) Kyle Meyer

find likely ancestor, descendant, or conflicting patches for this message:
dfblob:946d8af8 dfblob:d1c70ab9
	(help)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAFyQvY38Yj-AnHVGtJW6cSobvy_=WMyL=zS8YHQaRpRXKzxGBQ@mail.gmail.com' \
    --to=kaushal.modi@gmail.com \
    --cc=emacs-orgmode@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).