emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Kaushal Modi <kaushal.modi@gmail.com>
To: lists@wilkesley.net, emacs-orgmode@gnu.org
Subject: Re: Bug? Setting #+OPTIONS: title:nil Seems to Be Ignored in HTML Export.
Date: Mon, 31 Jul 2017 18:33:50 +0000	[thread overview]
Message-ID: <CAFyQvY2s+-SpBROrTCau3hsLuXQHSxg46To4nDz-5xpB+ZxcCQ@mail.gmail.com> (raw)
In-Reply-To: <CAFyQvY2z2zhw_bf3xMtd_jNt5PgHyvxiabHrnrqoiW+3J0fvXA@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 1687 bytes --]

This patch fixes this:

From e57e9e798dd1a54cae7a633fc67e2f825b967eea Mon Sep 17 00:00:00 2001
From: Kaushal Modi <kaushal.modi@gmail.com>
Date: Mon, 31 Jul 2017 14:30:40 -0400
Subject: [PATCH] Respect :with-title in ox-html

* lisp/ox-html.el (org-html--build-meta-info): Do not insert <title>
  tag in HTML export if :with-title property is nil.  Example: by
  setting #+OPTIONS: title:nil

Reported by: Ian <lists@wilkesley.net>
---
 lisp/ox-html.el | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/lisp/ox-html.el b/lisp/ox-html.el
index aeb38ebc10..08381d0c19 100644
--- a/lisp/ox-html.el
+++ b/lisp/ox-html.el
@@ -1812,7 +1812,8 @@ INFO is a plist used as a communication channel."
        viewport-options ", "))
       info)
      "\n")))
-     (format "<title>%s</title>\n" title)
+     (when (plist-get info :with-title)
+       (format "<title>%s</title>\n" title))
      (org-html-close-tag "meta" "name=\"generator\" content=\"Org mode\""
info)
      "\n"
      (and (org-string-nw-p author)
-- 
2.13.0


OK to commit to maint?

On Mon, Jul 31, 2017 at 2:24 PM Kaushal Modi <kaushal.modi@gmail.com> wrote:

>
> C-c C-e h H (html export to buffer) gives:
>
> =====
> <?xml version="1.0" encoding="utf-8"?>
> <!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Strict//EN"
> "http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd">
> <html xmlns="http://www.w3.org/1999/xhtml" lang="en" xml:lang="en">
> <head>
> <!-- 2017-07-31 Mon 14:22 -->
> <meta http-equiv="Content-Type" content="text/html;charset=utf-8" />
> <meta name="viewport" content="width=device-width, initial-scale=1" />
> <title>This Title Must Not Export</title>
> == <snip> ==
>
-- 

Kaushal Modi

[-- Attachment #2: Type: text/html, Size: 3646 bytes --]

  reply	other threads:[~2017-07-31 18:34 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-31 17:35 Bug? Setting #+OPTIONS: title:nil Seems to Be Ignored in HTML Export lists
2017-07-31 18:24 ` Kaushal Modi
2017-07-31 18:33   ` Kaushal Modi [this message]
2017-08-01  8:15     ` Nicolas Goaziou
2017-08-01  9:51     ` Rasmus
2017-08-01 10:41       ` Kaushal Modi
2017-08-01 11:18         ` Rasmus
2017-08-01 19:41           ` Kaushal Modi
2017-08-01 20:48             ` Rasmus
2017-08-01 20:59               ` Kaushal Modi
2017-08-09  9:56                 ` Rasmus
2017-08-09 10:38                   ` Rasmus
2017-08-14 20:15                   ` Kaushal Modi
2017-08-01 22:03               ` Tim Cross
2017-08-01 21:58       ` Tim Cross

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAFyQvY2s+-SpBROrTCau3hsLuXQHSxg46To4nDz-5xpB+ZxcCQ@mail.gmail.com \
    --to=kaushal.modi@gmail.com \
    --cc=emacs-orgmode@gnu.org \
    --cc=lists@wilkesley.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).