From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id cCvpJQMK9F9vQQAA0tVLHw (envelope-from ) for ; Tue, 05 Jan 2021 06:41:07 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id qEm1IQMK9F9HCgAAB5/wlQ (envelope-from ) for ; Tue, 05 Jan 2021 06:41:07 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 65A119402A2 for ; Tue, 5 Jan 2021 06:41:07 +0000 (UTC) Received: from localhost ([::1]:47784 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kwg1h-0003NC-7S for larch@yhetil.org; Tue, 05 Jan 2021 01:41:06 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:51482) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kwfyS-0002Nd-8J for emacs-orgmode@gnu.org; Tue, 05 Jan 2021 01:37:44 -0500 Received: from mail-lf1-x12c.google.com ([2a00:1450:4864:20::12c]:46383) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kwfyK-0005DC-OC for emacs-orgmode@gnu.org; Tue, 05 Jan 2021 01:37:42 -0500 Received: by mail-lf1-x12c.google.com with SMTP id y19so69951155lfa.13 for ; Mon, 04 Jan 2021 22:37:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=quKV77BN/3cvNAz21D588mLIAKTo2C+CqDSP5XqWu3k=; b=mRd6odQqyIEXkNkfyDk4OQMfQBKbDl7kWbdrB+0fLVQRtd79vP/kr0IpiFBPyz8eQ9 7a+fWbSfCO6tDJ8X3bSU6hTVJDs28n+s9CgT8y8YuOkKZhvTVArN5WIMiQJg4sr01lWq kgTGP6lVQjy/TWKCSTcU4vWpgXGpG2PBivKlXCM/iWfN2wbkhSRBQuExKWCwxyrKUMQV ef3IdTrBYizuTwwkWXTcDkMkqsRmpKC853VWuCI2nrCjzp7eu2CZvU8d47CLExdgr3ql w5j6sAW9GVgf4iUVkXW7ODlu05Q2u34WRZvDwkSgumQ8KTT8hGs56Kj51fXDvhhBoWOx OGWg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=quKV77BN/3cvNAz21D588mLIAKTo2C+CqDSP5XqWu3k=; b=le5D6kK9QzLJHoVgD7UasPtT4Hhh9ROwbCTeR4285OjRL4w6aWihHNI6XMJNs6AKYi w1J3gjF9l8vYEGCXfwCAHgDmiEFJpXc1ICh0NkqSeud8Oah/+r/kgNyJ+1uCjyiGh2Dz zscW6EseNNvHAGbXCXXpcI82JfwkD+GeSULnFGpdVkPZ9aO6kz3f63HjxiWCRyx/55KI 5RZVDefR1M7+SnV90DKI36ZjSz9TpC8rCuNVLlCgJjj/SJ+bsnxRjy2OJ9+iDHEl9PIO gNO1T7dvMvPHdhvSBKUv/rjH3nazCLqzLhCpo7uQHIqKrzvBUq25owC4/koObzTI+A0x ZNsQ== X-Gm-Message-State: AOAM533dzDZMDZ4dzwrICtdndtFX6ycvUAAMxSn09z0Jlha/1VR+1TJ6 55vxNjbjyTdcYzlMnLeKaZtA6i5YYiMaSJmu0k3iUoWbV3I= X-Google-Smtp-Source: ABdhPJwLFcF1r1UCuT+LfV2OhvqXVGgIS4NsjOI/OArVEMaBiNPn0Txz6IiQqA9OjLd2+ObrfBerKHWNdbWN8lbEkls= X-Received: by 2002:a19:f203:: with SMTP id q3mr32516846lfh.166.1609828653654; Mon, 04 Jan 2021 22:37:33 -0800 (PST) MIME-Version: 1.0 References: <87czyjzz6x.fsf@kyleam.com> In-Reply-To: <87czyjzz6x.fsf@kyleam.com> From: Kaushal Modi Date: Tue, 5 Jan 2021 01:36:57 -0500 Message-ID: Subject: Re: Regression in table.el detection? [maint] To: Kyle Meyer Content-Type: multipart/alternative; boundary="0000000000000ce61d05b82171b1" Received-SPF: pass client-ip=2a00:1450:4864:20::12c; envelope-from=kaushal.modi@gmail.com; helo=mail-lf1-x12c.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: emacs-org list Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -4.00 Authentication-Results: aspmx1.migadu.com; none X-Migadu-Queue-Id: 65A119402A2 X-Spam-Score: -4.00 X-Migadu-Scanner: scn0.migadu.com X-TUID: 4jbgeDPAJak3 --0000000000000ce61d05b82171b1 Content-Type: text/plain; charset="UTF-8" On Tue, Jan 5, 2021 at 1:15 AM Kyle Meyer wrote: > > > Exporting that table to html, I see "Before" on release_9.4.4, maint > (273391c97), and master (00b4de329). > > You're able to trigger the issue with a vanilla configuration on maint? > Hi Kyle, Thanks for checking. Indeed ox-html export does not show that issue. But the weekly cron (and even local) ox-hugo exports started showing this issue after the update to table.el table detection change that happened a few weeks ago. I'll investigate why only ox-hugo is showing this issue.. I am simply calling the table.el related function from ox-html: ===== (defun org-blackfriday-table (table contents info) "Transcode TABLE element into Blackfriday Markdown format. CONTENTS is contents of the table. INFO is a plist holding contextual information." ;; (message "[ox-bf-table DBG] In contents: %s" contents) (if (eq (org-element-property :type table) 'table.el) ;; "table.el" table. Convert it using appropriate tools. (let ((tbl (org-html-table--table.el-table table info))) (message "%S" table) ; just added this for debug (message "%S" tbl) ; just added this for debug ===== and I am getting only partial table in the "tbl" variable ===== (table (:begin 1860 :end 2062 :type table\.el :tblfm nil :contents-begin nil :contents-end nil :value "+----------+----------+----------+ | Header 1 | Header 2 | Header 3 | +----------+----------+----------+ | a | b | c | +----------+----------+----------+ | d | e | f | +----------+----------+----------+" :post-blank 1 :post-affiliated 1860 :parent (section (:begin 1703 :end 2062 :contents-begin 1703 :contents-end 2062 :post-blank 1 :post-affiliated 1703 :parent (org-data nil #2)) (special-block (:type "description" :begin 1703 :end 1783 :contents-begin 1723 :contents-end 1765 :post-blank 1 :post-affiliated 1703 :parent #2) (paragraph (:begin 1723 :end 1765 :contents-begin 1723 :contents-end 1765 :post-blank 1 :post-affiliated 1723 :parent #3) #("Support tables written in table.el format " 0 42 (:parent #4)))) (paragraph (:begin 1783 :end 1860 :contents-begin 1783 :contents-end 1859 :post-blank 1 :post-affiliated 1783 :parent #2) (verbatim (:value "ox-hugo" :begin 1783 :end 1793 :post-blank 1 :parent #3)) #("Issue #" 0 7 (:parent #3)) (link (:type "https" :path "// github.com/kaushalmodi/ox-hugo/issues/374" :format bracket :raw-link " https://github.com/kaushalmodi/ox-hugo/issues/374" :application nil :search-option nil :begin 1800 :end 1858 :contents-begin 1853 :contents-end 1856 :post-blank 0 :parent #3) #("374" 0 3 (:parent #4))) #(" " 0 1 (:parent #3))) #0))) "
 Header 1   Header 2   Header 3 
" ===== I'll keep looking.. --0000000000000ce61d05b82171b1 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
On Tue, Jan 5, 2021 at 1:15 AM Kyle Meyer <kyle@kyleam.com> wrote:


Exporting that table to html, I see "Before" on release_9.4.4, ma= int
(273391c97), and master (00b4de329).

You're able to trigger the issue with a vanilla configuration on maint?=

Hi Kyle,

Than= ks for checking. Indeed ox-html export does not show that issue.
=
But the weekly cron (and even local) ox-hugo exports started= showing this issue after the update to table.el table detection change tha= t happened a few weeks ago.

I'll investigate w= hy only ox-hugo is showing this issue.. I am simply calling the table.el re= lated function from ox-html:

=3D=3D=3D=3D=3D
=
(defun org-blackfriday-table (table contents info)
=C2=A0 "Tra= nscode TABLE element into Blackfriday Markdown format.

CONTENTS is c= ontents of the table.=C2=A0 INFO is a plist holding
contextual informati= on."
=C2=A0 ;; (message "[ox-bf-table DBG] In contents: %s&quo= t; contents)
=C2=A0 (if (eq (org-element-property :type table) 'tabl= e.el)
=C2=A0 =C2=A0 =C2=A0 ;; "table.el" table.=C2=A0 Convert = it using appropriate tools.
=C2=A0 =C2=A0 =C2=A0 (let ((tbl (org-html-ta= ble--table.el-table table info)))
=C2=A0 =C2=A0 =C2=A0 =C2=A0 (message &= quot;%S" table) ; just added this for debug
=C2=A0 =C2=A0 =C2=A0 = =C2=A0 (message "%S" tbl) ; just added this for debug
=3D=3D=3D=3D=3D

and I am getting only partial t= able in the "tbl" variable

=3D=3D=3D=3D= =3D
(table (:begin 1860 :end 2062 :type table\.el :tblfm nil :con= tents-begin nil :contents-end nil :value "+----------+----------+-----= -----+
| Header 1 | Header 2 | Header 3 |
+----------+----------+----= ------+
| a | b | c |
+----------+----------+----------+
| d | e |= f |
+----------+----------+----------+" :post-blank 1 :post-affili= ated 1860 :parent (section (:begin 1703 :end 2062 :contents-begin 1703 :con= tents-end 2062 :post-blank 1 :post-affiliated 1703 :parent (org-data nil #2= )) (special-block (:type "description" :begin 1703 :end 1783 :con= tents-begin 1723 :contents-end 1765 :post-blank 1 :post-affiliated 1703 :pa= rent #2) (paragraph (:begin 1723 :end 1765 :contents-begin 1723 :contents-e= nd 1765 :post-blank 1 :post-affiliated 1723 :parent #3) #("Support tab= les written in table.el format
" 0 42 (:parent #4)))) (paragraph (:= begin 1783 :end 1860 :contents-begin 1783 :contents-end 1859 :post-blank 1 = :post-affiliated 1783 :parent #2) (verbatim (:value "ox-hugo" :be= gin 1783 :end 1793 :post-blank 1 :parent #3)) #("Issue #" 0 7 (:p= arent #3)) (link (:type "https" :path "//github.com/kaushalmodi/ox-hugo/is= sues/374" :format bracket :raw-link "https://github.com/kaushalmodi/ox-hug= o/issues/374" :application nil :search-option nil :begin 1800 :end= 1858 :contents-begin 1853 :contents-end 1856 :post-blank 0 :parent #3) #(&= quot;374" 0 3 (:parent #4))) #("
" 0 1 (:parent #3))) #0)= ))
"<!-- This HTML table template is generated by emacs 28.0.50 = -->
<table border=3D\"1\">
=C2=A0 <tr>
= =C2=A0 =C2=A0 <td align=3D\"left\" valign=3D\"top\"&= gt;
=C2=A0 =C2=A0 =C2=A0 &nbsp;Header&nbsp;1&nbsp;
=C2=A0= =C2=A0 </td>
=C2=A0 =C2=A0 <td align=3D\"left\" vali= gn=3D\"top\">
=C2=A0 =C2=A0 =C2=A0 &nbsp;Header&nbs= p;2&nbsp;
=C2=A0 =C2=A0 </td>
=C2=A0 =C2=A0 <td align=3D= \"left\" valign=3D\"top\">
=C2=A0 =C2=A0 =C2=A0 &= amp;nbsp;Header&nbsp;3&nbsp;
=C2=A0 =C2=A0 </td>
=C2=A0= </tr>
</table>"
=3D=3D=3D=3D=3D

I'll keep looking..


=

--0000000000000ce61d05b82171b1--