From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id eGipEf+yD2I2zAAAgWs5BA (envelope-from ) for ; Fri, 18 Feb 2022 15:53:51 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id sEkRDv+yD2KrbAAAauVa8A (envelope-from ) for ; Fri, 18 Feb 2022 15:53:51 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id F34CF3425E for ; Fri, 18 Feb 2022 15:53:50 +0100 (CET) Received: from localhost ([::1]:48514 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nL4dq-0001kw-5P for larch@yhetil.org; Fri, 18 Feb 2022 09:53:50 -0500 Received: from eggs.gnu.org ([209.51.188.92]:46250) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nL4cN-0001Ca-5S for emacs-orgmode@gnu.org; Fri, 18 Feb 2022 09:52:20 -0500 Received: from [2607:f8b0:4864:20::b2a] (port=46788 helo=mail-yb1-xb2a.google.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nL4cJ-0007Uh-Q2 for emacs-orgmode@gnu.org; Fri, 18 Feb 2022 09:52:18 -0500 Received: by mail-yb1-xb2a.google.com with SMTP id p5so19939224ybd.13 for ; Fri, 18 Feb 2022 06:52:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Oizx1c/b19wmFnmG0SfAcoVFe1MLNFxR34s3Pu9Nifs=; b=aifHXznAPWs5iqMWZJEMcKXeFNcE0oUMsC+wimxz3KRkEjKmOKdrwykFfG92oTL6z2 MiE1UbTLTNmEGcjPpJEV90osgOJx4gyyWiFopS2+BQptT88VvZHHt7m/rnbeeofH4Aqv eemZRuLSIzaO1Zro6puMpTu8jMSGpR4pn0uwFWuZ9htSp3VF///vujUxBVRCDw8y4+PM ObShR6xYWdNYlBanDRxdc+kSmuj2ngAiBn3d9+K5Abz+P6AWWbE47KihpCJBJNATGge4 tQX9m5aQfC5YS4HDSVWPsIqktn/rW97YDg09Cb61ycewFuN9Mb/QLQbM/sm89/hJaL3T pGXw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Oizx1c/b19wmFnmG0SfAcoVFe1MLNFxR34s3Pu9Nifs=; b=xSB87IM2ioTk96OVbIM6+120AkTIRGhRU27wERr4DzRWZWtewOuyo9M6Py/tz5UQVG I709ljLdP8OpbLbVByxNriWU9hFI3hCgIBPNqAXsLHshxscDwcbQvAe9X+8eNrdkM1Wy 1mH5gW1qHyg+ODN50KeJHTpRKTDURiKOTIdjzwSbfrC06NNBU9hg9T0HsaoQ9WNPfasM yh4SFyJHs6Ck9X+qdKIFreVAUagjI7b3rqQ6GlD7LiqM+iyaOcOx/U6NHlPxOX3pHQ4v 2a5XqR717zA8qMRxlVuoAk+BH40lCJUCuDIrXgMibBZqEwY8j6pKsryJLSuBN/J2YKP1 4bVA== X-Gm-Message-State: AOAM533VYHuL+IMJhud9floX7jKe6E5askAwyR9madwYiOzqiuJienjA mwZNTEaNZk+pUfBPiL5E0vd0Ic5Y7fFxR8LpUPtk8475FU4= X-Google-Smtp-Source: ABdhPJyb2cVUYy67Q+rpsGcE8M0Ot5AvffW3PQiR8Sk2Tp7wh1g+tNQjB35cSyIC3GB9mf/8u/3yAD82WsESRt3ywCY= X-Received: by 2002:a25:8383:0:b0:624:4221:d3c with SMTP id t3-20020a258383000000b0062442210d3cmr3505967ybk.244.1645195928224; Fri, 18 Feb 2022 06:52:08 -0800 (PST) MIME-Version: 1.0 References: <87h7bgstmz.fsf@nicolasgoaziou.fr> In-Reply-To: <87h7bgstmz.fsf@nicolasgoaziou.fr> From: Kaushal Modi Date: Fri, 18 Feb 2022 09:51:32 -0500 Message-ID: Subject: Re: [PATCH] c-csl : accept relative CSL filenames To: Nicolas Goaziou Content-Type: text/plain; charset="UTF-8" X-Host-Lookup-Failed: Reverse DNS lookup failed for 2607:f8b0:4864:20::b2a (failed) Received-SPF: pass client-ip=2607:f8b0:4864:20::b2a; envelope-from=kaushal.modi@gmail.com; helo=mail-yb1-xb2a.google.com X-Spam_score_int: -6 X-Spam_score: -0.7 X-Spam_bar: / X-Spam_report: (-0.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, PDS_HP_HELO_NORDNS=0.659, RCVD_IN_DNSWL_NONE=-0.0001, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: post+orgmodeml@guelker.eu, Emmanuel Charpentier , emacs-org list Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1645196031; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=Oizx1c/b19wmFnmG0SfAcoVFe1MLNFxR34s3Pu9Nifs=; b=XCNV3meaG/qT4gPBK+EEa2zKrPQB7RMGH1iUhcFuJVm9RFINXDBWFRg2dn8KfqtoqusfkZ idNaAz6LIbWSrXg/RXsyAHpKSW4ZPe/vYwOYEQM2P1niv099JYzhcQ4d+ogZ3PNPK1wxPt drB3xtmm6w2PKoQQfA8tBIh4XEN7DYA7pASzbtjamKLIJXf1pptaytJN2J/rGBH+EXiPMD JnsVGmLr+MTNi53hJhLxIw1ZTmVWZwCz3ENqusQJiGVvB+iLM8OVSX0XHk/U1b4FCKAotH 64qtgXw7J0znNFLjeclIyekUPzZx7PcjeryX6tMjo0JSvywhy2UbZ8WxRauHjQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1645196031; a=rsa-sha256; cv=none; b=Wsq0Fak8EbONZ6+88Iy1EVXgwwfmDyZapGoB/x1uTERjA799S1Yb+KYn4b390o2ZqaquRQ VO3tu3pcuTo1Y6863Sis1o+dAvEhZDgrzKFVDgRtHhq7WUAMdFy65mB+oKbTujL0oR57ZC YtHQukTYakQKwWdou3A473c5EVbqIEveE7Xc6NpHhY7pCyBCQyNEc6p2wqa81B552TMeV5 FdT5TZlV4aq9SOcpfyBPfHA6G4yrnpvyf6eSKov1ckAGkcuUjCjR6jDr61HWh/wWqpiV3n hjQSHXBJzU3Ty7Bp9A+Hap8CbqERWXqHo9+dwQBplgX2qh+gViI/zcDS18ZlqQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=aifHXznA; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -0.53 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=aifHXznA; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: F34CF3425E X-Spam-Score: -0.53 X-Migadu-Scanner: scn1.migadu.com X-TUID: 1UW6acbKaa7/ Hello Nicolas, > Since you are probably busy, I implemented this on your behalf. The new > behaviour is in main branch. Thank you. > Can this commit[1] be merged into the main branch. Locally on my machine, I use org built from main and something like this was working fine: #+cite_export: csl cite/csl/ieee.csl Here, "csl cite/csl/ieee.csl" is the csl path relative to the Org file. But when the same ran on a CI where the stable Org version is used, it failed with this error: > Debugger entered--Lisp error: (user-error "Cannot handle relative style file name: "cite/csl/...") > signal(user-error ("Cannot handle relative style file name: "cite/csl/...")) > user-error("Cannot handle relative style file name: %S" "cite/csl/ieee.csl") I believe the behavior I see with this commit on main branch is kind of obvious and it should prevent this surprise failure for other users too. This is my current workaround for the Org stable version: #+cite_export: csl ieee.csl # Local Variables: # org-cite-csl-styles-dir: "./cite/csl/" # End: This works for both main and bugfix, but while doing this, I realized that even string values are not considered safe for this variable. Looking through git revisions, I found https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=41e67cff0d3bf27ffb57f9a230598b0385341517. Earlier `:safe t' was added for `org-cite-csl-styles-dir'. Instead can we have `:safe #'string-or-null-p' as suggested by Glenn Morris in that commit? Thanks! [1]: https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=c6186be3fd6c09a6deaa4edc1fbabbad0cb986d3