From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id 6NLyBslml2JrMAAAbAwnHQ (envelope-from ) for ; Wed, 01 Jun 2022 15:16:57 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id YDjKBslml2JJ7AAAauVa8A (envelope-from ) for ; Wed, 01 Jun 2022 15:16:57 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 98EC92B0CD for ; Wed, 1 Jun 2022 15:16:56 +0200 (CEST) Received: from localhost ([::1]:38036 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nwODX-0004If-9D for larch@yhetil.org; Wed, 01 Jun 2022 09:16:55 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:58362) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nwOBp-0003BB-Ns for emacs-orgmode@gnu.org; Wed, 01 Jun 2022 09:15:10 -0400 Received: from mail-pj1-x1034.google.com ([2607:f8b0:4864:20::1034]:43757) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nwOBn-0006dE-92 for emacs-orgmode@gnu.org; Wed, 01 Jun 2022 09:15:09 -0400 Received: by mail-pj1-x1034.google.com with SMTP id l7-20020a17090aaa8700b001dd1a5b9965so2048419pjq.2 for ; Wed, 01 Jun 2022 06:15:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=N0yaRBkUian5ee+2fAAF6sgFvYh5ugNdXeFTcggmdVM=; b=lAvQTYa4Y/sEXULv33ozU18uouxj6YEpeX5UEnCJQ2vKfYKMTAj+GQvcSzmZkKcn5c uhytma1TqIATaE7VvfDKTw8tgjdyJNpHkOhQCbmEkmyqPCC90niz3ujVBR9huaHXkUmR YyGRznMlKBurRnraqv79M1EuVOXED38vhcXzluL6hGlk1ZKe3adqg5g5/H1Wt8GMyj5W jpE3kYN2aoSNfs7xMjIlfkm/Wpqad0xmc9JiEKj/CcT0lkX9UPVjXP64mivDo7/dIBFv vJH/5RiBnEoKxLft6EuWIL2v46zZpr4ofaZ821rt+DjWfM5p6+SH3P9YlP27es91aeX5 Surw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=N0yaRBkUian5ee+2fAAF6sgFvYh5ugNdXeFTcggmdVM=; b=kCd8rVMJN4laDJdvudrpeNlj+aE0MMcOItBuRLBXw80MCMBeBkHfhSTWI0Ff/ouV4A SSv2Ja1Y5IVXNd160zlptluv8ccuvCYsDtMRC/uM7rQb9fNpseEucNw4f6aHpqm4fxkO FmYtTxewzpILjDR8QuyuH4Mw2z6hwl905+d5pDuTT5pAPym6mW96hG3ADfjc99wzRoSF KobeQM+xclIib+/2ZP1mkg0DI3leQnOOgqE4r++QJE0wsOfQ/+WAZNL7WagCajZTg49N MQBwB9f6RvVNost56OlNZ0/RAPuJPYHrz4BJQQCO35SqZKk5m3z5hXCQKirCUhEF1uzZ GjUw== X-Gm-Message-State: AOAM5306FgKF2zSnIIzEo1P98v3cJtFMXqwZSrimnHxFtv6RGYoYzn0N 0jZB4p94mBNAF/3DdpQCWCohL0BJx43a4lofC4Y= X-Google-Smtp-Source: ABdhPJwrGqInIf9UmB767z2IR7czpFI0CZhfaff2K9hj33w8bcGTM1oepLAgEPSXeKzp7sfNT1FIfZym244FOFyGm3E= X-Received: by 2002:a17:90b:1e4f:b0:1e0:b91:39ef with SMTP id pi15-20020a17090b1e4f00b001e00b9139efmr34125146pjb.51.1654089304649; Wed, 01 Jun 2022 06:15:04 -0700 (PDT) MIME-Version: 1.0 References: <87618398-cf6d-86b4-ba59-144f70d0f96e@7d.nz> In-Reply-To: <87618398-cf6d-86b4-ba59-144f70d0f96e@7d.nz> From: Kaushal Modi Date: Wed, 1 Jun 2022 09:14:27 -0400 Message-ID: Subject: Re: [PATCH] ox: fix comment exported as a blank line To: Phil Estival Cc: emacs-org list Content-Type: text/plain; charset="UTF-8" Received-SPF: pass client-ip=2607:f8b0:4864:20::1034; envelope-from=kaushal.modi@gmail.com; helo=mail-pj1-x1034.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1654089416; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=N0yaRBkUian5ee+2fAAF6sgFvYh5ugNdXeFTcggmdVM=; b=f4qBaUIGumkX+Zb5z0de1lVl4ObuH7ZHURcMZmt/lJctb9aHH7ozIuzto4vKVo+1g/axWY xp277Nz0SILYsA3bbkjvUORfOjUnN0KvDUgUaCCWoWZ62rwQVW+jL4PiRkWp7PzZNtMMno se0oCC3FEWIxVwFlu8mZTZua/hXCcn62hkCLRPjE+/CUmozH2B/Q+/Zjo2UpSRKtY2LQwv Yk6tNDn2q3G4k4g1PW35NAeK1zfO0KTfmv0a19h7YZUYwRDFQIPm/Rnqyd/gGRhu2ym8xJ yvmEtGlZjH6UytFBoGF6zbVMBPESOWKc2oQJs8OBuT5ABMe2PBbkPXP81u9Vtg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1654089416; a=rsa-sha256; cv=none; b=OcAWLShjwKRoVHmsJulukZpMr76cDXGkEgTfJysOs9RsN5ii2TTjrc6HKi2zWabo1edbdE Y0A5ceEw3Oor2VjlzAqg4nGWJ97tH15VAtVjzc7QmyzXUZpT51XF4dAM3XwUymyYror1nY ClA+p4UiNATcO5RnGyzoT3AN2vrPppy8wUf5GfcUqk3/ACDcnLcmwpaA3ekA4QIYcpIR2O /xzEdmvEPBGEfrPyUjTPUw3G/7Zz015UmZ9wsGKCVdkh+Zpll5/sUMjjMvWNC+do8u3Ta6 5TKrfbGFlsBf1+BxihYFODLCd5LuFBs610Jwzzs/vvZNppiQvRZ6IUkYCwuQ2A== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=lAvQTYa4; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -8.83 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=lAvQTYa4; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 98EC92B0CD X-Spam-Score: -8.83 X-Migadu-Scanner: scn0.migadu.com X-TUID: u/AUsYJbp9Ss On Wed, Jun 1, 2022 at 1:32 AM Phil Estival wrote: > > > * lisp/ox.el (org-export--skip-p): no longer export single-line > comments as blank lines which did break paragraphs in two. This is a pretty big breaking change. In your next PATCH email, I see that you are also modifying the test that ensures that a comment line gets parsed as a paragraph break.