From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kaushal Modi Subject: Re: Add an optional HOLD argument to "n" Org macro Date: Sat, 17 Jun 2017 14:34:55 +0000 Message-ID: References: <2ee94a64a94b46259b0da6e7d34675c9@HE1PR01MB1898.eurprd01.prod.exchangelabs.com> <87y3u7o3dj.fsf@t3610> <87pofjtk4b.fsf@t3610> <2069df8c23bc43f3b04b6e203b96be9d@HE1PR01MB1898.eurprd01.prod.exchangelabs.com> <87r2zvpyst.fsf@delle7240> <8760guib5i.fsf@nicolasgoaziou.fr> <87fuftb4lg.fsf@nicolasgoaziou.fr> <8760fyic6n.fsf@nicolasgoaziou.fr> <871sqli69r.fsf@nicolasgoaziou.fr> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="001a114b2c30e1aa94055228ce60" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:57110) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dMEof-0002jA-Jb for emacs-orgmode@gnu.org; Sat, 17 Jun 2017 10:35:10 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dMEoe-0003lw-IS for emacs-orgmode@gnu.org; Sat, 17 Jun 2017 10:35:09 -0400 Received: from mail-lf0-x22c.google.com ([2a00:1450:4010:c07::22c]:35314) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dMEoe-0003jg-BQ for emacs-orgmode@gnu.org; Sat, 17 Jun 2017 10:35:08 -0400 Received: by mail-lf0-x22c.google.com with SMTP id p189so37084340lfe.2 for ; Sat, 17 Jun 2017 07:35:07 -0700 (PDT) In-Reply-To: List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: "Emacs-orgmode" To: Nicolas Goaziou Cc: emacs-org list --001a114b2c30e1aa94055228ce60 Content-Type: text/plain; charset="UTF-8" Hello Nicolas, Just pinging to check if the patch in the previous email got missed. Apologies if you were already reviewing it. Thanks. On Thu, Jun 15, 2017, 2:07 PM Kaushal Modi wrote: > On Thu, Jun 15, 2017 at 12:07 PM Nicolas Goaziou > wrote: > >> We do not need this dependency. In particular, there is already >> `org-trim'. >> > > OK, switch from string-trim to org-trim. Thanks. > > >> It is confusing to provide two ways to achieve the same action. I'd >> rather have "-" only. >> > > OK. > > >> Could you split this into smaller tests, each one testing one feature? >> > > Done. I ended up writing many more tests in the process. While I was doing > that, I realized that only the first arg NAME was ws (whitespace) sensitive > while the second arg wasn't. Now ws trimming is done on both args. > > Revised patch is attached. > -- > > Kaushal Modi > -- Kaushal Modi --001a114b2c30e1aa94055228ce60 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hello Nicolas,

Just pinging to check if the patch in the= previous email got missed.=C2=A0

Apologies if you= were already reviewing it.=C2=A0

Thanks.=C2=A0
On Thu, Jun 15, 2017, 2:07= PM Kaushal Modi <kaushal.modi= @gmail.com> wrote:
On Thu, Jun 15, 2017 a= t 12:07 PM Nicolas Goaziou <mail@nicolasgoaziou.fr> wrote:
We do not need this dependency. In particular, there is = already
`org-trim'.

OK, switch from string-trim to org-trim. T= hanks.
= =C2=A0
It is confusing to provide two w= ays to achieve the same action. I'd
rather have "-" only.

=
OK.
=C2=A0
Could you split this into smaller tests, each one testing one= feature?

Done. I ended up writing many more tests in the = process. While I was doing that, I realized that only the first arg NAME wa= s ws (whitespace) sensitive while the second arg wasn't. Now ws trimmin= g is done on both args.

Revised patch is attached.=
--

Kaushal Modi

--

Kaushal Modi

--001a114b2c30e1aa94055228ce60--