From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kaushal Modi Subject: Debugging at least 2 regressions in org-mode master breaking ox-hugo Date: Thu, 27 Feb 2020 09:00:24 -0500 Message-ID: Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="0000000000009d8aad059f8f26ab" Return-path: Received: from eggs.gnu.org ([2001:470:142:3::10]:41349) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j7Jir-000213-EX for emacs-orgmode@gnu.org; Thu, 27 Feb 2020 09:01:06 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j7Jiq-0000PN-4g for emacs-orgmode@gnu.org; Thu, 27 Feb 2020 09:01:05 -0500 Received: from mail-lf1-x130.google.com ([2a00:1450:4864:20::130]:42631) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1j7Jip-0000Ne-Qz for emacs-orgmode@gnu.org; Thu, 27 Feb 2020 09:01:04 -0500 Received: by mail-lf1-x130.google.com with SMTP id 83so2147327lfh.9 for ; Thu, 27 Feb 2020 06:01:02 -0800 (PST) List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane-mx.org@gnu.org Sender: "Emacs-orgmode" To: emacs-org list --0000000000009d8aad059f8f26ab Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hello, I recently updated to the latest org-mode master and it is failing ox-hugo[1] build and tests at 2 places. Failure 1: org-get-outline-path has moved, and not mentioned in ORG-NEWS Compiling ox-hugo.el now gives: ox-hugo.el:4284:1: Warning: the function =E2=80=98org-get-outline-path=E2= =80=99 is not known to be defined. I see that defun has now moved to org-refile.el. I see that org-get-outline-path has nothing to do specific to refiling. Can that be moved back to org.el, or may be a separate library? Otherwise, ox-hugo.el will have to load org-refile.el too (yes, I don't use org-refile (yet), and that's how I discovered this :)) Failure 2: Change in parsing of org babel header arguments. This was caught by my weekly Travis CI cron jobs for ox-hugo: https://travis-ci.org/kaushalmodi/ox-hugo/jobs/655410731#L2426 26c26 < {{< highlight emacs-lisp "hl_lines=3D1" >}} --- > {{< highlight emacs-lisp "hl_lines=3D1 3-5" >}} Earlier this kind of src block header: #+begin_src emacs-lisp :hl_lines 1,3-5 ... #+end_src got exported as {{< highlight emacs-lisp "hl_lines=3D1 3-5" >}} The regression is that now it is getting exported as {{< highlight emacs-lisp "hl_lines=3D1" >}} The values that I have after the comma in ":hl_lines 1,3-5" are getting lost. The relevant snippet where I parse the header arguments in ox-hugo.el is at https://github.com/kaushalmodi/ox-hugo/blob/f8ec4aa5ad7d92f94bd8dbb814d85f9= 80be67aea/ox-hugo.el#L2563 This behavior change in org-babel-parse-header-arguments is also not documented in ORG-NEWS. I will now investigate what cause this regression. ... -- Kaushal Modi [1]: https://github.com/kaushalmodi/ox-hugo --0000000000009d8aad059f8f26ab Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hello,

I recently updated to= the latest org-mode master and it is failing ox-hugo[1] build and tests at= 2 places.

Failure 1: org-get-outline-path ha= s moved, and not mentioned in ORG-NEWS

Compiling o= x-hugo.el now gives:

ox-hugo.el:4284:1: Warning: t= he function =E2=80=98org-get-outline-path=E2=80=99 is not known to be defin= ed.

I see that defun has now moved to org-refi= le.el. I see that org-get-outline-path has nothing to do specific to refili= ng. Can that be moved back to org.el, or may be a separate library? Otherwi= se, ox-hugo.el will have to load org-refile.el too (yes, I don't use or= g-refile (yet), and that's how I discovered this :))

Failure 2: Change in parsing of org babel header arguments.

This was caught by my weekly Travis CI cron jobs for ox-hu= go: https://travis-ci.org/kaushalmodi/ox-hugo/jobs/655410731#L2426
26c26
< {{< highlight emacs-lisp "hl_lines=3D1" >= ;}}
---
> {{< highlight emacs-lisp "hl_lines=3D1 3-5"= >}}

Earlier this kind of src block header:

#+begin_src em= acs-lisp :hl_lines 1,3-5
...
#+end_src

got exported as=C2=A0

{{< highlight emacs-lisp "hl_lines=3D1 3-5" >}}
<= div>
The regression is that now it is getting exported as

{{< highlight emacs-lisp "hl_lines=3D1" >}}

The values that I have after the comma in ":= hl_lines 1,3-5" are getting lost.

The relevan= t snippet where I parse the header arguments in ox-hugo.el is at https://github.com/kaushalmodi/ox-hugo/blob/f8= ec4aa5ad7d92f94bd8dbb814d85f980be67aea/ox-hugo.el#L2563

<= /div>
This behavior change in org-babel-parse-header-arguments is also = not documented in ORG-NEWS. I will now investigate what cause this regressi= on.

...

--
Kaushal Modi

--0000000000009d8aad059f8f26ab--