From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dushyant Juneja Subject: Bug with (comment-line) Date: Wed, 26 Oct 2016 05:27:17 +0000 Message-ID: Mime-Version: 1.0 Content-Type: multipart/alternative; boundary=001a114e5dd08664c2053fbde1dd Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:51726) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bzGkN-0008BP-Og for emacs-orgmode@gnu.org; Wed, 26 Oct 2016 01:27:32 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bzGkM-0006sF-MC for emacs-orgmode@gnu.org; Wed, 26 Oct 2016 01:27:31 -0400 Received: from mail-vk0-x22c.google.com ([2607:f8b0:400c:c05::22c]:39156) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1bzGkM-0006rx-F9 for emacs-orgmode@gnu.org; Wed, 26 Oct 2016 01:27:30 -0400 Received: by mail-vk0-x22c.google.com with SMTP id w72so154231vke.6 for ; Tue, 25 Oct 2016 22:27:29 -0700 (PDT) List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: "Emacs-orgmode" To: "emacs-orgmode@gnu.org" --001a114e5dd08664c2053fbde1dd Content-Type: text/plain; charset=UTF-8 Hi, (comment-line) function (bound to C-x C-; by default) seems to have a bug. Normally, with pointer on a line, if I do C-x C-; - it comments the current line. In org-mode, it adds comment at the end of the line. For instance, I have the following verilog file (sth.sv) (line numbers for clarity only): 1: program sth; 2: input sth_else; 3: endprogram If I press C-x C-; on line 2, it becomes: program sth; // input sth_else; endprogram However, if I have the following in org mode: 1: #+BEGIN_SRC verilog :tangle cache.sv 2: program sth; 3: input sth_else; 4: endprogram 5: #+END_SRC Pressing C-x C-; with pointer on line 3 transforms it to: 1: #+BEGIN_SRC verilog :tangle sth.sv 2: program sth; 3: input sth_else; // 4: endprogram 5: #+END_SRC bug or a feature? If latter, how do I comment current line in org-babel? Dushyant --001a114e5dd08664c2053fbde1dd Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
Hi,

(comment-line) function (bound to C= -x C-; by default) seems to have a bug. Normally, with pointer on a line, i= f I do C-x C-; - it comments the current line. In org-mode, it adds comment= at the end of the line.

For instance, I have the = following verilog file (sth.sv) (line numbers= for clarity only):

1: program sth;
2: =C2=A0 =C2=A0input sth_else;
3: endprogram
If I press C-x C-; on line 2, it becomes:

=
program sth;
=C2=A0 =C2=A0// input sth_else;
=
endprogram

However, if I have the following = in org mode:

1: #+BEGIN_SRC verilog :tangle <= a href=3D"http://cache.sv">cache.sv
2: program sth;
3: =C2=A0 =C2=A0input sth_else;
4: endprogram
5: #+END= _SRC

Pressing C-x C-; with pointer on line 3= transforms it to:

1: #+BEGIN_SRC verilo= g :tangle sth.sv
2: program sth;
3: =C2=A0 =C2=A0input sth_else; =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0//
4: endprogram
5: #+END_SRC
<= br class=3D"inbox-inbox-Apple-interchange-newline">
bug or a feat= ure? If latter, how do I comment current line in org-babel?

<= /div>
Dushyant
--001a114e5dd08664c2053fbde1dd-- From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kaushal Modi Subject: Re: Bug with (comment-line) Date: Wed, 26 Oct 2016 10:42:16 +0000 Message-ID: References: Mime-Version: 1.0 Content-Type: multipart/alternative; boundary=001a11431d700135fa053fc2480f Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:51056) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bzLfC-00056T-0X for emacs-orgmode@gnu.org; Wed, 26 Oct 2016 06:42:30 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bzLfB-0000LS-3q for emacs-orgmode@gnu.org; Wed, 26 Oct 2016 06:42:30 -0400 Received: from mail-vk0-x22c.google.com ([2607:f8b0:400c:c05::22c]:35449) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1bzLfA-0000Kx-V9 for emacs-orgmode@gnu.org; Wed, 26 Oct 2016 06:42:29 -0400 Received: by mail-vk0-x22c.google.com with SMTP id q126so2639357vkd.2 for ; Wed, 26 Oct 2016 03:42:28 -0700 (PDT) In-Reply-To: List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: "Emacs-orgmode" To: Dushyant Juneja , emacs-org list --001a11431d700135fa053fc2480f Content-Type: text/plain; charset=UTF-8 On Wed, Oct 26, 2016, 1:28 AM Dushyant Juneja wrote: > > bug or a feature? If latter, how do I comment current line in org-babel? > It looks like this bug which was recently fixed in the master (dev) branch: http://orgmode.org/cgit.cgi/org-mode.git/commit/?id=21c6148bbe60c278abfb0f035c15c030ac0582c6 If this commit is not merged into the maint branch, you would need to git clone the master branch and build org locally to get it. The version available via package.el is the latest build of only the maint branch. -- Kaushal Modi --001a11431d700135fa053fc2480f Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
On Wed, Oct 26, 2016, 1:28 AM D= ushyant Juneja <juneja.dush= yant@gmail.com> wrote:

bug or a feature? If latter, how do I comment current = line in org-babel?

It loo= ks like this bug which was recently fixed in the master (dev) branch:=C2=A0= http://orgmode.org/cgit.cgi/org-mode.git/co= mmit/?id=3D21c6148bbe60c278abfb0f035c15c030ac0582c6

If this commit is not merged into the maint branch, you would need to= git clone the master branch and build org locally to get it. The version a= vailable via package.el is the latest build of only the maint branch.=C2=A0=
--

Kaushal M= odi

--001a11431d700135fa053fc2480f-- From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dushyant Juneja Subject: Re: Bug with (comment-line) Date: Wed, 26 Oct 2016 11:21:31 +0000 Message-ID: References: Mime-Version: 1.0 Content-Type: multipart/alternative; boundary=001a1142f5f85a24a2053fc2d4bf Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:59913) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bzMHH-0008OZ-I3 for emacs-orgmode@gnu.org; Wed, 26 Oct 2016 07:21:58 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bzMHC-0000RG-FK for emacs-orgmode@gnu.org; Wed, 26 Oct 2016 07:21:51 -0400 Received: from mail-vk0-x22a.google.com ([2607:f8b0:400c:c05::22a]:39868) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1bzMHC-0000Qe-9v for emacs-orgmode@gnu.org; Wed, 26 Oct 2016 07:21:46 -0400 Received: by mail-vk0-x22a.google.com with SMTP id w72so2922342vke.6 for ; Wed, 26 Oct 2016 04:21:46 -0700 (PDT) In-Reply-To: List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: "Emacs-orgmode" To: Kaushal Modi , emacs-org list --001a1142f5f85a24a2053fc2d4bf Content-Type: text/plain; charset=UTF-8 On Wed, Oct 26, 2016 at 4:12 PM Kaushal Modi wrote: On Wed, Oct 26, 2016, 1:28 AM Dushyant Juneja wrote: bug or a feature? If latter, how do I comment current line in org-babel? It looks like this bug which was recently fixed in the master (dev) branch: http://orgmode.org/cgit.cgi/org-mode.git/commit/?id=21c6148bbe60c278abfb0f035c15c030ac0582c6 If this commit is not merged into the maint branch, you would need to git clone the master branch and build org locally to get it. The version available via package.el is the latest build of only the maint branch. My Org-mode version is 8.3.6 (8.3.6-7-g4d7d52-elpaplus @ /.../.emacs.d/elpa/org-plus-contrib-20161024/) Looking at the commit date, it is 2016-10-15 10:31:25 (GMT) Any way I can test it whether I have this commit or not? Dushyant -- Kaushal Modi --001a1142f5f85a24a2053fc2d4bf Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable

On Wed, Oct 26, 2016 at 4= :12 PM Kaushal Modi <kaushal.modi@gmail.com> wrote:
On Wed, Oct 26= , 2016, 1:28 AM Dushyant Juneja <juneja.dushyant@gmail.com&g= t; wrote:

bug= or a feature? If latter, how do I comment current line in org-babel?
=

<= /div>
It looks like this bug which was recently fix= ed in the master (dev) branch:=C2=A0http://orgmode.org/cgit.cgi/org-mode.git/c= ommit/?id=3D21c6148bbe60c278abfb0f035c15c030ac0582c6

If this = commit is not merged into the maint branch, you would need to git clone the= master branch and build org locally to get it. The version available via p= ackage.el is the latest build of only the maint branch.=C2=A0

My Org-mode version is 8.3.6 (8.3.6-7-g4d7d52-elpaplus = @ /.../.emacs.d/elpa/org-plus-contrib-20161024/)
Looking at the commit = date, it is=C2=A02016-10-15 10:31:25 (GMT)=C2=A0

Any way I can test it whether I= have this commit or not?

Dush= yant
=C2=A0
--=

Kaushal Modi

--001a1142f5f85a24a2053fc2d4bf-- From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kaushal Modi Subject: Re: Bug with (comment-line) Date: Wed, 26 Oct 2016 12:45:16 +0000 Message-ID: References: Mime-Version: 1.0 Content-Type: multipart/alternative; boundary=001a114398b8e10130053fc3ff70 Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:58821) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bzNaD-0007tu-LW for emacs-orgmode@gnu.org; Wed, 26 Oct 2016 08:45:33 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bzNaC-0004zq-GM for emacs-orgmode@gnu.org; Wed, 26 Oct 2016 08:45:29 -0400 Received: from mail-vk0-x22b.google.com ([2607:f8b0:400c:c05::22b]:34761) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1bzNaC-0004zO-As for emacs-orgmode@gnu.org; Wed, 26 Oct 2016 08:45:28 -0400 Received: by mail-vk0-x22b.google.com with SMTP id p81so3822745vkd.1 for ; Wed, 26 Oct 2016 05:45:28 -0700 (PDT) In-Reply-To: List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: "Emacs-orgmode" To: Dushyant Juneja , emacs-org list --001a114398b8e10130053fc3ff70 Content-Type: text/plain; charset=UTF-8 On Wed, Oct 26, 2016 at 7:21 AM Dushyant Juneja wrote: > My Org-mode version is 8.3.6 (8.3.6-7-g4d7d52-elpaplus @ > /.../.emacs.d/elpa/org-plus-contrib-20161024/) > > Looking at the commit date, it is 2016-10-15 10:31:25 (GMT) > We cannot rely on the commit and build dates for this: The packaged org-mode is built using the maint branch: http://orgmode.org/cgit.cgi/org-mode.git/log/?h=maint This is the master/dev branch: http://orgmode.org/cgit.cgi/org-mode.git/log/ So even though your org-mode version build date is 20161024, it only contains the commits from the maint branch. > > Any way I can test it whether I have this commit or not? > Looks like this commit is only in the master branch. I do not know if this commit will be backported to the maint branch. Until then, here are few options to get the fix: 1. Clone and build org mode locally using the master branch. 2. Manually copy the fixed org-comment-or-uncomment-region from the master branch here[1], put it in your emacs config in a (with-eval-after-load 'org ..) form and fix it as and if needed to make it work with the maint branch version. [1]: http://orgmode.org/cgit.cgi/org-mode.git/tree/lisp/org.el?id=0204b0e16f834ca54ade988257725f31eaaedbce#n23555 -- Kaushal Modi --001a114398b8e10130053fc3ff70 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable

On Wed, Oc= t 26, 2016 at 7:21 AM Dushyant Juneja <juneja.dushyant@gmail.com> wrote:
My Org-mode version i= s 8.3.6 (8.3.6-7-g4d7d52-elpaplus @ /.../.emacs.d/elpa/org-plus-contrib-201= 61024/)

Looking at the commit date, it is=C2=A02016-10-15 10:31:25 (GMT)=C2=A0

We cannot rely on the commit and build dates f= or this:

The packaged org-mode is built using the = maint branch:=C2=A0http://orgmode.org/cgit.cgi/org-mode.git/log/?h=3Dmaint

This is the master/dev branch:=C2=A0http://orgmode.org/cgit.cgi/org-mo= de.git/log/

So even though your org-mode versi= on build date is 20161024, it only contains the commits from the maint bran= ch.
=C2=A0

Any way I can = test it whether I have this commit or not?

Looks like this commit is only in the master branch.

I do not know if this commit will be backported to the= maint branch.

Until then, here are few options to= get the fix:

1. Clone and build org mode locally = using the master branch.=C2=A0
2. Manually copy the fixed org-com= ment-or-uncomment-region from the master branch here[1], put it in your ema= cs config in a (with-eval-after-load 'org ..) form and fix it as and if= needed to make it work with the maint branch version.

=

--
<= /div>

Kaushal Modi

--001a114398b8e10130053fc3ff70--