From: Kaushal Modi <kaushal.modi@gmail.com>
To: Nicolas Goaziou <mail@nicolasgoaziou.fr>
Cc: emacs-orgmode@gnu.org
Subject: Re: Add an optional HOLD argument to "n" Org macro
Date: Sun, 18 Jun 2017 04:03:05 +0000 [thread overview]
Message-ID: <CAFyQvY0oa5xFqa2u8o5VB3QUCqDHhLdAaVHdCuD-kXNw1KgxXQ@mail.gmail.com> (raw)
In-Reply-To: <87zid6dwop.fsf@nicolasgoaziou.fr>
[-- Attachment #1: Type: text/plain, Size: 1008 bytes --]
On Sat, Jun 17, 2017 at 7:25 PM Nicolas Goaziou <mail@nicolasgoaziou.fr>
wrote:
> Hello,
>
> Thank you. LGTM. I only have nitpicks.
>
Thanks!
> > + (let ((action-trimmed (when (org-string-nw-p action)
> > + (org-trim action)))
>
> (and (org-string-nw-p action) ...)
>
Ah! I forgot making this change and the patch is already pushed.
> However, NAME is always a string, so it could simply be
>
> (name-trimmed (org-trim-name))
>
Correct. I made this change.
> and since you use it only once, I would simply do the suggestion below...
>
> > + (puthash name-trimmed
>
> ... which is
>
> (puthash (org-trim name))
>
name-trimmed is then used in gethash forms too. So I retained the
name-trimmed var.
> You can push it whenever you think it is good enough.
>
Thanks. I pushed the patch, but I missed making the when -> and change. Do
you want me to fix that in another commit? Though, functionally they are
the same, and 'make test' is passing.
--
Kaushal Modi
[-- Attachment #2: Type: text/html, Size: 2039 bytes --]
next prev parent reply other threads:[~2017-06-18 4:03 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <2ee94a64a94b46259b0da6e7d34675c9@HE1PR01MB1898.eurprd01.prod.exchangelabs.com>
2017-05-08 14:00 ` [RFC] The "c" Org macro Eric S Fraga
2017-05-08 15:32 ` Dushyant Juneja
[not found] ` <a4c6d561b12a4cc8ad4fe8c017fa2121@HE1PR01MB1898.eurprd01.prod.exchangelabs.com>
2017-05-08 15:59 ` Eric S Fraga
2017-05-08 16:52 ` Nicolas Goaziou
2017-05-09 7:35 ` Carsten Dominik
2017-05-09 10:35 ` Nicolas Goaziou
2017-05-09 11:25 ` Rasmus
2017-05-09 16:10 ` Nicolas Goaziou
[not found] ` <2069df8c23bc43f3b04b6e203b96be9d@HE1PR01MB1898.eurprd01.prod.exchangelabs.com>
2017-05-11 8:45 ` Eric S Fraga
2017-05-21 13:37 ` Nicolas Goaziou
2017-05-22 3:24 ` Kaushal Modi
2017-05-22 5:58 ` Nicolas Goaziou
2017-05-22 10:46 ` Kaushal Modi
2017-05-22 11:47 ` Nicolas Goaziou
2017-05-22 13:00 ` Kaushal Modi
2017-05-22 13:10 ` Kaushal Modi
2017-05-22 13:13 ` Nicolas Goaziou
2017-05-22 13:39 ` Kaushal Modi
2017-05-25 10:42 ` Nicolas Goaziou
2017-05-25 18:31 ` Kaushal Modi
2017-06-14 17:52 ` Kaushal Modi
2017-06-14 18:33 ` Add an optional HOLD argument to "n" Org macro (Was: [RFC] The "c" Org macro) Kaushal Modi
2017-06-14 19:47 ` Add an optional HOLD argument to "n" Org macro Nicolas Goaziou
2017-06-15 13:10 ` Kaushal Modi
2017-06-15 15:25 ` Kaushal Modi
2017-06-15 16:07 ` Nicolas Goaziou
2017-06-15 18:07 ` Kaushal Modi
2017-06-17 14:34 ` Kaushal Modi
2017-06-17 23:24 ` Nicolas Goaziou
2017-06-18 4:03 ` Kaushal Modi [this message]
2017-06-18 7:16 ` Nicolas Goaziou
2017-06-18 7:45 ` Kaushal Modi
2017-06-14 19:44 ` [RFC] The "c" " Nicolas Goaziou
[not found] ` <a8f5841641834b4cb51af85a3df785da@HE1PR01MB1898.eurprd01.prod.exchangelabs.com>
2017-05-22 8:34 ` Eric S Fraga
2017-05-08 16:30 ` Robert Horn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFyQvY0oa5xFqa2u8o5VB3QUCqDHhLdAaVHdCuD-kXNw1KgxXQ@mail.gmail.com \
--to=kaushal.modi@gmail.com \
--cc=emacs-orgmode@gnu.org \
--cc=mail@nicolasgoaziou.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).