From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kaushal Modi Subject: Re: function for inserting a block Date: Sun, 05 Nov 2017 14:24:40 +0000 Message-ID: References: <877exghblx.fsf@ericabrahamsen.net> <87lgk9eo4d.fsf@ericabrahamsen.net> <87fuahxxvs.fsf@nicolasgoaziou.fr> <87r2u1cuwj.fsf@ericabrahamsen.net> <87infdctzq.fsf@ericabrahamsen.net> <87k1zsbizs.fsf@ericabrahamsen.net> <87k1zp4rxj.fsf@ericabrahamsen.net> <871slx4j6p.fsf@ericabrahamsen.net> <87r2ttoq5k.fsf@ericabrahamsen.net> <871sltst0t.fsf@nicolasgoaziou.fr> <87y3o14cul.fsf@ericabrahamsen.net> <87po9czqy8.fsf@nicolasgoaziou.fr> <87she2rjqr.fsf@ericabrahamsen.net> <87r2tmwcrv.fsf@nicolasgoaziou.fr> <877evcvc57.fsf@ericabrahamsen.net> <87she0ikmo.fsf@ericabrahamsen.net> <87efpd9jsj.fsf@nicolasgoaziou.fr> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="f403045e727cdada42055d3d19d0" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:39874) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eBLr5-0003ik-5k for emacs-orgmode@gnu.org; Sun, 05 Nov 2017 09:24:56 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eBLr3-0003At-RV for emacs-orgmode@gnu.org; Sun, 05 Nov 2017 09:24:55 -0500 Received: from mail-yw0-x22b.google.com ([2607:f8b0:4002:c05::22b]:46050) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eBLr3-00039u-L2 for emacs-orgmode@gnu.org; Sun, 05 Nov 2017 09:24:53 -0500 Received: by mail-yw0-x22b.google.com with SMTP id j4so5925660ywb.2 for ; Sun, 05 Nov 2017 06:24:52 -0800 (PST) In-Reply-To: <87efpd9jsj.fsf@nicolasgoaziou.fr> List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: "Emacs-orgmode" To: Nicolas Goaziou Cc: Eric Abrahamsen , emacs-orgmode@gnu.org --f403045e727cdada42055d3d19d0 Content-Type: text/plain; charset="UTF-8" On Sun, Nov 5, 2017 at 4:07 AM Nicolas Goaziou wrote: > Hello, > > Eric Abrahamsen writes: > > > From 055af9e9545947b9aeccc3370c8b67a237eea5d8 Mon Sep 17 00:00:00 2001 > > From: Eric Abrahamsen > > Date: Mon, 30 Oct 2017 10:55:29 -0700 > > Subject: [PATCH] Replace easy templates with > org-insert-structure-template > > > > * lisp/org.el (org-insert-structure-template): New function for > > wrapping region (or element at point) in a begin/end block. > > (org-structure-predefined-blocks): New option holding predefined > > blocks, for completion. > > (org-try-structure-completion, > > org-complete-expand-structure-template): Remove functions. > > * doc/org.texi (Inserting structure templates): Document. > > * testing/lisp/test-org.el (test-org/insert-template): New test. > > Thank you. I applied your patch with the changes below. > I'll try this out soon. This is a breaking change though (org-try-structure-completion doesn't exist any more.. it breaks at least my config.. could be breaking more). Can you please also mention this breakage in the ORG-NEWS? -- Kaushal Modi --f403045e727cdada42055d3d19d0 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
On Sun, Nov 5,= 2017 at 4:07 AM Nicolas Goaziou <mail@nicolasgoaziou.fr> wrote:
Hello,

Eric Abrahamsen <eric@ericabrahamsen.net> writes:

> From 055af9e9545947b9aeccc3370c8b67a237eea5d8 Mon Sep 17 00:00:00 2001=
> From: Eric Abrahamsen <eric@ericabrahamsen.net>
> Date: Mon, 30 Oct 2017 10:55:29 -0700
> Subject: [PATCH] Replace easy templates with org-insert-structure-temp= late
>
> * lisp/org.el (org-insert-structure-template): New function for
>=C2=A0 =C2=A0wrapping region (or element at point) in a begin/end block= .
>=C2=A0 =C2=A0(org-structure-predefined-blocks): New option holding pred= efined
>=C2=A0 =C2=A0blocks, for completion.
>=C2=A0 =C2=A0(org-try-structure-completion,
>=C2=A0 =C2=A0org-complete-expand-structure-template): Remove functions.=
> * doc/org.texi (Inserting structure templates): Document.
> * testing/lisp/test-org.el (test-org/insert-template): New test.

Thank you. I applied your patch with the changes below.

I'll try this out soon. This is a breaking change thou= gh (org-try-structure-completion doesn't exist any more.. it breaks at = least my config.. could be breaking more). Can you please also mention this= breakage in the ORG-NEWS?=C2=A0
--
<= /div>

Kaushal Modi

--f403045e727cdada42055d3d19d0--