emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed

From: Kaushal Modi <kaushal.modi@gmail.com>
To: emacs-org list <emacs-orgmode@gnu.org>
Subject: Question about updating a package for the org-get-tags change
Date: Mon, 23 Apr 2018 16:02:34 +0000	[thread overview]
Message-ID: <CAFyQvY0dnZ+rBhZeKjrkfWq+NeRdAkz-jKuo_rs3Xr4E=HTpeA@mail.gmail.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 1083 bytes --]

Hello,

I am trying to update the ox-hugo package to work with zero warnings for
both Org 9.1 and 9.2.

I tried adding this function:

(defsubst org-hugo--get-tags ()
  "Wrapper function to pick the correct fn for getting inherited Org tags."
  ;; Starting Org 9.2, `org-get-tags' returns all the inherited tags
  ;; instead of returning only the local tags i.e. only the current
  ;; headline tags.
  ;;
https://code.orgmode.org/bzg/org-mode/commit/fbe56f89f75a8979e0ba48001a822518df2c66fe
  ;; For Org <= 9.1, `org-get-tags' returned a list of tags *only* at
  ;; the current heading, while `org-get-tags-at' returned inherited
  ;; tags too.
  (if (fboundp #'org--get-local-tags)   ;If using Org 9.2+
      (org-get-tags)
    (org-get-tags-at)))

But ox-hugo still compiles with this warning with Org 9.2:

In org-hugo--get-tags:
ox-hugo.el:1371:6:Warning: ‘org-get-tags-at’ is an obsolete function (as of
    Org 9.2); use ‘org-get-tags’ instead.

What's the canonical way to deal with such cases?

Thanks.

Kaushal

-- 

Kaushal Modi

[-- Attachment #2: Type: text/html, Size: 1526 bytes --]

next             reply	other threads:[~2018-04-23 16:02 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-23 16:02 Kaushal Modi [this message]
2018-04-23 17:08 ` Question about updating a package for the org-get-tags change Kaushal Modi
2018-04-23 18:11 ` Nicolas Goaziou
2018-04-23 19:09   ` Kaushal Modi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAFyQvY0dnZ+rBhZeKjrkfWq+NeRdAkz-jKuo_rs3Xr4E=HTpeA@mail.gmail.com' \
    --to=kaushal.modi@gmail.com \
    --cc=emacs-orgmode@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).