From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kaushal Modi Subject: Re: bug#18617: 24.3; loading simple-wiki-mode breaks org-mode Date: Sun, 21 Feb 2016 09:26:58 -0500 Message-ID: References: <877g0iqcg4.fsf@gmail.com> <87bn7a9syd.fsf@amu.edu.pl> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary=001a113deec6a73b0b052c4884fd Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:46939) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aXUz7-0001Zb-Qh for emacs-orgmode@gnu.org; Sun, 21 Feb 2016 09:27:42 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aXUz6-0007kv-Pu for emacs-orgmode@gnu.org; Sun, 21 Feb 2016 09:27:41 -0500 In-Reply-To: List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Marcin Borkowski Cc: vmon@riseup.net, emacs-org list , alex@gnu.org, 18617@debbugs.gnu.org, david.hansen@physik.fu-berlin.de --001a113deec6a73b0b052c4884fd Content-Type: text/plain; charset=UTF-8 A quick look at the code shows that it pollutes the namespace with undeclared and un-let-bound variables like "tag" (and there could be more like that). If we investigate further, we might find a culprit like that that's causing this problem. (defun simple-wiki-get-tag () (let (prompt) (if (and simple-wiki-tag-history (car simple-wiki-tag-history)) (setq prompt (concat "Tag (" (car simple-wiki-tag-history) "): ")) (setq prompt "Tag: ")) (setq tag (completing-read prompt simple-wiki-tag-list nil nil "" 'simple-wiki-tag-history (car simple-wiki-tag-history)))) (unless (assoc tag simple-wiki-tag-list) (add-to-list 'simple-wiki-tag-list (cons tag nil))) tag) --001a113deec6a73b0b052c4884fd Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
A quick look at the code shows = that it pollutes the namespace with undeclared and un-let-bound variables l= ike "tag" (and there could be more like that).

If we investigate furthe= r, we might find a culprit like that that's causing this problem.
=

(defun simple-wiki-get-tag ()
=C2=A0 (let (prompt)
=C2=A0 =C2=A0 (if = (and simple-wiki-tag-history (car simple-wiki-tag-history))
=C2=A0 =C2=A0 =C2=A0 =C2=A0 (setq prompt (concat "Tag= (" (car simple-wiki-tag-history) "): "))
=C2=A0 =C2=A0 =C2=A0 (setq prompt "Tag: "))
=C2=A0 =C2=A0 (setq tag (completing-read prompt si= mple-wiki-tag-list nil nil ""
=C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0'simple-wiki-tag-history
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(car simple-wiki-ta= g-history))))
=C2=A0 (unless (assoc tag sim= ple-wiki-tag-list)
=C2=A0 =C2=A0 (add-to-li= st 'simple-wiki-tag-list (cons tag nil)))
=C2=A0 tag)

--001a113deec6a73b0b052c4884fd--