From mboxrd@z Thu Jan 1 00:00:00 1970 From: Greg Tucker-Kellogg Subject: Re: PATCH -- ox-latex.el . sideways figure in latex export Date: Sun, 6 Apr 2014 12:10:54 +0800 Message-ID: References: <5CE478C5-C4A2-4BA7-B197-4807EAFE4B18@gmail.com> <8738hr7g52.fsf@gmail.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary=001a11c3f020f1c5b904f657efe8 Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:50006) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WWeQ6-0003d4-3d for emacs-orgmode@gnu.org; Sun, 06 Apr 2014 00:10:59 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WWeQ4-00018Q-Is for emacs-orgmode@gnu.org; Sun, 06 Apr 2014 00:10:58 -0400 Received: from mail-lb0-x22a.google.com ([2a00:1450:4010:c04::22a]:39108) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WWeQ4-00018I-4Y for emacs-orgmode@gnu.org; Sun, 06 Apr 2014 00:10:56 -0400 Received: by mail-lb0-f170.google.com with SMTP id s7so3668705lbd.15 for ; Sat, 05 Apr 2014 21:10:55 -0700 (PDT) In-Reply-To: <8738hr7g52.fsf@gmail.com> List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Nicolas Goaziou Cc: org-mode mailing list --001a11c3f020f1c5b904f657efe8 Content-Type: multipart/alternative; boundary=001a11c3f020f1c5b504f657efe6 --001a11c3f020f1c5b504f657efe6 Content-Type: text/plain; charset=ISO-8859-1 I think this covers it. ":float sideways" now works for both tables and figures, but ":float sidewaystable" is kept for backwards compatibility. I updated org.texi, and mentioned that the use of ":float sideways" will make the ":placement" option irrelevant. Attached are the two patches; the one from yesterday and the one that updates as described above. Cheers, Greg On Sun, Apr 6, 2014 at 3:03 AM, Nicolas Goaziou wrote: > Hello, > > Greg Tucker-Kellogg writes: > > > This is a tiny patch to support a ":float sidewaysfigure" option in > > LaTeX backend export > > Thank you for the patch. > > It makes sense since tables provide "sidewaystable". By the way, > wouldn't it make sense to use "sideways" for both, instead of > "sidewaystable" and "sidewaysfigure"? > > Also, it needs to be documented in org.texi. Do you want to take care of > that part? > > > Regards, > > -- > Nicolas Goaziou > --001a11c3f020f1c5b504f657efe6 Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable
I think this covers it.  ":float sideways" = now works for both tables and figures, but ":float sidewaystable"= is kept for backwards compatibility.  I updated org.texi, and mention= ed that the use of ":float sideways" will make the ":placeme= nt" option irrelevant.

Attached are the two patches; the one from yesterday and the one that = updates as described above.

Cheers,

=
Greg



On Sun, Apr 6, 2014 at 3:03 AM, Nicolas Goaz= iou <n.goaziou@gmail.com> wrote:
Hello,

Greg Tucker-Kellogg <gtucker= kellogg@gmail.com> writes:

> This is a tiny patch to support a “:float sidewaysfigure” = option in
> LaTeX backend export

Thank you for the patch.

It makes sense since tables provide "sidewaystable". By the way,<= br> wouldn't it make sense to use "sideways" for both, instead of=
"sidewaystable" and "sidewaysfigure"?

Also, it needs to be documented in org.texi. Do you want to take care of that part?


Regards,

--
Nicolas Goaziou

--001a11c3f020f1c5b504f657efe6-- --001a11c3f020f1c5b904f657efe8 Content-Type: application/octet-stream; name="0001-ox-latex-sidewaysfigure-export-for-LaTeX-backend.patch" Content-Disposition: attachment; filename="0001-ox-latex-sidewaysfigure-export-for-LaTeX-backend.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_htnt7g730 RnJvbSBmZjExOWVhYWNlNzZkMDA2ZmFlMDM2NDY1OTYwYjdlNjljMDRhMDU5IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBHcmVnIFR1Y2tlci1LZWxsb2dnIDxndHVja2Vya2VsbG9nZ0Bn bWFpbC5jb20+CkRhdGU6IFNhdCwgNSBBcHIgMjAxNCAxNDowMzoyOSArMDgwMApTdWJqZWN0OiBb UEFUQ0ggMS8yXSBveC1sYXRleDogc2lkZXdheXNmaWd1cmUgZXhwb3J0IGZvciBMYVRlWCBiYWNr ZW5kCgpUaGlzIGFkZHMgYSA6ZmxvYXQgc2lkZXdheXNmaWd1cmUgb3B0aW9uIGFuYWxvZ291cyB0 byBzaWR3YXlzdGFibGUgZmxvYXRzCi0tLQogbGlzcC9veC1sYXRleC5lbCB8IDUgKysrKysKIDEg ZmlsZSBjaGFuZ2VkLCA1IGluc2VydGlvbnMoKykKCmRpZmYgLS1naXQgYS9saXNwL294LWxhdGV4 LmVsIGIvbGlzcC9veC1sYXRleC5lbAppbmRleCBkNjVjOTc1Li5jMDVmZmI2IDEwMDY0NAotLS0g YS9saXNwL294LWxhdGV4LmVsCisrKyBiL2xpc3Avb3gtbGF0ZXguZWwKQEAgLTE4MDEsNiArMTgw MSw3IEBAIHVzZWQgYXMgYSBjb21tdW5pY2F0aW9uIGNoYW5uZWwuIgogCSAoZmxvYXQgKGxldCAo KGZsb2F0IChwbGlzdC1nZXQgYXR0ciA6ZmxvYXQpKSkKIAkJICAoY29uZCAoKGFuZCAobm90IGZs b2F0KSAocGxpc3QtbWVtYmVyIGF0dHIgOmZsb2F0KSkgbmlsKQogCQkJKChzdHJpbmc9IGZsb2F0 ICJ3cmFwIikgJ3dyYXApCisJCQkoKHN0cmluZz0gZmxvYXQgInNpZGV3YXlzZmlndXJlIikgJ3Np ZGV3YXlzZmlndXJlKQogCQkJKChzdHJpbmc9IGZsb2F0ICJtdWx0aWNvbHVtbiIpICdtdWx0aWNv bHVtbikKIAkJCSgob3IgZmxvYXQKIAkJCSAgICAgKG9yZy1lbGVtZW50LXByb3BlcnR5IDpjYXB0 aW9uIHBhcmVudCkKQEAgLTE4NzYsNiArMTg3NywxMCBAQCB1c2VkIGFzIGEgY29tbXVuaWNhdGlv biBjaGFubmVsLiIKIFxcY2VudGVyaW5nCiAlcyVzCiAlc1xcZW5ke3dyYXBmaWd1cmV9IiBwbGFj ZW1lbnQgY29tbWVudC1pbmNsdWRlIGltYWdlLWNvZGUgY2FwdGlvbikpCisgICAgICAoc2lkZXdh eXNmaWd1cmUgKGZvcm1hdCAiXFxiZWdpbntzaWRld2F5c2ZpZ3VyZX0lcworXFxjZW50ZXJpbmcK KyVzJXMKKyVzXFxlbmR7c2lkZXdheXNmaWd1cmV9IiBwbGFjZW1lbnQgY29tbWVudC1pbmNsdWRl IGltYWdlLWNvZGUgY2FwdGlvbikpCiAgICAgICAobXVsdGljb2x1bW4gKGZvcm1hdCAiXFxiZWdp bntmaWd1cmUqfSVzCiBcXGNlbnRlcmluZwogJXMlcwotLSAKMS44LjQuMwoK --001a11c3f020f1c5b904f657efe8 Content-Type: application/octet-stream; name="0002-Documented-and-standardised-sideways-options-for-tab.patch" Content-Disposition: attachment; filename="0002-Documented-and-standardised-sideways-options-for-tab.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_htnt7g7w1 RnJvbSA0NWU4ODFmOTI1NDk4ZTRkYTcxZjM5NWMyY2YxN2E3ZDI0NWZmZThlIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBHcmVnIFR1Y2tlci1LZWxsb2dnIDxndHVja2Vya2VsbG9nZ0Bn bWFpbC5jb20+CkRhdGU6IFN1biwgNiBBcHIgMjAxNCAxMjowMDoxNiArMDgwMApTdWJqZWN0OiBb UEFUQ0ggMi8yXSBEb2N1bWVudGVkIGFuZCBzdGFuZGFyZGlzZWQgInNpZGV3YXlzIiBvcHRpb25z IGZvciB0YWJsZXMKIGFuZCBmaWd1cmVzIGZvciBMYVRlWCBleHBvcnRlci4KCi0tLQogZG9jL29y Zy50ZXhpICAgICB8IDE0ICsrKysrKysrKystLS0tCiBsaXNwL294LWxhdGV4LmVsIHwgIDkgKysr KystLS0tCiAyIGZpbGVzIGNoYW5nZWQsIDE1IGluc2VydGlvbnMoKyksIDggZGVsZXRpb25zKC0p CgpkaWZmIC0tZ2l0IGEvZG9jL29yZy50ZXhpIGIvZG9jL29yZy50ZXhpCmluZGV4IDkyMDVhYmIu LjE4MTc4ZDMgMTAwNjQ0Ci0tLSBhL2RvYy9vcmcudGV4aQorKysgYi9kb2Mvb3JnLnRleGkKQEAg LTExNjk2LDEwICsxMTY5NiwxMSBAQCB0YXNrLCB5b3UgY2FuIHVzZSBAY29kZXs6Y2FwdGlvbn0g YXR0cmlidXRlIGluc3RlYWQuICBJdHMgdmFsdWUgc2hvdWxkIGJlIHJhdwogQExhVGVYe30gY29k ZS4gIEl0IGhhcyBwcmVjZWRlbmNlIG92ZXIgQGNvZGV7IytDQVBUSU9OfS4KIEBpdGVtIDpmbG9h dAogQGl0ZW14IDpwbGFjZW1lbnQKLUZsb2F0IGVudmlyb25tZW50IGZvciB0aGUgdGFibGUuICBQ b3NzaWJsZSB2YWx1ZXMgYXJlIEBjb2Rle3NpZGV3YXlzdGFibGV9LAotQGNvZGV7bXVsdGljb2x1 bW59LCBAY29kZXt0fSBhbmQgQGNvZGV7bmlsfS4gIFdoZW4gdW5zcGVjaWZpZWQsIGEgdGFibGUg d2l0aAotYSBjYXB0aW9uIHdpbGwgaGF2ZSBhIEBjb2Rle3RhYmxlfSBlbnZpcm9ubWVudC4gIE1v cmVvdmVyLCBAY29kZXs6cGxhY2VtZW50fQotYXR0cmlidXRlIGNhbiBzcGVjaWZ5IHRoZSBwb3Np dGlvbmluZyBvZiB0aGUgZmxvYXQuCitUaGUgQGNvZGV7OmZsb2F0fSBzcGVjaWZpZXMgdGhlIGZs b2F0IGVudmlyb25tZW50IGZvciB0aGUgdGFibGUuICBQb3NzaWJsZSB2YWx1ZXMgYXJlIEBjb2Rl e3NpZGV3YXlzfSwKKyhvciBlcXVpdmFsZW50bHkgQGNvZGV7c2lkZXdheXN0YWJsZX0pLCBAY29k ZXttdWx0aWNvbHVtbn0sIEBjb2Rle3R9IGFuZCBAY29kZXtuaWx9LiAgV2hlbiB1bnNwZWNpZmll ZCwgYSB0YWJsZSB3aXRoCithIGNhcHRpb24gd2lsbCBoYXZlIGEgQGNvZGV7dGFibGV9IGVudmly b25tZW50LiAgTW9yZW92ZXIsIHRoZSBAY29kZXs6cGxhY2VtZW50fQorYXR0cmlidXRlIGNhbiBz cGVjaWZ5IHRoZSBwb3NpdGlvbmluZyBvZiB0aGUgZmxvYXQuIE5vdGU6IEBjb2RlezpwbGFjZW1l bnR9IGlzCitpZ25vcmVkIGZvciBzaWRld2F5c3RhYmxlLgogQGl0ZW0gOmFsaWduCiBAaXRlbXgg OmZvbnQKIEBpdGVteCA6d2lkdGgKQEAgLTExODAyLDYgKzExODAzLDExIEBAIGVudmlyb25tZW50 LgogQGNvZGV7d3JhcH06IGlmIHlvdSB3b3VsZCBsaWtlIHRvIGxldCB0ZXh0IGZsb3cgYXJvdW5k IHRoZSBpbWFnZS4gIEl0IHdpbGwKIG1ha2UgdGhlIGZpZ3VyZSBvY2N1cHkgdGhlIGxlZnQgaGFs ZiBvZiB0aGUgcGFnZS4KIEBpdGVtCitAY29kZXtzaWRld2F5c306IGlmIHlvdSB3b3VsZCBsaWtl IHRoZSBpbWFnZSB0byBhcHBlYXIgYWxvbmUgb24gYSBzZXBhcmF0ZQorcGFnZSByb3RhdGVkIG5p bmV0eSBkZWdyZWVzIHVzaW5nIHRoZSBAY29kZXtzaWRld2F5c2ZpZ3VyZX0KK2Vudmlyb25tZW50 LiBTZXR0aW5nIHRoaXMgQGNvZGV7OmZsb2F0fSBvcHRpb24gd2lsbCBpZ25vcmUgdGhlCitAY29k ZXs6cGxhY2VtZW50fSBzZXR0aW5nLgorQGl0ZW0KIEBjb2Rle25pbH06IGlmIHlvdSBuZWVkIHRv IGF2b2lkIGFueSBmbG9hdGluZyBlbnZpcm9ubWVudCwgZXZlbiB3aGVuCiBhIGNhcHRpb24gaXMg cHJvdmlkZWQuCiBAZW5kIGl0ZW1pemUKZGlmZiAtLWdpdCBhL2xpc3Avb3gtbGF0ZXguZWwgYi9s aXNwL294LWxhdGV4LmVsCmluZGV4IGMwNWZmYjYuLmVjY2ZhM2QgMTAwNjQ0Ci0tLSBhL2xpc3Av b3gtbGF0ZXguZWwKKysrIGIvbGlzcC9veC1sYXRleC5lbApAQCAtMTgwMSw3ICsxODAxLDcgQEAg dXNlZCBhcyBhIGNvbW11bmljYXRpb24gY2hhbm5lbC4iCiAJIChmbG9hdCAobGV0ICgoZmxvYXQg KHBsaXN0LWdldCBhdHRyIDpmbG9hdCkpKQogCQkgIChjb25kICgoYW5kIChub3QgZmxvYXQpIChw bGlzdC1tZW1iZXIgYXR0ciA6ZmxvYXQpKSBuaWwpCiAJCQkoKHN0cmluZz0gZmxvYXQgIndyYXAi KSAnd3JhcCkKLQkJCSgoc3RyaW5nPSBmbG9hdCAic2lkZXdheXNmaWd1cmUiKSAnc2lkZXdheXNm aWd1cmUpCisJCQkoKHN0cmluZz0gZmxvYXQgInNpZGV3YXlzIikgJ3NpZGV3YXlzKQogCQkJKChz dHJpbmc9IGZsb2F0ICJtdWx0aWNvbHVtbiIpICdtdWx0aWNvbHVtbikKIAkJCSgob3IgZmxvYXQK IAkJCSAgICAgKG9yZy1lbGVtZW50LXByb3BlcnR5IDpjYXB0aW9uIHBhcmVudCkKQEAgLTE4Nzcs MTAgKzE4NzcsMTAgQEAgdXNlZCBhcyBhIGNvbW11bmljYXRpb24gY2hhbm5lbC4iCiBcXGNlbnRl cmluZwogJXMlcwogJXNcXGVuZHt3cmFwZmlndXJlfSIgcGxhY2VtZW50IGNvbW1lbnQtaW5jbHVk ZSBpbWFnZS1jb2RlIGNhcHRpb24pKQotICAgICAgKHNpZGV3YXlzZmlndXJlIChmb3JtYXQgIlxc YmVnaW57c2lkZXdheXNmaWd1cmV9JXMKKyAgICAgIChzaWRld2F5cyAoZm9ybWF0ICJcXGJlZ2lu e3NpZGV3YXlzZmlndXJlfQogXFxjZW50ZXJpbmcKICVzJXMKLSVzXFxlbmR7c2lkZXdheXNmaWd1 cmV9IiBwbGFjZW1lbnQgY29tbWVudC1pbmNsdWRlIGltYWdlLWNvZGUgY2FwdGlvbikpCislc1xc ZW5ke3NpZGV3YXlzZmlndXJlfSIgY29tbWVudC1pbmNsdWRlIGltYWdlLWNvZGUgY2FwdGlvbikp CiAgICAgICAobXVsdGljb2x1bW4gKGZvcm1hdCAiXFxiZWdpbntmaWd1cmUqfSVzCiBcXGNlbnRl cmluZwogJXMlcwpAQCAtMjU1Miw3ICsyNTUyLDggQEAgVGhpcyBmdW5jdGlvbiBhc3N1bWVzIFRB QkxFIGhhcyBgb3JnJyBhcyBpdHMgYDp0eXBlJyBwcm9wZXJ0eSBhbmQKIAkJICAgICAgKGxldCAo KGZsb2F0IChwbGlzdC1nZXQgYXR0ciA6ZmxvYXQpKSkKIAkJCShjb25kCiAJCQkgKChhbmQgKG5v dCBmbG9hdCkgKHBsaXN0LW1lbWJlciBhdHRyIDpmbG9hdCkpIG5pbCkKLQkJCSAoKHN0cmluZz0g ZmxvYXQgInNpZGV3YXlzdGFibGUiKSAic2lkZXdheXN0YWJsZSIpCisJCQkgKChvciAoc3RyaW5n PSBmbG9hdCAic2lkZXdheXN0YWJsZSIpCisJCQkgICAgICAoc3RyaW5nPSBmbG9hdCAic2lkZXdh eXMiKSkgInNpZGV3YXlzdGFibGUiKQogCQkJICgoc3RyaW5nPSBmbG9hdCAibXVsdGljb2x1bW4i KSAidGFibGUqIikKIAkJCSAoKG9yIGZsb2F0CiAJCQkgICAgICAob3JnLWVsZW1lbnQtcHJvcGVy dHkgOmNhcHRpb24gdGFibGUpCi0tIAoxLjguNC4zCgo= --001a11c3f020f1c5b904f657efe8--