From: Fabrice Popineau <fabrice.popineau@gmail.com>
To: Fabrice Popineau <fabrice.popineau@gmail.com>,
"emacs-orgmode@gnu.org" <emacs-orgmode@gnu.org>
Subject: Re: ox-html, top-row-p
Date: Tue, 15 Dec 2015 00:05:31 +0100 [thread overview]
Message-ID: <CAFgFV9PfFMC1zwtkE=0W7U5SYHcffrqxjUymL5o-WTsHkB22yA@mail.gmail.com> (raw)
In-Reply-To: <87lh8wzlwa.fsf@nicolasgoaziou.fr>
[-- Attachment #1: Type: text/plain, Size: 998 bytes --]
2015-12-14 23:49 GMT+01:00 Nicolas Goaziou <mail@nicolasgoaziou.fr>:
> Hello,
>
> Fabrice Popineau <fabrice.popineau@gmail.com> writes:
>
> > So the problem is due to lexical binding (I am using emacs 25 devel
> branch).
> > The following variables can't be dynamically bound anymore in ox-html:
> > row-number, rowgroup-number, start-rowgroup-p, end-rowgroup-p,
> > top-row-p, bottom-row-p
> > .
> > There are 2 options :
> > - declare them with defvar
> > - pass them to eval as an environment.
> > Here is a patch for the second option, but I wonder if the first one
> > wouldn't be better.
>
> Another option would be to remove that ugly `eval' hack altogether, and
> instead use a function returning a string, called with 6 arguments (or
> with 3 arguments: row-number, rowgroup-number, and list of symbols among
> `top', `bottom', `start' and `end').
>
> WDYT?
>
I am not fond of eval at all, at least not in this specific case.
So yes, your way is at least as good as what I did.
Fabrice
[-- Attachment #2: Type: text/html, Size: 1565 bytes --]
next prev parent reply other threads:[~2015-12-14 23:05 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-12 23:36 ox-html, top-row-p Fabrice Popineau
2015-12-13 9:31 ` Fabrice Popineau
2015-12-14 22:49 ` Nicolas Goaziou
2015-12-14 23:05 ` Fabrice Popineau [this message]
2015-12-14 23:20 ` Nicolas Goaziou
2015-12-15 22:34 ` Fabrice Popineau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFgFV9PfFMC1zwtkE=0W7U5SYHcffrqxjUymL5o-WTsHkB22yA@mail.gmail.com' \
--to=fabrice.popineau@gmail.com \
--cc=emacs-orgmode@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).