emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed

From: Fabrice Popineau <fabrice.popineau@gmail.com>
To: "emacs-orgmode@gnu.org" <emacs-orgmode@gnu.org>
Subject: org-eldoc and shell
Date: Sat, 15 Oct 2016 17:03:59 +0200	[thread overview]
Message-ID: <CAFgFV9O+-okPNBDEwA3hke_EU6on9DZPC5Sd4vMa0sKy6z_q2g@mail.gmail.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 971 bytes --]

Hi,

In org-eldoc.el, org-eldoc-get-mode-local-documentation-function function,
there is this code:

(with-temp-buffer
            (funcall mode-func)
            (setq doc-func (and eldoc-documentation-function
                                (symbol-value
'eldoc-documentation-function)))
            (puthash lang doc-func org-eldoc-local-functions-cache))

Unfortunately, this code does not work for shell-mode.
Especially, if you get a temp buffer and try to turn it into shell mode,
you get an error because there is no associated process.

Emacs 25.1 uses this in the shell-mode function to find which shell:
(let ((shell (file-name-nondirectory (car
  (process-command (get-buffer-process (current-buffer))))))

but if there is no process, get-buffer-process returns nil and
process-command fails.

I am only reporting this because I am not sure what to do about it
But surely it is a bit annoying that
<s TAB shell
runs into error every time.

Regards,

Fabrice

[-- Attachment #2: Type: text/html, Size: 1450 bytes --]

next             reply	other threads:[~2016-10-15 15:04 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-15 15:03 Fabrice Popineau [this message]
2016-10-18 11:47 ` org-eldoc and shell Aaron Ecay
2016-10-18 19:02   ` Fabrice Popineau

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAFgFV9O+-okPNBDEwA3hke_EU6on9DZPC5Sd4vMa0sKy6z_q2g@mail.gmail.com \
    --to=fabrice.popineau@gmail.com \
    --cc=emacs-orgmode@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).