emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed

From: Fabrice Popineau <fabrice.popineau@gmail.com>
To: "emacs-orgmode@gnu.org" <emacs-orgmode@gnu.org>
Subject: Re: ox-html, top-row-p
Date: Sun, 13 Dec 2015 10:31:00 +0100	[thread overview]
Message-ID: <CAFgFV9M8AC+g0iV6fPFODN_4iVDhSjXoC6DWre+fRL0aL6NzGA@mail.gmail.com> (raw)
In-Reply-To: <CAFgFV9PWOW3VHMsnFQdtCG3ZGDVqkPNO0Q3XBLEJDxSVWn5=Gg@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 2739 bytes --]

Hi,

So the problem is due to lexical binding (I am using emacs 25 devel branch).
The following variables can't be dynamically bound anymore in ox-html:
row-number, rowgroup-number, start-rowgroup-p, end-rowgroup-p,
top-row-p, bottom-row-p
.
There are 2 options :
- declare them with defvar
- pass them to eval as an environment.
Here is a patch for the second option, but I wonder if the first one
wouldn't be better.

diff --git a/vendor/org-mode/lisp/ox-html.el
b/vendor/org-mode/lisp/ox-html.el
index 6affac4..4e56ab3 100644
--- a/vendor/org-mode/lisp/ox-html.el
+++ b/vendor/org-mode/lisp/ox-html.el
@@ -3336,10 +3336,22 @@ communication channel."
        ;; Begin a rowgroup?
        (when start-rowgroup-p (car rowgroup-tags))
        ;; Actual table row.
-       (concat "\n" (eval (car (plist-get info :html-table-row-tags)) t)
+       (concat "\n" (eval (car (plist-get info :html-table-row-tags))
+                         `((row-number . ,row-number)
+                           (rowgroup-number . ,rowgroup-number)
+                           (start-rowgroup-p . ,start-rowgroup-p)
+                           (end-rowgroup-p . , end-rowgroup-p)
+                           (top-row-p . ,top-row-p)
+                           (bottom-row-p . ,bottom-row-p)))
               contents
               "\n"
-              (eval (cdr (plist-get info :html-table-row-tags)) t))
+              (eval (cdr (plist-get info :html-table-row-tags))
+                    `((row-number . ,row-number)
+                      (rowgroup-number . ,rowgroup-number)
+                      (start-rowgroup-p . ,start-rowgroup-p)
+                      (end-rowgroup-p . , end-rowgroup-p)
+                      (top-row-p . ,top-row-p)
+                      (bottom-row-p . ,bottom-row-p))))
        ;; End a rowgroup?
        (when end-rowgroup-p (cdr rowgroup-tags))))))

Best regards,

Fabrice

2015-12-13 0:36 GMT+01:00 Fabrice Popineau <fabrice.popineau@gmail.com>:

> Hi,
>
> I get an error in ox-html.el with the latest org-mode when exporting
> tables to html :
>
> Debugger entered--Lisp error: (void-variable top-row-p)
>   (cond (top-row-p "<tr class=\"tr-top\">") (bottom-row-p "<tr
> class=\"tr-bottom\">") (t (if (= (mod row-number 2) 1) "<tr
> class=\"tr-odd\">" "<tr class=\"tr-even\">")))
>   eval((cond (top-row-p "<tr class=\"tr-top\">") (bottom-row-p "<tr
> class=\"tr-bottom\">") (t (if (= (mod row-number 2) 1) "<tr
> class=\"tr-odd\">" "<tr class=\"tr-even\">"))) t)
>   org-html-table-row((table-row (:type standard :begin 1784 :end 1898
> :contents-begin 1785 :contents-end 1897 :post-blank 0 :post-affiliated 1784
> :parent ...))
>
> Can anybody confirm or is something wrong on my side ?
>
> Greetings,
>
> Fabrice
>

[-- Attachment #2: Type: text/html, Size: 4089 bytes --]

next prev parent reply	other threads:[~2015-12-13  9:31 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-12 23:36 ox-html, top-row-p Fabrice Popineau
2015-12-13  9:31 ` Fabrice Popineau [this message]
2015-12-14 22:49   ` Nicolas Goaziou
2015-12-14 23:05     ` Fabrice Popineau
2015-12-14 23:20       ` Nicolas Goaziou
2015-12-15 22:34         ` Fabrice Popineau

find likely ancestor, descendant, or conflicting patches for this message:
dfblob:6affac4 dfblob:4e56ab3
	(help)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAFgFV9M8AC+g0iV6fPFODN_4iVDhSjXoC6DWre+fRL0aL6NzGA@mail.gmail.com \
    --to=fabrice.popineau@gmail.com \
    --cc=emacs-orgmode@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).