From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lungang Fang Subject: Re: Fwd: [PATCH] Add support for ordered list to ox-confluence.el Date: Fri, 9 Dec 2016 13:32:58 +1100 Message-ID: References: <87pol2f34e.fsf@nicolasgoaziou.fr> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary=001a114016f881f29105433092a7 Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:39116) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cFB0e-0007mt-4M for emacs-orgmode@gnu.org; Thu, 08 Dec 2016 21:34:05 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cFB0a-0003AH-2i for emacs-orgmode@gnu.org; Thu, 08 Dec 2016 21:34:04 -0500 Received: from mail-qk0-f178.google.com ([209.85.220.178]:33878) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cFB0Z-0003A6-SD for emacs-orgmode@gnu.org; Thu, 08 Dec 2016 21:34:00 -0500 Received: by mail-qk0-f178.google.com with SMTP id q130so4953189qke.1 for ; Thu, 08 Dec 2016 18:33:59 -0800 (PST) In-Reply-To: List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: "Emacs-orgmode" To: cwdurst+orgmode@gmail.com Cc: emacs-orgmode@gnu.org --001a114016f881f29105433092a7 Content-Type: text/plain; charset=UTF-8 Hi Charles and Nicholas, My code also supports nested mixed lists but is simpler. I mean, my code will convert the list given by Charles to # Here -- is -- an # example -- of -- a # mixed # list Although this format is not mentioned in confluence wiki, it is supported by conflucence according to my test (in Jira). So, in my opinion, it is a matter of personal preference: more complicated code complies with documented interface, or simpler code that exploits undocumented feature. I prefer my code. But you guys feel free to make decision. I am OK with whatever you choose. Cheers, Lungang On Fri, Dec 9, 2016 at 10:37 AM, Charles Durst wrote: > They do conflict. My version is slightly more complicated since it > also supports nested mixed lists. > > For example: > > 1. Here > * is > * an > 2. example > * of > * a > 3. mixed > 4. list > > Which translates to: > > # Here > #- is > #- an > # example > #- of > #- a > # mixed > # list > > Which is effectively the same as the example in the Confluence > documentation: > https://confluence.atlassian.com/confcloud/confluence-wiki- > markup-724765099.html#ConfluenceWikiMarkup-Mixedlists > > -- > Charles Durst > cwdurst+orgmode@gmail.com > > > On Thu, Dec 8, 2016 at 5:49 PM, Nicolas Goaziou > wrote: > > Hello, > > > > Lungang Fang writes: > > > >> Attached is a patch for contrib/lisp/ox-confluence.el generated > following > >> instructions on http://orgmode.org/worg/org-contribute.html#patches . > It > >> adds support for ordered list. > > > > Thank you. > > > > However, this somewhat conflicts with a patch recently sent on the ML, > > but not yet applied, by Charles Durst (Cc'ed). > > > > Could one double-check if one doesn't supersede the other, or if they > > could be merged (although I suspect the former) and report back so > > I know what patch to apply? > > > > Regards, > > > > -- > > Nicolas Goaziou > --001a114016f881f29105433092a7 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
Hi Charles and Nicholas,

My code also s= upports nested mixed lists but is simpler. I mean, my code will convert the= list given by Charles to

# Here
-- is
-- an
# example
-- of
-- a<= /div>
# mixed
# list

Although = this format is not mentioned in confluence wiki, it is supported by confluc= ence according to my test (in Jira).

So, in my opi= nion, it is a matter of personal preference: more complicated code complies= with documented interface, or simpler code that exploits undocumented feat= ure.

I prefer my code. But you guys feel free to m= ake decision. I am OK with whatever you choose.

Ch= eers,
Lungang

On Fri, Dec 9, 2016 at 10:37 AM, Charles Durst <cwdurst+orgmode@gmail.com> wrote:
= They do conflict.=C2=A0 My version is slightly more = complicated since it
also supports nested mixed lists.

For example:

1. Here
=C2=A0 =C2=A0* is
=C2=A0 =C2=A0* an
2. example
=C2=A0 =C2=A0* of
=C2=A0 =C2=A0* a
3. mixed
4. list

Which translates to:

# Here
#- is
#- an
# example
#- of
#- a
# mixed
# list

Which is effectively the same as the example in the Confluence documentatio= n:
https://confluence.atlassian.com/confcloud/confluence-wiki= -markup-724765099.html#ConfluenceWikiMarkup-Mixedlists
--
Charles Durst
cwdurst+orgmode@gmail= .com


On Thu, Dec 8, 2016 at 5:49 PM, Nicolas Goaziou <mail@nicolasgoaziou.fr> wrote:
> Hello,
>
> Lungang Fang <lungang.fan= g@gmail.com> writes:
>
>> Attached is a patch for contrib/lisp/ox-confluence.el generated fo= llowing
>> instructions on http://orgmode.org/worg/= org-contribute.html#patches . It
>> adds support for ordered list.
>
> Thank you.
>
> However, this somewhat conflicts with a patch recently sent on the ML,=
> but not yet applied, by Charles Durst (Cc'ed).
>
> Could one double-check if one doesn't supersede the other, or if t= hey
> could be merged (although I suspect the former) and report back so
> I know what patch to apply?
>
> Regards,
>
> --
> Nicolas Goaziou

--001a114016f881f29105433092a7--