From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id sKtxHlsn+mN2NQAAbAwnHQ (envelope-from ) for ; Sat, 25 Feb 2023 16:20:59 +0100 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id EMxpHlsn+mMDIwEA9RJhRA (envelope-from ) for ; Sat, 25 Feb 2023 16:20:59 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 579ADF8ED for ; Sat, 25 Feb 2023 16:20:59 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pVwLI-00020u-AC; Sat, 25 Feb 2023 10:20:08 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pVwLG-000206-3b for emacs-orgmode@gnu.org; Sat, 25 Feb 2023 10:20:06 -0500 Received: from mail-ed1-x532.google.com ([2a00:1450:4864:20::532]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pVwLE-00007F-ET for emacs-orgmode@gnu.org; Sat, 25 Feb 2023 10:20:05 -0500 Received: by mail-ed1-x532.google.com with SMTP id eg37so8569643edb.12 for ; Sat, 25 Feb 2023 07:20:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=UHH4nlx8yFMdMCJ/OFXabm9UMoRSm5+kCLJbIYe+w4g=; b=gLMQFc7PRftTqkbNzausiPt/cJpSSL4fStz1aBUPQ7cdRSrQKzOao70/HVYM65YPIy AKsZ3j3pgOfpKxiIPwwPYjqeCORgiYldg0hpLvMV8FqVt0YuaV6rqq4VyvxF/dSGy4BV qAjnvhiInlJGUBKAY6Lj3mEVVfnxxFrq1wt8ox00rckzkUssk75doG19Ne0VfQNHkP/o pdlOijPPs/7+Cf5moCj9x05DO2oSnkhf+i7JB+qAH11Dmp9sgE03lY8fXjqR6n4SSk8o 4pu37ycg3VHhJWapDtZs5qp2oB0ZDS60P6Z2KtIle2xqAUqA2jWR40q9adkRSqS1X/CX q+2A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=UHH4nlx8yFMdMCJ/OFXabm9UMoRSm5+kCLJbIYe+w4g=; b=FCvzimxyMzNl22xn5ix9UQ86QnxqdARJnZcVfhhGpKLrWwo9qhLj87u5QxO+xzyfj7 KmNhNqHwOYd7P3TNAYFu18RdpYT5bUyZqyhc4E9mlziZk2335PCGCz1jjE9ExAYl9yUt oZ5CH0gZ119z8GQGpX795RBRrYDYLbXKAJ1/VSAFkoAZP8ncoID+X1BdpTf6Y+Hzy5dZ 05a8N5PGYbh+3j6jkfEnCO1Rdtq98kSa3Bajc5CbBKWI1S2rCNDw/2Dyqzt1UkSp/wkZ LyeBwtLz5tWNweQ4zPYN+6NA+O7DHJzuuekLdVTfSt3N6rR4I1jmE1qRfdKqTwP81WBH A4Cw== X-Gm-Message-State: AO0yUKUp/p8IKf4oPZZTUgNHNqCBc2bivIAnQ+xF2Lm07XVFO1DDJn+V PIK47EXD6d7OoqjOVkOlMJPqgK84yL25xol/zJw= X-Google-Smtp-Source: AK7set/kmYyD2SyXeTQ7LijyC28jfVFPFqAaGGwDOdB1eMDFaAzCZItJdh0ucTGcare/Vg/gUg3Wv5FOBp0rOln2ABI= X-Received: by 2002:a17:906:3388:b0:8af:b63:b4ba with SMTP id v8-20020a170906338800b008af0b63b4bamr12491728eja.3.1677338402238; Sat, 25 Feb 2023 07:20:02 -0800 (PST) MIME-Version: 1.0 References: <87pm9z8089.fsf@t480.home> <87y1om7w23.fsf@t480.home> <96a91a35-eeb6-55d3-683d-5d51ff6d496e@gmail.com> <877cw5aiab.fsf@t480.home> In-Reply-To: <877cw5aiab.fsf@t480.home> From: Ken Mankoff Date: Sat, 25 Feb 2023 07:19:25 -0800 Message-ID: Subject: Re: [PATCH] lisp/ob-screen.el: Support ~:var~ header args for babel blocks To: Max Nikulin Cc: emacs-orgmode@gnu.org Content-Type: multipart/alternative; boundary="000000000000a2361805f587c718" Received-SPF: pass client-ip=2a00:1450:4864:20::532; envelope-from=mankoff@gmail.com; helo=mail-ed1-x532.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: emacs-orgmode-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=gLMQFc7P; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=key1; d=yhetil.org; t=1677338459; a=rsa-sha256; cv=none; b=C8TlJVWcselPLttee8EZH/8u4jIRzHqNa1y+qsIFy2azTumlzYFBsvq6Rli7SrOXJ2wjo5 EI4tLmQxkXpgDDubGwAqPuys55IrIvTIvZgHQuk7HrpkGlbrlNT3oYIFtTvo1pMJ3eoBuB pERJOe5FqPO2QJfc2rxtvbMRtkl1549Iwotnemy/V4sodhcKbmcA2uNGWKU/n35MpN1LwC APO52bZ2LjJEfBnAITvRIASatKusJQal0RXuNjcV+TAz+tgkuNzf0Sk1G74IILEHeCWevE Gho8DxiMlJ1a2XACaZvIxNFpNwg0gob96T68tj2s5aDnYZ9xjhofbCDP/oviDw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1677338459; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=UHH4nlx8yFMdMCJ/OFXabm9UMoRSm5+kCLJbIYe+w4g=; b=Fm9CXXy2rPi/U6pwk+9AXJRK8UhAZ1j6xtydH91ACgEaYyr2oCVZnOkU0Fz4Nfnyui7NwL nPhqUV9hkS8nQ+sfF3+EXAtUv5Xp+jJt6FrZtcF8g0AFXLOi3EThzq0paVcadJ2/M4QgVf b2UQ74cT1KF2WUBQsxPqUFjwEnliEbxBapo2QENQuW0SfjwsAUlH81B6UZS5nIYCg3fTbB vC8u9Db4SMaiIzsBzG12sl7FDa6P0hOgjCJCiLo5IjzHIYdlFxmUGgw9nvmyoYat0YJIEO 9ptbgduVihknS/oQW7QXc+ZMgckIivdB2uPWmOJuJvaE/ouKJ+g7V62ENhQIoA== X-Migadu-Spam-Score: -4.90 X-Spam-Score: -4.90 X-Migadu-Queue-Id: 579ADF8ED X-Migadu-Scanner: scn1.migadu.com Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=gLMQFc7P; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gmail.com X-TUID: z6QB+CJUzRj9 --000000000000a2361805f587c718 Content-Type: text/plain; charset="UTF-8" I note that `org-babel-screen-test` fails, but it appears to fail before this change too... -k. On Sat, Feb 25, 2023 at 7:14 AM Ken Mankoff wrote: > Hi Max, > > On 2023-02-24 at 19:51 -08, Max Nikulin wrote: > > On 25/02/2023 01:33, Ken Mankoff wrote: > > I am unsure if Org markup is suitable for commit messages (~:var~) > > since it may appear in Emacs commit logs. > > Fixed. > > > The code still depends on on ob-shell. Is there a reason why calling > > `org-babel-variable-assignments:shell' is a worse variant than copy of > > the whole function body? > > I didn't realize that was a dependency. I now use that function. This also > means that arrays/tables/etc. are all supported by :var, although not in > the default screen ":cmd sh" because sh doesn't support "declare", but it > works with ":cmd bash". > > Improved patch attached. > > Thanks, > > -k. > > > > --000000000000a2361805f587c718 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
I note that `org-babel-screen-test` fails, but it app= ears to fail before this change too...

=C2=A0 -k.<= br>

On Sat, Feb 25, 2023 at 7:14 AM Ken Mankoff <mankoff@gmail.com> wrote:
Hi Max,

On 2023-02-24 at 19:51 -08, Max Nikulin <manikulin@gmail.com> wrote:
> On 25/02/2023 01:33, Ken Mankoff wrote:
> I am unsure if Org markup is suitable for commit messages (~:var~)
> since it may appear in Emacs commit logs.

Fixed.

> The code still depends on on ob-shell. Is there a reason why calling > `org-babel-variable-assignments:shell' is a worse variant than cop= y of
> the whole function body?

I didn't realize that was a dependency. I now use that function. This a= lso means that arrays/tables/etc. are all supported by :var, although not i= n the default screen ":cmd sh" because sh doesn't support &qu= ot;declare", but it works with ":cmd bash".

Improved patch attached.

Thanks,

=C2=A0 -k.



--000000000000a2361805f587c718--