From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id yFTbIHfbYGKv6gAAbAwnHQ (envelope-from ) for ; Thu, 21 Apr 2022 06:20:07 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id GHD9H3fbYGIn4gAAG6o9tA (envelope-from ) for ; Thu, 21 Apr 2022 06:20:07 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 284413FEFD for ; Thu, 21 Apr 2022 06:20:07 +0200 (CEST) Received: from localhost ([::1]:50352 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nhOIY-00050h-Bh for larch@yhetil.org; Thu, 21 Apr 2022 00:20:06 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:48640) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nhESd-0006I7-Do for emacs-orgmode@gnu.org; Wed, 20 Apr 2022 13:49:51 -0400 Received: from mail-yb1-xb31.google.com ([2607:f8b0:4864:20::b31]:45746) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nhESb-0006eC-Lz for emacs-orgmode@gnu.org; Wed, 20 Apr 2022 13:49:51 -0400 Received: by mail-yb1-xb31.google.com with SMTP id g14so906765ybj.12 for ; Wed, 20 Apr 2022 10:49:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:from:date:message-id:subject:to; bh=EWzUQo/pI38AEorDWcACc0mBmrGVTOnVadiKRIUZOtE=; b=oAeVAC7xpeiyI/cN02bBBMSFQ1ZoOU7uOGrSZCylSfQZL3VlqIgrX1dY8fZj2cC9yy FP/JY97cnOgav6ak+IcTFSqY8O3nnfhK722+kQRbLDMfr65msi7U19hYsCBiAViZYraV 1QFlkOAQIW2s8B75R7zOmwGKfQiLor/8cdp0gE7zK90gf+u8eDJoTlIo5YIQsgLwqI4T iAin/cl2BIaxTzhP+684W28VZ0ILDTsB9LFuegH3upoasTSD4Z9sQ0mURvP5ne2jse2s FIskgg1WD/nQa0DWUXjAJ4l1AFMv66T/Jj/bslvnAaC8k85pjwbDpPTzpW38nblClvH6 4Lgw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=EWzUQo/pI38AEorDWcACc0mBmrGVTOnVadiKRIUZOtE=; b=YVdI7N/LmoQF4cIOFi2spnSNJqpDOM1xkMYHp4QMihkqpJ40NtdP4jLCi2cB2PfMpk Qs11OKk3I56mjpGkYVOAv92LKtL98po202lzVEYHvn/FJoaUXPVKJJ/ux4ghkoVZnZwq v1ajeNsbBLRQDJ9XRxv4KAqnjvO1O+GCg5YMrJ2DI04wjxrD08Y2SH1DxLRFc9wils1g uwBPY9bOamW/1x1StuDrY1Rk6k9oPkuR0GCCf49+MNzZcvFSCeavtxjPtmYGRBf2/6DZ x7ofG4TSutX5KHAVxUDPUEzYLK4vRctLYaLZ79uUSHyt9z87WCAaLlBtIzATJVNPS51F Rk2g== X-Gm-Message-State: AOAM5339yPD87U8xpoSc+d3nFWgUubKr5jWhl1h6X4Y0SqUluVNEEs80 BFz8LGesD9oW8azdsLBDG8ve7Jdd/EkCqjtS1GKw024Us3E= X-Google-Smtp-Source: ABdhPJxmq/a5shfJBPGtwvKwxICpWM8j7W++PBJEAWuvmMhra+k0L2Z96dLZUig+yleunpqpEbxjcp37vvNF2ncKO5M= X-Received: by 2002:a25:ba47:0:b0:63e:542a:a9fb with SMTP id z7-20020a25ba47000000b0063e542aa9fbmr20215810ybj.476.1650476987665; Wed, 20 Apr 2022 10:49:47 -0700 (PDT) MIME-Version: 1.0 From: Javier Olaechea Date: Wed, 20 Apr 2022 12:49:36 -0500 Message-ID: Subject: Fix M-j with default fill-prefix value To: emacs-orgmode@gnu.org Content-Type: multipart/mixed; boundary="0000000000008fbfb105dd199eed" Received-SPF: pass client-ip=2607:f8b0:4864:20::b31; envelope-from=pirata@gmail.com; helo=mail-yb1-xb31.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Mailman-Approved-At: Thu, 21 Apr 2022 00:19:23 -0400 X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1650514807; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=CnLKcf6iiNTFWDf1++O4zHuVSEsgl/aSRrGpJAjjnyM=; b=WgoXznHEU0EaNamP28YN+EyqXAk19BI/R8cSBtEpbYfBVP9DvFBSVaTmWUAnppDiFZc81Y hCKQmuotXCgqWGHVNhn8b7iBuZyvJsZxuPpqytKMBR6Mho9nzIYRCqPZsOZB6Ms4bLAxdm +Pz4KMu7iEvef4JR8o5eQ1TzT2ItNHf9AwyZwlPXFRqGPUL+CfApZB6hNIN05txxxMQj2F kGDW+XtF8rL8/hglkqkcDS+ymbRbdnw4DhjcQHkz/26OL1NYmCpiqbBfBiIfOz1NoaRIgJ 1gK+zPD7lCq4cJjv3bEuMJU/bQcKRO+tGrbvt7/crR0AtOpu2vDy57exz2OWOA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1650514807; a=rsa-sha256; cv=none; b=TCVG3c1cW3f0EmImQcDuwXlvWBcFXNMXuf5k49V3WE3TVWPHWe970txlx1wDHuaHFJ9ZXz tr9+hhUlDDR0PdjmeusZAPXrK1nPcZXPpYdN330GT4nQMJ2r9jq/pNjqM7L+LjuNURZv1Y z1l3vOpnMI5xtS5yhsWxjk4eV+APFfeqpWI/2ON2u5L0Dzauz2TvR55j/V2s18G1oOI/4C v3QFoxHQ5pnGvSoT4MW5FBjGofe7k7xIJuJdHWwbGQ2atAfqLdgAetrb4hu812ss3u3ZjC 8XI9xBgRYt/4NZS0xGKZKjbqY+vNd+Lj1yAf6s/waGiGkdJxTr7PNHrQzXn6Rw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("body hash did not verify") header.d=gmail.com header.s=20210112 header.b=oAeVAC7x; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: 7.26 Authentication-Results: aspmx1.migadu.com; dkim=fail ("body hash did not verify") header.d=gmail.com header.s=20210112 header.b=oAeVAC7x; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 284413FEFD X-Spam-Score: 7.26 X-Migadu-Scanner: scn1.migadu.com X-TUID: fFQHiCf2aUkX --0000000000008fbfb105dd199eed Content-Type: multipart/alternative; boundary="0000000000008fbfae05dd199eeb" --0000000000008fbfae05dd199eeb Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable org-comment-line-break-function does not handle fill-prefix being set to nil, which is the default value for fill-prefix. This means that pressing M-j inside an org-mode buffer in a vanilla installation of Emacs results in an error. From looking at other callers of insert-before-markers-and-inherit it is clear that a guard against fill-prefix being nil is missing. This has been reported beforehttps:// list.orgmode.org/87o861o9sh.fsf@aquinas.i-did-not-set--mail-host-address--s= o-tickle-me/ Cheers, Javier Olaechea --=20 "I object to doing things that computers can do." =E2=80=94 Olin Shivers --0000000000008fbfae05dd199eeb Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
org-comment-line-break-function does not handle fill-= prefix being set to nil, which is the default value for fill-prefix. This m= eans that pressing M-j inside an org-mode buffer in a vanilla installation = of Emacs results in an error. From looking at other callers of insert-befor= e-markers-and-inherit it is clear that a guard against fill-prefix being ni= l is missing.


<= div>Cheers,
Javier Olaechea

--
"I o= bject to doing things that computers can do." =E2=80=94 Olin Shivers
--0000000000008fbfae05dd199eeb-- --0000000000008fbfb105dd199eed Content-Type: text/x-patch; charset="US-ASCII"; name="0001-lisp-org.el-Allow-org-c-l-b-f-to-handle-an-empty-fil.patch" Content-Disposition: attachment; filename="0001-lisp-org.el-Allow-org-c-l-b-f-to-handle-an-empty-fil.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_l27uy71j0 RnJvbSAzNzJkYWVhNmNiZWU2MGRmMDNmMWE2OGJkNWZhYmNhNDIxMmExMmMzIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBKYXZpZXIgT2xhZWNoZWEgPHBpcmF0YUBnbWFpbC5jb20+CkRh dGU6IFdlZCwgMjAgQXByIDIwMjIgMTE6NTg6MDcgLTA1MDAKU3ViamVjdDogW1BBVENIXSBsaXNw L29yZy5lbDogQWxsb3cgb3JnLWMtbC1iLWYgdG8gaGFuZGxlIGFuIGVtcHR5IGZpbGwtcHJlZml4 CgoqIG9yZy5lbCAob3JnLWNvbW1lbnQtbGluZS1icmVhay1mdW5jdGlvbik6IFdoZW4gZmlsbC1w cmVmaXggaXMgbmlsLApkb24ndCBjYWxsIGBpbnNlcnQtYmVmb3JlLW1hcmtlcnMtYW5kLWluaGVy aXQnLgoKVGhlIGRlZmF1bHQgdmFsdWUgZm9yIGZpbGwtcHJlZml4IGlzIG5pbCwKYGluc2VydC1i ZWZvcmUtbWFya2Vycy1hbmQtaW5oZXJpdCcgZXhwZWN0cyBhIHN0cmluZy4gVGhpcyByZXN1bHRz IGluCmFuIGVycm9yIHdoZW4gY2FsbGluZyBgb3JnLWNvbW1lbnQtbGluZS1icmVhay1mdW5jdGlv bicsIGJvdW5kIHRvIE0taiwKb24gYSB2YW5pbGxhIGluc3RhbGxhdGlvbiBvZiBFbWFjcy4gV2Ug c2hvdWxkIGFkZCBhIGd1YXJkIGNoZWNraW5nCnRoYXQgZmlsbC1wcmVmaXggaXMgbm90IG5pbGwg YmVmb3JlIGNhbGxpbmcgaS1iLW0tYS1pLiBUaGUgb25seQpleGNlcHRpb24gaXMgd2hlbiBhZGFw dGl2ZS1maWxsLW1vZGUgaXMgZW5hYmxlZC4gVGhpcyBpcyB0aGUgYXBwcm9hY2gKdGhhdCB0aGF0 IHJlc3Qgb2YgdGhlIGNvZGUgaW4gRW1hY3MgdGFrZXMuIFNvbWUgY2FsbC1zaXRlcyBsaXN0ZWQK YmVsb3c6CgoqIHNpbXBsZS5lbCAoZGVmYXVsdC1pbmRlbnQtbmV3LWxpbmUpOiB1c2VzCiAgKGFu ZCBmaWxsLXByZWZpeCAobm90IGFkYXB0aXZlLWZpbGwtbW9kZSkgLi4uKQoKKiBuZXdjb21tZW50 LmVsIChjb21tZW50LWluZGVudC1uZXctbGluZSk6IHVzZXMKICAoYW5kIGZpbGwtcHJlZml4IChu b3QgYWRhcHRpdmUtZmlsbC1tb2RlKSAuLi4pCgoqIGZpbGwuZWwgKGZpbGwtbmV3LWxpbmUpOiB1 c2VzCiAgKGFuZCBmaWxsLXByZWZpeCAobm90IChlcXVhbCBmaWxsLXByZWZpeCAiIikpIC4uLikK ClRJTllDSEFOR0UKLS0tCiBsaXNwL29yZy5lbCB8IDMgKystCiAxIGZpbGUgY2hhbmdlZCwgMiBp bnNlcnRpb25zKCspLCAxIGRlbGV0aW9uKC0pCgpkaWZmIC0tZ2l0IGEvbGlzcC9vcmcuZWwgYi9s aXNwL29yZy5lbAppbmRleCAyMzUzYzY1OTQuLjQxNzZjNjgzZiAxMDA2NDQKLS0tIGEvbGlzcC9v cmcuZWwKKysrIGIvbGlzcC9vcmcuZWwKQEAgLTE5OTQzLDcgKzE5OTQzLDggQEAgKGRlZnVuIG9y Zy1jb21tZW50LWxpbmUtYnJlYWstZnVuY3Rpb24gKCZvcHRpb25hbCBzb2Z0KQogICAoc2F2ZS1l eGN1cnNpb24gKGZvcndhcmQtY2hhciAtMSkgKGRlbGV0ZS1ob3Jpem9udGFsLXNwYWNlKSkKICAg KGRlbGV0ZS1ob3Jpem9udGFsLXNwYWNlKQogICAoaW5kZW50LXRvLWxlZnQtbWFyZ2luKQotICAo aW5zZXJ0LWJlZm9yZS1tYXJrZXJzLWFuZC1pbmhlcml0IGZpbGwtcHJlZml4KSkKKyAgKGFuZCBm aWxsLXByZWZpeCAobm90IGFkYXB0aXZlLWZpbGwtbW9kZSkKKyAgICAgICAoaW5zZXJ0LWJlZm9y ZS1tYXJrZXJzLWFuZC1pbmhlcml0IGZpbGwtcHJlZml4KSkpCiAKIAogOzs7IEZpeGVkIFdpZHRo IEFyZWFzCi0tIAoyLjI5LjIuMTU0Lmc3ZjdlYmUwNTRhCgo= --0000000000008fbfb105dd199eed--