emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Aaron Zeng <me@bcc32.com>
To: Ihor Radchenko <yantar92@posteo.net>
Cc: emacs-orgmode@gnu.org
Subject: Re: [PATCH] lisp/org-agenda.el: Fix void-function string-pad in Emacs <28.1
Date: Tue, 24 Jan 2023 11:30:51 -0500	[thread overview]
Message-ID: <CAFTimbVFenknvC1MsF2ao4T2rw0tq-cmQKJM88QYr+B3UfFcHw@mail.gmail.com> (raw)
In-Reply-To: <87358070bu.fsf@localhost>

[-- Attachment #1: Type: text/plain, Size: 1008 bytes --]

Thanks for the quick response, Ihor!

On Tue, Jan 24, 2023 at 4:23 AM Ihor Radchenko <yantar92@posteo.net> wrote:

> "Aaron L. Zeng" <me@bcc32.com> writes:
>
> > * org-compat.el (org-string-pad): Add compatibility function
> > `org-string-pad' for `string-pad', introduced in Emacs 28.1.
> >
> > * org-agenda.el (org-fix-agenda-info): Use `org-string-pad' rather
> > than `string-pad'.
> >
> > Since this is more-or-less just copying string-pad's definition from
> > subr-x.el, I think this qualifies for TINYCHANGE.
>
> Thanks!
> This issue has not been caught by byte-compilation.
>
> I applied an alternative fix not using `string-pad' at all.
> Canceled.
>
>
> https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=5bbb97f3df9788646b8d48d60e8b8ea06566e05f
>
> --
> Ihor Radchenko // yantar92,
> Org mode contributor,
> Learn more about Org mode at <https://orgmode.org/>.
> Support Org development at <https://liberapay.com/org-mode>,
> or support my work at <https://liberapay.com/yantar92>
>

[-- Attachment #2: Type: text/html, Size: 1876 bytes --]

  reply	other threads:[~2023-01-24 16:32 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-24  2:52 [PATCH] lisp/org-agenda.el: Fix void-function string-pad in Emacs <28.1 Aaron L. Zeng
2023-01-24  9:23 ` Ihor Radchenko
2023-01-24 16:30   ` Aaron Zeng [this message]
2023-01-24 17:47     ` Aaron Zeng
2023-01-24 18:21       ` Ihor Radchenko
2023-01-24 18:35         ` Aaron Zeng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAFTimbVFenknvC1MsF2ao4T2rw0tq-cmQKJM88QYr+B3UfFcHw@mail.gmail.com \
    --to=me@bcc32.com \
    --cc=emacs-orgmode@gnu.org \
    --cc=yantar92@posteo.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).