From mboxrd@z Thu Jan  1 00:00:00 1970
From: Hiroshi Saito <monodie@gmail.com>
Subject: Re: [PATCH] Substitute a guid XML element in org-feed
Date: Sat, 14 Nov 2015 13:15:32 +0900
Message-ID: <CAFEtL0dQpMyv1uJ8sGLMctqJv_SFEW7wnZeCjGdbhzLZL0ATdA@mail.gmail.com>
References: <CAFEtL0ft1s4nPQNCb=q0--U2juBHDw4NkTuY-7+s5Xqo6wJyQg@mail.gmail.com>
	<CALn3zogyW7_RTG=uOeN=Y-xGyyjpUYeh6EBpdPaEdPentE3yGw@mail.gmail.com>
	<CAFEtL0fj3MZz5eYfcjPXz2UXKWRWgSFNyJXuKtKko9g5ZzTxAQ@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:44900)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <monodie@gmail.com>) id 1ZxSG9-0004Xr-2x
	for emacs-orgmode@gnu.org; Fri, 13 Nov 2015 23:16:17 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <monodie@gmail.com>) id 1ZxSG7-0003H6-RX
	for emacs-orgmode@gnu.org; Fri, 13 Nov 2015 23:16:17 -0500
Received: from mail-lf0-x230.google.com ([2a00:1450:4010:c07::230]:35349)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <monodie@gmail.com>) id 1ZxSG7-0003Gy-K3
	for emacs-orgmode@gnu.org; Fri, 13 Nov 2015 23:16:15 -0500
Received: by lfdo63 with SMTP id o63so62659210lfd.2
	for <emacs-orgmode@gnu.org>; Fri, 13 Nov 2015 20:16:14 -0800 (PST)
In-Reply-To: <CAFEtL0fj3MZz5eYfcjPXz2UXKWRWgSFNyJXuKtKko9g5ZzTxAQ@mail.gmail.com>
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-orgmode>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
To: Nicolas Goaziou <mail@nicolasgoaziou.fr>
Cc: Org Mode <emacs-orgmode@gnu.org>

Hi Nicolas,

Thank you for applying my patch.

I'm sorry to say the patch causes an error unless xml package is luckily
loaded. I attached another patch to fix it in my last post:
http://lists.gnu.org/archive/html/emacs-orgmode/2015-10/msg00417.html

Could you please review new patch or revert my first patch?

--
Sincerely,
Hiroshi Saito

2015-10-19 8:49 GMT+09:00 Hiroshi Saito <monodie@gmail.com>:
> Hi Michael,
>
> So sorry for that error. I did not notice.
>
> I wrote an additional patch to fix it. The patch makes sure that the xml
> library is loaded before calling `xml-substitute-special` as with
> `org-feed-parse-rss-entry` and `org-feed-parse-atom-feed`.
>
> --
> Sincerely,
> Hiroshi Saito
>
> 2015-10-19 2:54 GMT+09:00 Michael Brand <michael.ch.brand@gmail.com>:
>> Hi Hiroshi
>>
>> On Sun, Sep 27, 2015 at 8:24 PM, Hiroshi Saito <monodie@gmail.com> wrote:
>>> A guid XML element is not substituted in org-feed. Here is a patch
>>> to fix it.
>>
>> It causes the error
>>
>>     if: Symbol's function definition is void: xml-substitute-special
>>
>> because xml is not loaded yet.
>>
>> Michael