From mboxrd@z Thu Jan 1 00:00:00 1970 From: Hiroshi Saito Subject: [PATCH] Trouble updating some RSS feeds with org-feed Date: Wed, 23 Sep 2015 21:46:44 +0900 Message-ID: Mime-Version: 1.0 Content-Type: multipart/mixed; boundary=001a113fc41c24e8760520698471 Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:54344) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZejSJ-0002NR-I8 for emacs-orgmode@gnu.org; Wed, 23 Sep 2015 08:47:28 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZejSI-00011N-AK for emacs-orgmode@gnu.org; Wed, 23 Sep 2015 08:47:27 -0400 Received: from mail-la0-x231.google.com ([2a00:1450:4010:c03::231]:34249) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZejSI-000118-0n for emacs-orgmode@gnu.org; Wed, 23 Sep 2015 08:47:26 -0400 Received: by lahg1 with SMTP id g1so48979911lah.1 for ; Wed, 23 Sep 2015 05:47:24 -0700 (PDT) List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: emacs-orgmode@gnu.org --001a113fc41c24e8760520698471 Content-Type: text/plain; charset=UTF-8 Hi all, I noticed that the org-feed could not properly handle RSS feeds which do not contain element. The value of element is used as a key of an association list to manage entry statuses. The keys become `nil' when a element not found. Then no entries are added anymore after first update since a key of new entry (`nil') is already included in the association list. Here is an example .emacs: ---------------------------------------------------------------------- (setq org-feed-alist '(("Hacker News" "https://news.ycombinator.com/rss" "~/feed.org" "Hacker News" ))) ---------------------------------------------------------------------- After running `org-feed-update-all', keys of feed status in ~/feed.org are `nil' like this: ---------------------------------------------------------------------- :FEEDSTATUS: ((nil t "4e939ac25cb5b7c825c0894c364a220d5a98a7bf") (nil t "2eac7fd17ae277ba6ad6fd658da663bdf2a28586") (nil t "4939903fe5796ea1b5132209c5ab983e0558b5fd") ... :END: ---------------------------------------------------------------------- After that, `org-feed-update-all' no longer adds new entries in above reason. It is possible to work around this issue via `:parse_feed' option. But, I think it would be reasonable that org-feed handles -less RSS feeds. So, I wrote a small patch that uses a value of as a key if is missing. It's simple and not too bad since there's certain consistency to and except is also optional. Another option could be using a hash of or <description> but I feel it's excessive. -- Sincerely, Hiroshi Saito --001a113fc41c24e8760520698471 Content-Type: application/octet-stream; name="0001-org-feed.el-Use-a-value-of-link-as-guid-if-guid-is-m.patch" Content-Disposition: attachment; filename="0001-org-feed.el-Use-a-value-of-link-as-guid-if-guid-is-m.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_iews48oq0 RnJvbSA4ZmZhZTU5Y2UzMDFiYTc3ZTQ3MGJmM2ZmNDE1Yjk3YWVmNmU0ZTBhIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBIaXJvc2hpIFNhaXRvIDxzYWlkaWVAc2FpZGllLmluZm8+CkRh dGU6IFdlZCwgMjMgU2VwIDIwMTUgMTY6NTg6MDkgKzA5MDAKU3ViamVjdDogW1BBVENIXSBvcmct ZmVlZC5lbDogVXNlIGEgdmFsdWUgb2YgPGxpbms+IGFzIGd1aWQgaWYgPGd1aWQ+IGlzCiBtaXNz aW5nCgoqIGxpc3Avb3JnLWZlZWQuZWwgKG9yZy1mZWVkLXBhcnNlLXJzcy1mZWVkKTogU2V0IGEg dmFsdWUgb2YgPGxpbms+CmVsZW1lbnQgdG8gYDpndWlkJyBwcm9wZXJ0eSBvZiBhbiBlbnRyeSBp ZiA8Z3VpZD4gZWxlbWVudCBpcyBtaXNzaW5nLgoKSWYgYSBSU1MgZmVlZCBkb2VzIG5vdCBwcm92 aWRlIDxndWlkPiB0byBlbnRyaWVzLCBgOmd1aWQnIHByb3BlcnR5IG9mIGFuCmVudHJ5IGlzIGFs d2F5cyBgbmlsJy4gSW4gc3VjaCBhIGNhc2UsIG5ldyBmZWVkIGVudHJpZXMgYXJlIG5vIGxvbmdl cgphZGRlZCBiZWNhdXNlIHRoZSBwcm9wZXJ0eSBpcyB1c2VkIHRvIGRldGVjdCBkdXBsaWNhdGlv bi4KClRJTllDSEFOR0UKLS0tCiBsaXNwL29yZy1mZWVkLmVsIHwgNCArKystCiAxIGZpbGUgY2hh bmdlZCwgMyBpbnNlcnRpb25zKCspLCAxIGRlbGV0aW9uKC0pCgpkaWZmIC0tZ2l0IGEvbGlzcC9v cmctZmVlZC5lbCBiL2xpc3Avb3JnLWZlZWQuZWwKaW5kZXggZTUxMWJlMC4uN2JlODAzZSAxMDA2 NDQKLS0tIGEvbGlzcC9vcmctZmVlZC5lbAorKysgYi9saXNwL29yZy1mZWVkLmVsCkBAIC02MTUs OCArNjE1LDEwIEBAIGNvbnRhaW5pbmcgdGhlIHByb3BlcnRpZXMgYDpndWlkJyBhbmQgYDppdGVt LWZ1bGwtdGV4dCcuIgogCQkgICAgICAgKG1hdGNoLWJlZ2lubmluZyAwKSkpCiAJKHNldHEgaXRl bSAoYnVmZmVyLXN1YnN0cmluZyBiZWcgZW5kKQogCSAgICAgIGd1aWQgKGlmIChzdHJpbmctbWF0 Y2ggIjxndWlkXFw+Lio/PlxcKC4qP1xcKTwvZ3VpZD4iIGl0ZW0pCisJCSAgICAgICAob3JnLW1h dGNoLXN0cmluZy1uby1wcm9wZXJ0aWVzIDEgaXRlbSkpCisJICAgICAgbGluayAoaWYgKHN0cmlu Zy1tYXRjaCAiPGxpbmtcXD4uKj8+XFwoLio/XFwpPC9saW5rPiIgaXRlbSkKIAkJICAgICAgIChv cmctbWF0Y2gtc3RyaW5nLW5vLXByb3BlcnRpZXMgMSBpdGVtKSkpCi0JKHNldHEgZW50cnkgKGxp c3QgOmd1aWQgZ3VpZCA6aXRlbS1mdWxsLXRleHQgaXRlbSkpCisJKHNldHEgZW50cnkgKGxpc3Qg Omd1aWQgKG9yIGd1aWQgbGluaykgOml0ZW0tZnVsbC10ZXh0IGl0ZW0pKQogCShwdXNoIGVudHJ5 IGVudHJpZXMpCiAJKHdpZGVuKQogCShnb3RvLWNoYXIgZW5kKSkKLS0gCjIuNS4zCgo= --001a113fc41c24e8760520698471--