emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: "E.L.K." <some.any.key@gmail.com>
To: emacs-orgmode@gnu.org
Subject: [patch] When inserting entry template, don't include last newline in narrowed zone
Date: Sun, 28 Jun 2020 13:14:29 +0300	[thread overview]
Message-ID: <CAF+cOoMXJOkeWWG7p4NdhtzkebNUrEiajtZbk9w8-q+Fa-ohHQ@mail.gmail.com> (raw)

[-- Attachment #1.1: Type: text/plain, Size: 544 bytes --]


Org 9.3.6: when inserting the entry by capture mechanics, it narrows buffer
in a way that cursor can be moved to the last line, which is the beginning
of next (non-capture template) line in the original unnarowed buffer.

So this allows to: start capture, move point to the very last char of the
narrowed buffer, insert something. If this line in unnarowed buffer was
start of heading, it breaks structure of document.

This is patch in attempt to fix it. I followed same approach as in
org-capture-place-item function.


[-- Attachment #1.2: Type: text/html, Size: 692 bytes --]

[-- Attachment #2: dont-include-last-newline-in-the-insert-template-narrowing.patch --]
[-- Type: text/x-patch, Size: 785 bytes --]

Common subdirectories: org-9.3.6/etc and /home/elk/.emacs.d/elpa/org-9.3.6/etc
diff -U5 org-9.3.6/org-capture.el /home/elk/.emacs.d/elpa/org-9.3.6/org-capture.el
--- org-9.3.6/org-capture.el	2020-06-15 19:04:19.061012833 +0300
+++ /home/elk/.emacs.d/elpa/org-9.3.6/org-capture.el	2020-06-28 13:08:04.446045559 +0300
@@ -1149,11 +1149,11 @@
 	  (org-paste-subtree level template 'for-yank))
 	(org-capture-position-for-last-stored beg)
 	(unless (org-at-heading-p) (outline-next-heading))
 	(org-capture-mark-kill-region origin (point))
-	(org-capture-narrow beg (point))
+	(org-capture-narrow beg (1- (point)))
 	(when (or (search-backward "%?" beg t)
 		  (search-forward "%?" nil t))
 	  (replace-match ""))))))
 (defun org-capture-place-item ()

             reply	other threads:[~2020-06-28 10:15 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-28 10:14 E.L.K. [this message]
2020-06-28 11:17 ` [patch] When inserting entry template, don't include last newline in narrowed zone E.L.K.
2020-06-28 16:28 ` Kyle Meyer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAF+cOoMXJOkeWWG7p4NdhtzkebNUrEiajtZbk9w8-q+Fa-ohHQ@mail.gmail.com \
    --to=some.any.key@gmail.com \
    --cc=emacs-orgmode@gnu.org \


* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox


This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).