emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
* Re: bug#14346: 24.3; beginning-of-visual-line jumps to previous line in org-mode
       [not found]         ` <CAEp6DyaP8N21FCxSX6tos1Cco9kCoQhK05BJM49V4qz6A406JA@mail.gmail.com>
@ 2013-05-07  1:34           ` E Sabof
  2013-05-10  7:00             ` bug#14346: [O] " Carsten Dominik
  0 siblings, 1 reply; 2+ messages in thread
From: E Sabof @ 2013-05-07  1:34 UTC (permalink / raw)
  To: Eli Zaretskii, emacs-orgmode; +Cc: 14346

[-- Attachment #1: Type: text/plain, Size: 1604 bytes --]

Even if the behavior doesn't change (soon), could the equivalent of the
following be implemented in org-mode? It's the only place where this has
been problematic for me.

(defadvice org-beginning-of-line (after smart-point-adjustment activate)
  (setq disable-point-adjustment
        (or (not (invisible-p (point)))
            (not (invisible-p (max (point-min) (1- (point))))))))

(defadvice org-end-of-line (after smart-point-adjustment activate)
  (setq disable-point-adjustment
        (or (not (invisible-p (point)))
            (not (invisible-p (max (point-min) (1- (point))))))))

Evgeni


On Sat, May 4, 2013 at 2:27 PM, E Sabof <esabof@gmail.com> wrote:

> Wouldn't it be better if forward/backward-char kept the old behavior, and
> the rest of the commands did something similar to this in the end:
>
> (setq disable-point-adjustment
>       (preceding-or-following-character-visible-p))
>
> I'm not entirely sure whether it would be better, but at the moment, I
> can't think of a case where it wouldn't.
>
> Evgeni
>
>
> On Sat, May 4, 2013 at 1:16 PM, Eli Zaretskii <eliz@gnu.org> wrote:
>
>> > Date: Sat, 4 May 2013 12:17:35 +0100
>> > From: E Sabof <esabof@gmail.com>
>> > Cc: 14346@debbugs.gnu.org
>> >
>> > I see what you mean. But it still looks like a bug - whether I follow
>> the
>> > above recipe, or press C-e C-a, the point will (should?) go to the same
>> > position, but the behavior is different.
>>
>> The behavior depends on the direction point was moving before ending
>> up in the invisible text.  It's a heuristic, and as every heuristic,
>> it sometimes fails.
>>
>
>

[-- Attachment #2: Type: text/html, Size: 2667 bytes --]

^ permalink raw reply	[flat|nested] 2+ messages in thread

* bug#14346: [O] bug#14346: 24.3; beginning-of-visual-line jumps to previous line in org-mode
  2013-05-07  1:34           ` bug#14346: 24.3; beginning-of-visual-line jumps to previous line in org-mode E Sabof
@ 2013-05-10  7:00             ` Carsten Dominik
  0 siblings, 0 replies; 2+ messages in thread
From: Carsten Dominik @ 2013-05-10  7:00 UTC (permalink / raw)
  To: E Sabof; +Cc: 14346, emacs-orgmode

[-- Attachment #1: Type: text/plain, Size: 1832 bytes --]


On 7.5.2013, at 03:34, E Sabof <esabof@gmail.com> wrote:

> Even if the behavior doesn't change (soon), could the equivalent of the following be implemented in org-mode? It's the only place where this has been problematic for me. 
> 
> (defadvice org-beginning-of-line (after smart-point-adjustment activate)
>   (setq disable-point-adjustment
>         (or (not (invisible-p (point)))
>             (not (invisible-p (max (point-min) (1- (point))))))))
> 
> (defadvice org-end-of-line (after smart-point-adjustment activate)
>   (setq disable-point-adjustment
>         (or (not (invisible-p (point)))
>             (not (invisible-p (max (point-min) (1- (point))))))))

I have implemented these in Org master, so this will eventually mode into emacs as well.

- Carsten

> 
> Evgeni
> 
> 
> On Sat, May 4, 2013 at 2:27 PM, E Sabof <esabof@gmail.com> wrote:
> Wouldn't it be better if forward/backward-char kept the old behavior, and the rest of the commands did something similar to this in the end:
> 
> (setq disable-point-adjustment
>       (preceding-or-following-character-visible-p))
> 
> I'm not entirely sure whether it would be better, but at the moment, I can't think of a case where it wouldn't.
> 
> Evgeni
> 
> 
> On Sat, May 4, 2013 at 1:16 PM, Eli Zaretskii <eliz@gnu.org> wrote:
> > Date: Sat, 4 May 2013 12:17:35 +0100
> > From: E Sabof <esabof@gmail.com>
> > Cc: 14346@debbugs.gnu.org
> >
> > I see what you mean. But it still looks like a bug - whether I follow the
> > above recipe, or press C-e C-a, the point will (should?) go to the same
> > position, but the behavior is different.
> 
> The behavior depends on the direction point was moving before ending
> up in the invisible text.  It's a heuristic, and as every heuristic,
> it sometimes fails.
> 
> 


[-- Attachment #2: Type: text/html, Size: 3378 bytes --]

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2013-05-10  7:00 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <CAEp6DyajAEW63CFd8U6qLQM6kkayGOaxtvA0OFRKMuBYSLQw1g@mail.gmail.com>
     [not found] ` <8338u3m2ke.fsf@gnu.org>
     [not found]   ` <831u9nm2dm.fsf@gnu.org>
     [not found]     ` <CAEp6Dybi3z-wAN6gYBSDREsWsdzdhk8iEwRD+H1t4FWqdms_WA@mail.gmail.com>
     [not found]       ` <83y5bvkki7.fsf@gnu.org>
     [not found]         ` <CAEp6DyaP8N21FCxSX6tos1Cco9kCoQhK05BJM49V4qz6A406JA@mail.gmail.com>
2013-05-07  1:34           ` bug#14346: 24.3; beginning-of-visual-line jumps to previous line in org-mode E Sabof
2013-05-10  7:00             ` bug#14346: [O] " Carsten Dominik

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).