From mboxrd@z Thu Jan 1 00:00:00 1970 From: Carlos Pita Subject: Re: Bug: Latex preview fg color w/tikz (known problem, fix suggested) [9.1.9 (release_9.1.9-65-g5e4542 @ /home/carlos/local/stow/emacs-26/share/emacs/26.1.90/lisp/org/)] Date: Wed, 2 Jan 2019 19:12:51 -0300 Message-ID: References: <878t13n5qo.fsf@gmail.com> <87d0qfa6j7.fsf@nicolasgoaziou.fr> <87o99wfije.fsf@nicolasgoaziou.fr> <87mupg3wqt.fsf@gmail.com> <87sgybumgt.fsf@nicolasgoaziou.fr> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="0000000000001f8e7f057e80f37a" Return-path: Received: from eggs.gnu.org ([208.118.235.92]:49915) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1geol7-00043s-M7 for emacs-orgmode@gnu.org; Wed, 02 Jan 2019 17:13:06 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1geol6-0006sX-Ja for emacs-orgmode@gnu.org; Wed, 02 Jan 2019 17:13:05 -0500 Received: from mail-yb1-xb35.google.com ([2607:f8b0:4864:20::b35]:41542) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1geol6-0006rg-BS for emacs-orgmode@gnu.org; Wed, 02 Jan 2019 17:13:04 -0500 Received: by mail-yb1-xb35.google.com with SMTP id j10so9700060ybj.8 for ; Wed, 02 Jan 2019 14:13:04 -0800 (PST) In-Reply-To: <87sgybumgt.fsf@nicolasgoaziou.fr> List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: "Emacs-orgmode" To: Carlos Pita , emacs-orgmode@gnu.org --0000000000001f8e7f057e80f37a Content-Type: text/plain; charset="UTF-8" Here is a patch. It removes quite a few LOC. > I think option 3 is better. Is there any use case left for :use-xcolor? Every other previewer has :use-xcolor t. I assume it's safe to simply ignore :use-xcolor if it's there except that some user has configured a converter that for some reason requires the color command line args, in which case he will get an error (because of the color placeholders left untouched in the command line template). > Thank you for taking care of this. Well, thank you for taking care of everything else ;) Best regards -- Carlos --0000000000001f8e7f057e80f37a Content-Type: text/x-patch; charset="US-ASCII"; name="0001-Use-xcolor-for-all-latex-preview-converters.patch" Content-Disposition: attachment; filename="0001-Use-xcolor-for-all-latex-preview-converters.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_jqfqla2j0 RnJvbSA5YmVkYTc4NWU2MGM3OTFiYzY1MjRiOTk2YjYwZTlkYjAwZjg1OGI3IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBtZW1lcGxleCA8Y2FybG9zam9zZXBpdGFAZ21haWwuY29tPgpE YXRlOiBXZWQsIDIgSmFuIDIwMTkgMTk6MDU6MjYgLTAzMDAKU3ViamVjdDogW1BBVENIXSBVc2Ug eGNvbG9yIGZvciBhbGwgbGF0ZXggcHJldmlldyBjb252ZXJ0ZXJzCgotLS0KIGxpc3Avb3JnLmVs IHwgNjMgKysrKysrKysrKysrKysrKy0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0KIDEgZmlsZSBjaGFuZ2VkLCAxOSBpbnNlcnRpb25zKCspLCA0NCBkZWxldGlvbnMoLSkKCmRp ZmYgLS1naXQgYS9saXNwL29yZy5lbCBiL2xpc3Avb3JnLmVsCmluZGV4IDBlNTQxY2QuLjJlNjNh NjUgMTAwNjQ0Ci0tLSBhL2xpc3Avb3JnLmVsCisrKyBiL2xpc3Avb3JnLmVsCkBAIC0zODEzLDEy ICszODEzLDExIEBAIEFsbCBhdmFpbGFibGUgcHJvY2Vzc2VzIGFuZCB0aGVpcnMgZG9jdW1lbnRz IGNhbiBiZSBmb3VuZCBpbgogICAgICA6aW1hZ2Utb3V0cHV0LXR5cGUgInBuZyIKICAgICAgOmlt YWdlLXNpemUtYWRqdXN0ICgxLjAgLiAxLjApCiAgICAgIDpsYXRleC1jb21waWxlciAoImxhdGV4 IC1pbnRlcmFjdGlvbiBub25zdG9wbW9kZSAtb3V0cHV0LWRpcmVjdG9yeSAlbyAlZiIpCi0gICAg IDppbWFnZS1jb252ZXJ0ZXIgKCJkdmlwbmcgLWZnICVGIC1iZyAlQiAtRCAlRCAtVCB0aWdodCAt byAlTyAlZiIpKQorICAgICA6aW1hZ2UtY29udmVydGVyICgiZHZpcG5nIC1EICVEIC1UIHRpZ2h0 IC1vICVPICVmIikpCiAgICAgKGR2aXN2Z20KICAgICAgOnByb2dyYW1zICgibGF0ZXgiICJkdmlz dmdtIikKICAgICAgOmRlc2NyaXB0aW9uICJkdmkgPiBzdmciCiAgICAgIDptZXNzYWdlICJ5b3Ug bmVlZCB0byBpbnN0YWxsIHRoZSBwcm9ncmFtczogbGF0ZXggYW5kIGR2aXN2Z20uIgotICAgICA6 dXNlLXhjb2xvciB0CiAgICAgIDppbWFnZS1pbnB1dC10eXBlICJkdmkiCiAgICAgIDppbWFnZS1v dXRwdXQtdHlwZSAic3ZnIgogICAgICA6aW1hZ2Utc2l6ZS1hZGp1c3QgKDEuNyAuIDEuNSkKQEAg LTM4MjgsNyArMzgyNyw2IEBAIEFsbCBhdmFpbGFibGUgcHJvY2Vzc2VzIGFuZCB0aGVpcnMgZG9j dW1lbnRzIGNhbiBiZSBmb3VuZCBpbgogICAgICA6cHJvZ3JhbXMgKCJsYXRleCIgImNvbnZlcnQi KQogICAgICA6ZGVzY3JpcHRpb24gInBkZiA+IHBuZyIKICAgICAgOm1lc3NhZ2UgInlvdSBuZWVk IHRvIGluc3RhbGwgdGhlIHByb2dyYW1zOiBsYXRleCBhbmQgaW1hZ2VtYWdpY2suIgotICAgICA6 dXNlLXhjb2xvciB0CiAgICAgIDppbWFnZS1pbnB1dC10eXBlICJwZGYiCiAgICAgIDppbWFnZS1v dXRwdXQtdHlwZSAicG5nIgogICAgICA6aW1hZ2Utc2l6ZS1hZGp1c3QgKDEuMCAuIDEuMCkKQEAg LTM4NDgsMTEgKzM4NDYsNiBAQCBQUk9QRVJUSUVTIGFjY2VwdHMgdGhlIGZvbGxvd2luZyBhdHRy aWJ1dGVzOgogICA6bWVzc2FnZSAgICAgICAgICAgIHN0cmluZywgbWVzc2FnZSBpdCB3aGVuIHJl cXVpcmVkIHByb2dyYW1zIGNhbm5vdCBiZSBmb3VuZC4KICAgOmltYWdlLWlucHV0LXR5cGUgICBz dHJpbmcsIGlucHV0IGZpbGUgdHlwZSBvZiBpbWFnZSBjb252ZXJ0ZXIgKGUuZy4sIFwiZHZpXCIp LgogICA6aW1hZ2Utb3V0cHV0LXR5cGUgIHN0cmluZywgb3V0cHV0IGZpbGUgdHlwZSBvZiBpbWFn ZSBjb252ZXJ0ZXIgKGUuZy4sIFwicG5nXCIpLgotICA6dXNlLXhjb2xvciAgICAgICAgIGJvb2xl YW4sIHdoZW4gbm9uLW5pbCwgTGFUZVggXCJ4Y29sb3JcIiBtYWNybyBpcyB1c2VkIHRvCi0gICAg ICAgICAgICAgICAgICAgICAgZGVhbCB3aXRoIGJhY2tncm91bmQgYW5kIGZvcmVncm91bmQgY29s b3Igb2YgaW1hZ2UuCi0gICAgICAgICAgICAgICAgICAgICAgT3RoZXJ3aXNlLCBkdmlwbmcgc3R5 bGUgYmFja2dyb3VuZCBhbmQgZm9yZWdyb3VuZCBjb2xvcgotICAgICAgICAgICAgICAgICAgICAg IGZvcm1hdCBhcmUgZ2VuZXJhdGVkLiAgWW91IG1heSB0aGVuIHJlZmVyIHRvIHRoZW0gaW4KLSAg ICAgICAgICAgICAgICAgICAgICBjb21tYW5kIG9wdGlvbnMgd2l0aCBcIiVGXCIgYW5kIFwiJUJc Ii4KICAgOmltYWdlLXNpemUtYWRqdXN0ICBjb25zIG9mIG51bWJlcnMsIHRoZSBjYXIgZWxlbWVu dCBpcyB1c2VkIHRvIGFkanVzdCBMYVRlWAogICAgICAgICAgICAgICAgICAgICAgIGltYWdlIHNp emUgc2hvd2VkIGluIGJ1ZmZlciBhbmQgdGhlIGNkciBlbGVtZW50IGlzIGZvcgogICAgICAgICAg ICAgICAgICAgICAgIEhUTUwgZmlsZS4gIFRoaXMgb3B0aW9uIGlzIG9ubHkgdXNlZnVsIGZvciBw cm9jZXNzCkBAIC0zODg0LDggKzM4NzcsNiBAQCBQbGFjZS1ob2xkZXJzIHVzZWQgYnkgYDppbWFn ZS1jb252ZXJ0ZXInIGFuZCBgOmxhdGV4LWNvbXBpbGVyJzoKIAogUGxhY2UtaG9sZGVycyBvbmx5 IHVzZWQgYnkgYDppbWFnZS1jb252ZXJ0ZXInOgogCi0gICVGICAgIGZvcmVncm91bmQgb2YgaW1h Z2UKLSAgJUIgICAgYmFja2dyb3VuZCBvZiBpbWFnZQogICAlRCAgICBkcGksIHdoaWNoIGlzIHVz ZWQgdG8gYWRqdXN0IGltYWdlIHNpemUgYnkgc29tZSBwcm9jZXNzaW5nIGNvbW1hbmRzLgogICAl UyAgICB0aGUgaW1hZ2Ugc2l6ZSBzY2FsZSByYXRpbywgd2hpY2ggaXMgdXNlZCB0byBhZGp1c3Qg aW1hZ2Ugc2l6ZSBieSBzb21lCiAgICAgICAgIHByb2Nlc3NpbmcgY29tbWFuZHMuIgpAQCAtMTgz MzksNyArMTgzMzAsNiBAQCBhIEhUTUwgZmlsZS4iCiAJICAoY2RyIChhc3NxIHByb2Nlc3Npbmct dHlwZSBvcmctcHJldmlldy1sYXRleC1wcm9jZXNzLWFsaXN0KSkpCiAJIChwcm9ncmFtcyAocGxp c3QtZ2V0IHByb2Nlc3NpbmctaW5mbyA6cHJvZ3JhbXMpKQogCSAoZXJyb3ItbWVzc2FnZSAob3Ig KHBsaXN0LWdldCBwcm9jZXNzaW5nLWluZm8gOm1lc3NhZ2UpICIiKSkKLQkgKHVzZS14Y29sb3Ig KHBsaXN0LWdldCBwcm9jZXNzaW5nLWluZm8gOnVzZS14Y29sb3IpKQogCSAoaW1hZ2UtaW5wdXQt dHlwZSAocGxpc3QtZ2V0IHByb2Nlc3NpbmctaW5mbyA6aW1hZ2UtaW5wdXQtdHlwZSkpCiAJIChp bWFnZS1vdXRwdXQtdHlwZSAocGxpc3QtZ2V0IHByb2Nlc3NpbmctaW5mbyA6aW1hZ2Utb3V0cHV0 LXR5cGUpKQogCSAocG9zdC1jbGVhbiAob3IgKHBsaXN0LWdldCBwcm9jZXNzaW5nLWluZm8gOnBv c3QtY2xlYW4pCkBAIC0xODM3MCwzNiArMTgzNjAsMjMgQEAgYSBIVE1MIGZpbGUuIgogCSAocmVz aXplLW1pbmktd2luZG93cyBuaWwpKSA7Rml4IEVtYWNzIGZsaWNrZXIgd2hlbiBjcmVhdGluZyBp bWFnZS4KICAgICAoZG9saXN0IChwcm9ncmFtIHByb2dyYW1zKQogICAgICAgKG9yZy1jaGVjay1l eHRlcm5hbC1jb21tYW5kIHByb2dyYW0gZXJyb3ItbWVzc2FnZSkpCi0gICAgKGlmIHVzZS14Y29s b3IKLQkocHJvZ24gKGlmIChlcSBmZyAnZGVmYXVsdCkKLQkJICAgKHNldHEgZmcgKG9yZy1sYXRl eC1jb2xvciA6Zm9yZWdyb3VuZCkpCi0JCSAoc2V0cSBmZyAob3JnLWxhdGV4LWNvbG9yLWZvcm1h dCBmZykpKQotCSAgICAgICAoaWYgKGVxIGJnICdkZWZhdWx0KQotCQkgICAoc2V0cSBiZyAob3Jn LWxhdGV4LWNvbG9yIDpiYWNrZ3JvdW5kKSkKLQkJIChzZXRxIGJnIChvcmctbGF0ZXgtY29sb3It Zm9ybWF0Ci0JCQkgICAoaWYgKHN0cmluZz0gYmcgIlRyYW5zcGFyZW50IikgIndoaXRlIiBiZykp KSkKLQkgICAgICAgKHdpdGgtdGVtcC1maWxlIHRleGZpbGUKLQkJIChpbnNlcnQgbGF0ZXgtaGVh ZGVyKQotCQkgKGluc2VydCAiXG5cXGJlZ2lue2RvY3VtZW50fVxuIgotCQkJICJcXGRlZmluZWNv bG9ye2ZnfXtyZ2J9eyIgZmcgIn1cbiIKLQkJCSAiXFxkZWZpbmVjb2xvcntiZ317cmdifXsiIGJn ICJ9XG4iCi0JCQkgIlxuXFxwYWdlY29sb3J7Ymd9XG4iCi0JCQkgIlxue1xcY29sb3J7Zmd9XG4i Ci0JCQkgc3RyaW5nCi0JCQkgIlxufVxuIgotCQkJICJcblxcZW5ke2RvY3VtZW50fVxuIikpKQot ICAgICAgKGlmIChlcSBmZyAnZGVmYXVsdCkKLQkgIChzZXRxIGZnIChvcmctZHZpcG5nLWNvbG9y IDpmb3JlZ3JvdW5kKSkKLQkodW5sZXNzIChzdHJpbmc9IGZnICJUcmFuc3BhcmVudCIpCi0JICAo c2V0cSBmZyAob3JnLWR2aXBuZy1jb2xvci1mb3JtYXQgZmcpKSkpCi0gICAgICAoaWYgKGVxIGJn ICdkZWZhdWx0KQotCSAgKHNldHEgYmcgKG9yZy1kdmlwbmctY29sb3IgOmJhY2tncm91bmQpKQot CSh1bmxlc3MgKHN0cmluZz0gYmcgIlRyYW5zcGFyZW50IikKLQkgIChzZXRxIGJnIChvcmctZHZp cG5nLWNvbG9yLWZvcm1hdCBiZykpKSkKLSAgICAgICh3aXRoLXRlbXAtZmlsZSB0ZXhmaWxlCi0J KGluc2VydCBsYXRleC1oZWFkZXIpCi0JKGluc2VydCAiXG5cXGJlZ2lue2RvY3VtZW50fVxuIiBz dHJpbmcgIlxuXFxlbmR7ZG9jdW1lbnR9XG4iKSkpCi0KKyAgICAoaWYgKGVxIGZnICdkZWZhdWx0 KQorCShzZXRxIGZnIChvcmctbGF0ZXgtY29sb3IgOmZvcmVncm91bmQpKQorICAgICAgKHNldHEg ZmcgKG9yZy1sYXRleC1jb2xvci1mb3JtYXQgZmcpKSkKKyAgICAoaWYgKGVxIGJnICdkZWZhdWx0 KQorCShzZXRxIGJnIChvcmctbGF0ZXgtY29sb3IgOmJhY2tncm91bmQpKQorICAgICAgKHNldHEg YmcgKG9yZy1sYXRleC1jb2xvci1mb3JtYXQKKwkJKGlmIChzdHJpbmc9IGJnICJUcmFuc3BhcmVu dCIpICJ3aGl0ZSIgYmcpKSkpCisgICAgKHdpdGgtdGVtcC1maWxlIHRleGZpbGUKKyAgICAgIChp bnNlcnQgbGF0ZXgtaGVhZGVyKQorICAgICAgKGluc2VydCAiXG5cXGJlZ2lue2RvY3VtZW50fVxu IgorCSAgICAgICJcXGRlZmluZWNvbG9ye2ZnfXtyZ2J9eyIgZmcgIn1cbiIKKwkgICAgICAiXFxk ZWZpbmVjb2xvcntiZ317cmdifXsiIGJnICJ9XG4iCisJICAgICAgIlxuXFxwYWdlY29sb3J7Ymd9 XG4iCisJICAgICAgIlxue1xcY29sb3J7Zmd9XG4iCisJICAgICAgc3RyaW5nCisJICAgICAgIlxu fVxuIgorCSAgICAgICJcblxcZW5ke2RvY3VtZW50fVxuIikpCiAgICAgKGxldCogKChlcnItbXNn IChmb3JtYXQgIlBsZWFzZSBhZGp1c3QgYCVzJyBwYXJ0IG9mIFwKIGBvcmctcHJldmlldy1sYXRl eC1wcm9jZXNzLWFsaXN0Jy4iCiAJCQkgICAgcHJvY2Vzc2luZy10eXBlKSkKQEAgLTE4NDA5LDkg KzE4Mzg2LDcgQEAgYSBIVE1MIGZpbGUuIgogCSAgIChpbWFnZS1vdXRwdXQtZmlsZQogCSAgICAo b3JnLWNvbXBpbGUtZmlsZQogCSAgICAgaW1hZ2UtaW5wdXQtZmlsZSBpbWFnZS1jb252ZXJ0ZXIg aW1hZ2Utb3V0cHV0LXR5cGUgZXJyLW1zZyBsb2ctYnVmCi0JICAgICBgKCg/RiAuICwoc2hlbGwt cXVvdGUtYXJndW1lbnQgZmcpKQotCSAgICAgICAoP0IgLiAsKHNoZWxsLXF1b3RlLWFyZ3VtZW50 IGJnKSkKLQkgICAgICAgKD9EIC4gLChzaGVsbC1xdW90ZS1hcmd1bWVudCAoZm9ybWF0ICIlcyIg ZHBpKSkpCisJICAgICBgKCg/RCAuICwoc2hlbGwtcXVvdGUtYXJndW1lbnQgKGZvcm1hdCAiJXMi IGRwaSkpKQogCSAgICAgICAoP1MgLiAsKHNoZWxsLXF1b3RlLWFyZ3VtZW50IChmb3JtYXQgIiVz IiAoLyBkcGkgMTQwLjApKSkpKSkpKQogICAgICAgKGNvcHktZmlsZSBpbWFnZS1vdXRwdXQtZmls ZSB0b2ZpbGUgJ3JlcGxhY2UpCiAgICAgICAoZG9saXN0IChlIHBvc3QtY2xlYW4pCi0tIAoyLjE5 LjIKCg== --0000000000001f8e7f057e80f37a--