From mboxrd@z Thu Jan 1 00:00:00 1970 From: Carlos Pita Subject: Re: Bug: Bad alignment of grouped tags in fast selection dialog [9.2.1 (release_9.2.1-60-gb0379f @ /home/carlos/local/stow/emacs/share/emacs/site-lisp/org/)] Date: Tue, 12 Feb 2019 18:24:05 -0300 Message-ID: References: <87bm3gepff.fsf@gmail.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="0000000000004fe4ca0581b90c56" Return-path: Received: from eggs.gnu.org ([209.51.188.92]:35474) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gtfXb-0006jA-4D for emacs-orgmode@gnu.org; Tue, 12 Feb 2019 16:24:31 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gtfXX-00078E-Ai for emacs-orgmode@gnu.org; Tue, 12 Feb 2019 16:24:29 -0500 Received: from mail-yw1-xc36.google.com ([2607:f8b0:4864:20::c36]:40828) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gtfXT-00074Y-0Q for emacs-orgmode@gnu.org; Tue, 12 Feb 2019 16:24:25 -0500 Received: by mail-yw1-xc36.google.com with SMTP id c67so65917ywa.7 for ; Tue, 12 Feb 2019 13:24:20 -0800 (PST) In-Reply-To: List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: "Emacs-orgmode" To: emacs-orgmode --0000000000004fe4ca0581b90c56 Content-Type: text/plain; charset="UTF-8" Not a big deal, but here is a slightly better fix that avoids adding some spaces before the closing }. The difference wrt to the previous one is just: - (unless (memq (caar tbl) '(:endgroup :endgrouptag)) (insert "\n")) - (when (or ingroup intaggroup) (insert " ")) + (unless (memq (caar tbl) '(:endgroup :endgrouptag)) + (insert "\n") + (when (or ingroup intaggroup) (insert " "))) That is, the when clause is inside the unless clause. --0000000000004fe4ca0581b90c56 Content-Type: text/x-patch; charset="US-ASCII"; name="0001-org-Fix-fast-tag-selection-menu-alignment.patch" Content-Disposition: attachment; filename="0001-org-Fix-fast-tag-selection-menu-alignment.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_js29xngu0 RnJvbSA0OTc3NTg0N2Y2ZGI3MjlkZmI3MjZhYzA5OGNjODAzOWZjZWI5MzQ2IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBtZW1lcGxleCA8Y2FybG9zam9zZXBpdGFAZ21haWwuY29tPgpE YXRlOiBUdWUsIDEyIEZlYiAyMDE5IDE3OjQ5OjQwIC0wMzAwClN1YmplY3Q6IFtQQVRDSF0gb3Jn OiBGaXggZmFzdCB0YWcgc2VsZWN0aW9uIG1lbnUgYWxpZ25tZW50CgoqIGxpc3Avb3JnLmVsIChv cmctZmFzdC10YWctc2VsZWN0aW9uKToKICAtIEF2b2lkIGxpbmVzIHdpdGgganVzdCBhIGNsb3Np bmcgZGVsaW1pdGVyLgogIC0gQ29ycmVjdGx5IGFsaWduIGdyb3VwZWQgYW5kIHVuZ3JvdXBlZCB0 YWdzLgotLS0KIGxpc3Avb3JnLmVsIHwgNyArKysrLS0tCiAxIGZpbGUgY2hhbmdlZCwgNCBpbnNl cnRpb25zKCspLCAzIGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL2xpc3Avb3JnLmVsIGIvbGlz cC9vcmcuZWwKaW5kZXggZTIyNTg3NDliLi4wMDMwNTg0MzQgMTAwNjQ0Ci0tLSBhL2xpc3Avb3Jn LmVsCisrKyBiL2xpc3Avb3JnLmVsCkBAIC0xNDUwMiwxMyArMTQ1MDIsMTQgQEAgUmV0dXJucyB0 aGUgbmV3IHRhZ3Mgc3RyaW5nLCBvciBuaWwgdG8gbm90IGNoYW5nZSB0aGUgY3VycmVudCBzZXR0 aW5ncy4iCiAJICAJCQkgICAoKG1lbWJlciB0ZyBpbmhlcml0ZWQpIGktZmFjZSkpKSkKIAkgICh3 aGVuIChlcXVhbCAoY2FhciB0YmwpIDpncm91cHRhZ3MpCiAJICAgIChvcmctYWRkLXByb3BzIHRn IG5pbCAnZmFjZSAnb3JnLXRhZy1ncm91cCkpCi0JICAod2hlbiAoYW5kICh6ZXJvcCBjbnQpIChu b3QgaW5ncm91cCkgKG5vdCBpbnRhZ2dyb3VwKSkgKGluc2VydCAiICIpKQorCSAgKHdoZW4gKGFu ZCAoemVyb3AgY250KSAobm90IGluZ3JvdXApIChub3QgaW50YWdncm91cCkpIChpbnNlcnQgIiAg IikpCiAJICAoaW5zZXJ0ICJbIiBjICJdICIgdGcgKG1ha2Utc3RyaW5nCiAJCQkJICgtIGZ3aWR0 aCA0IChsZW5ndGggdGcpKSA/XCApKQogCSAgKHB1c2ggKGNvbnMgdGcgYykgbnRhYmxlKQogCSAg KHdoZW4gKD0gKGNsLWluY2YgY250KSBuY29sKQotCSAgICAoaW5zZXJ0ICJcbiIpCi0JICAgICh3 aGVuIChvciBpbmdyb3VwIGludGFnZ3JvdXApIChpbnNlcnQgIiAiKSkKKwkgICAgKHVubGVzcyAo bWVtcSAoY2FhciB0YmwpICcoOmVuZGdyb3VwIDplbmRncm91cHRhZykpCisJICAgICAgKGluc2Vy dCAiXG4iKQorCSAgICAgICh3aGVuIChvciBpbmdyb3VwIGludGFnZ3JvdXApIChpbnNlcnQgIiAg IikpKQogCSAgICAoc2V0cSBjbnQgMCkpKSkpCiAgICAgICAoc2V0cSBudGFibGUgKG5yZXZlcnNl IG50YWJsZSkpCiAgICAgICAoaW5zZXJ0ICJcbiIpCi0tIAoyLjIwLjEKCg== --0000000000004fe4ca0581b90c56--