emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: dmg <dmg@uvic.ca>
To: emacs-orgmode <emacs-orgmode@gnu.org>
Cc: eschulte@cs.unm.edu
Subject: Re: babel and postgresql
Date: Sat, 23 Feb 2013 23:13:09 -0800	[thread overview]
Message-ID: <CAEBXXD9uWOkS207=DRqS4K9HEzJZV8akMeQNDnJ1aLdaOP7jUw@mail.gmail.com> (raw)
In-Reply-To: <CAEBXXD-jFrMwX4f-2Tk7rJx4gyeE0F4P2UBq0u+ZN_PMLCFbUA@mail.gmail.com>

It looks like my inexperience with Lisp made me ignore the obvious.
What is needed is not my patch below, but to add posgresql to the
condition of the case:

From:
	(case (intern engine)
	  ('mysql


To:

	(case (intern engine)
	  ('(postgresql mysql)

the problem is that I can't get it to work (and I could not find good
documentation for the case macro anywhere but its definition. It says
that it takes either an atom (i.e. 'mysql)
or a list (i.e. '(postgresql mysql) ) but it just does not work me.

But the code for mysql and postgres seems to be the same.

Sorry for the confusion.

--daniel

On Sat, Feb 23, 2013 at 10:42 PM, dmg <dmg@uvic.ca> wrote:
> Hi everybody, Eric,
>
> I have been starting using Babel with postgresql, R and perl, and I am
> loving it. I really want to thank everybody for their work.
>
> I have found one particular issue that bothers me.
>
> Say I have the following babel section:
>
> #+name: abc
> #+begin_src sql :engine postgresql :cmdline mydb
> select * from aliases limit 1;
> #+end_src
>
> the output is:
>
> #+name: abc
> | alias                     | uniname      |
> | Jon <tixy@xyz.org>        | jon          |
>
> Note how the column names are not separated from the body:
>
> What I want it this:
>
> #+name:
> | alias                     | uniname      |
> |---------------------------+--------------|
> | Jon <tixy@xyz.org>        | jon          |
>
> I have tracked the problem, and it is that in ob-sql.el the code of
> org-babel-execute:sql thinks that postgres will return a header separator,
> and it does not.
>
> I am not sure what is the best way to fix it, but I have come with a
> patch that does it (but replaced the older code). The code in
> org-babel-execute:sql
> needs to be modified so it does this only for the postgres backend:
> split the list into first member and rest and insert a 'hline in
> between. My solution is rough, but it works (sorry, I am just an elisp beginner)
>
>
> diff --git a/lisp/ob-sql.el b/lisp/ob-sql.el
> index 3586ec9..95cac85 100644
> --- a/lisp/ob-sql.el
> +++ b/lisp/ob-sql.el
> @@ -170,11 +170,12 @@ This function is called by `org-babel-execute-src-block'."
>           )
>         (org-table-import out-file '(16))
>         (org-babel-reassemble-table
> -        (mapcar (lambda (x)
> -                  (if (string= (car x) header-delim)
> -                      'hline
> -                    x))
> -                (org-table-to-lisp))
> +        (funcall (lambda (x)
> +                   (cons (car-safe x)
> +                         (cons 'hline (cdr-safe x))
> +                         )
> +                   )
> +               (org-table-to-lisp))
>          (org-babel-pick-name (cdr (assoc :colname-names params))
>                               (cdr (assoc :colnames params)))
>          (org-babel-pick-name (cdr (assoc :rowname-names params))
>
>
>
> --
> --dmg
>
> ---
> Daniel M. German
> http://turingmachine.org



-- 
--dmg

---
Daniel M. German
http://turingmachine.org

  reply	other threads:[~2013-02-24  7:14 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-02-24  6:42 babel and postgresql dmg
2013-02-24  7:13 ` dmg [this message]
2013-02-24  8:15   ` Bastien

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAEBXXD9uWOkS207=DRqS4K9HEzJZV8akMeQNDnJ1aLdaOP7jUw@mail.gmail.com' \
    --to=dmg@uvic.ca \
    --cc=emacs-orgmode@gnu.org \
    --cc=eschulte@cs.unm.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).