From mboxrd@z Thu Jan 1 00:00:00 1970 From: Leo Alekseyev Subject: Re: bug / regression: C-x C-s is broken in org-edit-special Date: Mon, 13 Feb 2012 04:54:38 -0500 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([140.186.70.92]:35625) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RwscO-0001PE-4O for emacs-orgmode@gnu.org; Mon, 13 Feb 2012 04:54:45 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RwscJ-0003Xj-KM for emacs-orgmode@gnu.org; Mon, 13 Feb 2012 04:54:43 -0500 Received: from mail-pw0-f41.google.com ([209.85.160.41]:54655) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RwscJ-0003Xd-Ax for emacs-orgmode@gnu.org; Mon, 13 Feb 2012 04:54:39 -0500 Received: by pbcwz17 with SMTP id wz17so4670691pbc.0 for ; Mon, 13 Feb 2012 01:54:38 -0800 (PST) In-Reply-To: List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Emacs orgmode In case anyone is curious, C-x C-s functionality in org-edit-special can be easily restored via (define-key org-src-mode-map "\C-x\C-s" 'org-edit-src-save) On Thu, Feb 9, 2012 at 4:49 PM, Leo Alekseyev wrote: > Previously, C-x C-s in an org-edit-special buffer (invoked via C-') > would save the underlying org buffer (provided (setq > org-src-window-setup (quote current-window)) was set; it was buggy > with other settings, see > http://thread.gmane.org/gmane.emacs.orgmode/50979 for discussion). > Currently, C-x C-s prompts to save the temporary source edit buffer in > a new file, which is almost certainly not what the user intends. =A0I > hope someone can look into this, C-x C-s shouldn't be broken in any > context. > > This broke some time between commit > fc93b6f34071703d5a154a51540f3f4e3f15b8a2 (Jan. 18) and this week, > _possibly_ as a result of the change ensuring that buffer-file-name is > nil in temporary org-src buffers. =A0Buffer-file-name not being nil in a > temp buffer is incorrect behavior, but in this context having C-x C-s > not working is a much worse behavior, so perhaps that change ought to > be reverted if it's the culprit. > > --Leo