emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
* [BUG] org, ispell [9.6.6 (release_9.6.6 @  /Applications/Emacs.app/Contents/Resources/lisp/org/)]
@ 2023-10-29 14:16 Kai Jenkins
  2023-11-05 11:58 ` Ihor Radchenko
  0 siblings, 1 reply; 4+ messages in thread
From: Kai Jenkins @ 2023-10-29 14:16 UTC (permalink / raw)
  To: emacs-orgmode



Remember to cover the basics, that is, what you expected to happen and
what in fact did happen.  You don't know how to make a good report?  See

     https://orgmode.org/manual/Feedback.html#Feedback

Your bug report will be posted to the Org mailing list.
------------------------------------------------------------------------

recipe to create bug:
- start emacs (via. emacs -Q)
- open a new org file
- create a heading (eg. * test)
- write some text under the heading that contains a spelling mistake
- fold the heading with tab
- run M-x ispell

the bug:
- ispell doesn't unfold the header that has the misspelled word (possible corrections
are shown in a ispell buffer so it is finding the incorrect word)
- when you exit ispell with C-g the heading is now stuck and will not unfold with tab
- in the buffer theres a message "SUBTREE (NO CHILDREN)"

Emacs  : GNU Emacs 29.1 (build 1, x86_64-apple-darwin18.7.0, NS appkit-1671.60 Version 10.14.6 (Build 18G9323))
of 2023-08-17
Package: Org mode version 9.6.6 (release_9.6.6 @ /Applications/Emacs.app/Contents/Resources/lisp/org/)


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [BUG] org, ispell [9.6.6 (release_9.6.6 @ /Applications/Emacs.app/Contents/Resources/lisp/org/)]
  2023-10-29 14:16 [BUG] org, ispell [9.6.6 (release_9.6.6 @ /Applications/Emacs.app/Contents/Resources/lisp/org/)] Kai Jenkins
@ 2023-11-05 11:58 ` Ihor Radchenko
  2024-05-02 11:36   ` Ihor Radchenko
  0 siblings, 1 reply; 4+ messages in thread
From: Ihor Radchenko @ 2023-11-05 11:58 UTC (permalink / raw)
  To: Kai Jenkins; +Cc: emacs-orgmode, 66790

Kai Jenkins <jenkinskair@gmail.com> writes:

> recipe to create bug:
> - starting emacs (via. emacs -Q)
> - open a new org file
> - create a heading (eg. * test)
> - write some text under the heading that contains a spelling mistake
> - fold the heading with tab
> - run M-x ispell
>
> the bug:
> - ispell doesnt unfold the header that has the bug (possible corrections
> are shown so it is finding the incorrect word)
> - when you exit ispell with C-g the heading is now stuck and will not unfold with tab
> - in the buffer theres a message "SUBTREE (NO CHILDREN)"

Confirmed.

At this point, I feel that supporting isearch + text properties is an
uphill battle. I was hoping to contribute isearch.el patch upstream, but
apparently numerous other libraries (ispell, regexp-search, evil,
swiper) are relying upon invisibility being handled in very specific
way, using overlays. Considering that using overlays is no longer slower
compared to text properties in Emacs 29+, I am thinking of slowly
switching back to using overlays for folding for newer Emacs versions.

For your problem, just add (setq org-fold-core-style 'overlays) early in
your config. It should fix the issue.

-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [BUG] org, ispell [9.6.6 (release_9.6.6 @ /Applications/Emacs.app/Contents/Resources/lisp/org/)]
  2023-11-05 11:58 ` Ihor Radchenko
@ 2024-05-02 11:36   ` Ihor Radchenko
  2024-05-20 20:16     ` bug#66790: " Stefan Kangas
  0 siblings, 1 reply; 4+ messages in thread
From: Ihor Radchenko @ 2024-05-02 11:36 UTC (permalink / raw)
  To: Kai Jenkins; +Cc: emacs-orgmode, 66790

Ihor Radchenko <yantar92@posteo.net> writes:

> Confirmed.
>
> At this point, I feel that supporting isearch + text properties is an
> uphill battle. I was hoping to contribute isearch.el patch upstream, but
> apparently numerous other libraries (ispell, regexp-search, evil,
> swiper) are relying upon invisibility being handled in very specific
> way, using overlays. Considering that using overlays is no longer slower
> compared to text properties in Emacs 29+, I am thinking of slowly
> switching back to using overlays for folding for newer Emacs versions.

Org mode development branch will have `org-fold-core-style' defaulting
to 'overlays now as long as Emacs version is recent enough to handle
overlays efficiently.

Handled.

-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: bug#66790: [BUG] org, ispell [9.6.6 (release_9.6.6 @ /Applications/Emacs.app/Contents/Resources/lisp/org/)]
  2024-05-02 11:36   ` Ihor Radchenko
@ 2024-05-20 20:16     ` Stefan Kangas
  0 siblings, 0 replies; 4+ messages in thread
From: Stefan Kangas @ 2024-05-20 20:16 UTC (permalink / raw)
  To: Ihor Radchenko, Kai Jenkins; +Cc: emacs-orgmode, 66790-done

Ihor Radchenko <yantar92@posteo.net> writes:

> Ihor Radchenko <yantar92@posteo.net> writes:
>
>> Confirmed.
>>
>> At this point, I feel that supporting isearch + text properties is an
>> uphill battle. I was hoping to contribute isearch.el patch upstream, but
>> apparently numerous other libraries (ispell, regexp-search, evil,
>> swiper) are relying upon invisibility being handled in very specific
>> way, using overlays. Considering that using overlays is no longer slower
>> compared to text properties in Emacs 29+, I am thinking of slowly
>> switching back to using overlays for folding for newer Emacs versions.
>
> Org mode development branch will have `org-fold-core-style' defaulting
> to 'overlays now as long as Emacs version is recent enough to handle
> overlays efficiently.
>
> Handled.

Thanks, I'm therefore closing this bug report.


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2024-05-20 20:17 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-10-29 14:16 [BUG] org, ispell [9.6.6 (release_9.6.6 @ /Applications/Emacs.app/Contents/Resources/lisp/org/)] Kai Jenkins
2023-11-05 11:58 ` Ihor Radchenko
2024-05-02 11:36   ` Ihor Radchenko
2024-05-20 20:16     ` bug#66790: " Stefan Kangas

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).