* Getting rid of org-install.el
@ 2022-06-28 16:35 Stefan Kangas
2022-06-29 2:15 ` Ihor Radchenko
2022-06-29 3:18 ` Kyle Meyer
0 siblings, 2 replies; 7+ messages in thread
From: Stefan Kangas @ 2022-06-28 16:35 UTC (permalink / raw)
To: Org-mode
[-- Attachment #1: Type: text/plain, Size: 592 bytes --]
org-install.el has been obsolete for more than 10 years.
To finally get rid of this file, I put it to you that all we need to do is:
1. Move it in emacs.git from lisp/org/org-install.el to
lisp/obsolete/org-install.el
2. Delete the file from org-mode.git
This means that all users (of old and new versions) will have a bundled
org-install.el so that requiring it still works, but on Emacs 29 or later
you will get the usual obsoletion warnings. The file would finally be
removed from emacs.git in another decade or so according to current Emacs
maintenance practices.
What do you think?
[-- Attachment #2: Type: text/html, Size: 740 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: Getting rid of org-install.el
2022-06-28 16:35 Getting rid of org-install.el Stefan Kangas
@ 2022-06-29 2:15 ` Ihor Radchenko
2022-06-29 3:40 ` Stefan Kangas
2022-06-29 3:18 ` Kyle Meyer
1 sibling, 1 reply; 7+ messages in thread
From: Ihor Radchenko @ 2022-06-29 2:15 UTC (permalink / raw)
To: Stefan Kangas; +Cc: Org-mode
Stefan Kangas <stefan@marxist.se> writes:
> org-install.el has been obsolete for more than 10 years.
> ...
> 2. Delete the file from org-mode.git
> ...
> What do you think?
Sounds good to me.
Best,
Ihor
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: Getting rid of org-install.el
2022-06-28 16:35 Getting rid of org-install.el Stefan Kangas
2022-06-29 2:15 ` Ihor Radchenko
@ 2022-06-29 3:18 ` Kyle Meyer
2022-06-29 12:33 ` Stefan Kangas
1 sibling, 1 reply; 7+ messages in thread
From: Kyle Meyer @ 2022-06-29 3:18 UTC (permalink / raw)
To: Stefan Kangas; +Cc: Org-mode, Ihor Radchenko
Stefan Kangas writes:
> org-install.el has been obsolete for more than 10 years.
>
> To finally get rid of this file, I put it to you that all we need to do is:
>
> 1. Move it in emacs.git from lisp/org/org-install.el to
> lisp/obsolete/org-install.el
> 2. Delete the file from org-mode.git
In my view it'd be better to drop the first item. Org has removed
plenty of obsolete features in its time, but searching the emacs.git
history, I can't find a case where an Org-related file has been in
lisp/obsolete/. I'd vote against setting that precedent, as I don't
want to introduce any more discrepancies between the Org files in
org-mode.git and emacs.git than necessary.
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: Getting rid of org-install.el
2022-06-29 3:18 ` Kyle Meyer
@ 2022-06-29 12:33 ` Stefan Kangas
2022-06-29 23:36 ` Kyle Meyer
0 siblings, 1 reply; 7+ messages in thread
From: Stefan Kangas @ 2022-06-29 12:33 UTC (permalink / raw)
To: Kyle Meyer; +Cc: Org-mode, Ihor Radchenko
Kyle Meyer <kyle@kyleam.com> writes:
> In my view it'd be better to drop the first item. Org has removed
> plenty of obsolete features in its time, but searching the emacs.git
> history, I can't find a case where an Org-related file has been in
> lisp/obsolete/. I'd vote against setting that precedent, as I don't
> want to introduce any more discrepancies between the Org files in
> org-mode.git and emacs.git than necessary.
Fine by me, though I don't think it's a very strong precedent; it
could be a one-off.
If we do it your way, does someone need to remember to delete the file
manually when the time comes to move the emacs.git master branch to
the latest Org release? Or will that be done automagically?
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: Getting rid of org-install.el
2022-06-29 12:33 ` Stefan Kangas
@ 2022-06-29 23:36 ` Kyle Meyer
0 siblings, 0 replies; 7+ messages in thread
From: Kyle Meyer @ 2022-06-29 23:36 UTC (permalink / raw)
To: Stefan Kangas; +Cc: Org-mode, Ihor Radchenko
Stefan Kangas writes:
> If we do it your way, does someone need to remember to delete the file
> manually when the time comes to move the emacs.git master branch to
> the latest Org release? Or will that be done automagically?
My script for syncing the Org tree to the Emacs's does
rm "$emacsrepo"/lisp/org/*.el
cp "$orgrepo"/lisp/*.el "$emacsrepo"/lisp/org/
so that deletions/renames on Org's side are propagated.
Those aren't too frequent, but of course still need to be accounted for:
$ git rev-parse HEAD
6dc785288d3514af4071f210dac0a18c14a6c45b
$ git log --since=2015 --format='%cs %s' --diff-filter=D --no-renames \
bugfix -- 'lisp/*.el'
2021-09-28 lisp/ob-stan.el: Delete
2021-09-26 Move some ob-*el files to the new org-contrib repo
2019-03-10 Prefix link-related libraries filenames with "ol"
2018-10-03 org-keys: Extract key bindings into their own library
2017-08-18 Remove ob-scala.el
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2022-06-29 23:37 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-06-28 16:35 Getting rid of org-install.el Stefan Kangas
2022-06-29 2:15 ` Ihor Radchenko
2022-06-29 3:40 ` Stefan Kangas
2022-06-29 12:29 ` Ihor Radchenko
2022-06-29 3:18 ` Kyle Meyer
2022-06-29 12:33 ` Stefan Kangas
2022-06-29 23:36 ` Kyle Meyer
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).