emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Stefan Kangas <stefan@marxist.se>
To: Org-mode <emacs-orgmode@gnu.org>
Subject: [PATCH] Make org-load-hook obsolete
Date: Fri, 7 May 2021 05:57:14 -0700	[thread overview]
Message-ID: <CADwFkm=Ec37gK-waoKcw9wAB1xz8_BbSpUUT++kDLjKOV9NpBw@mail.gmail.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 150 bytes --]

In Emacs, we have made all the `foo-load-hook' variables obsolete in
favor of `with-eval-after-load'.  The attached patch does the same for
org-mode.

[-- Attachment #2: 0001-Make-org-load-hook-obsolete.patch --]
[-- Type: text/x-diff, Size: 801 bytes --]

From dcf7bfa11a2d27ca9fd44d8fd11440e033b2c567 Mon Sep 17 00:00:00 2001
From: Stefan Kangas <stefan@marxist.se>
Date: Fri, 7 May 2021 14:50:48 +0200
Subject: [PATCH] Make org-load-hook obsolete

* lisp/org.el (org-load-hook): Make obsolete in favor of
with-eval-after-load.
---
 lisp/org.el | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/lisp/org.el b/lisp/org.el
index 675a614e2..39a44016e 100644
--- a/lisp/org.el
+++ b/lisp/org.el
@@ -653,6 +653,8 @@ defined in org-duration.el.")
   "Hook that is run after org.el has been loaded."
   :group 'org
   :type 'hook)
+(make-obsolete-variable 'org-load-hook
+                        "use `with-eval-after-load' instead." "Org 9.5")
 
 (defcustom org-log-buffer-setup-hook nil
   "Hook that is run after an Org log buffer is created."
-- 
2.30.2


             reply	other threads:[~2021-05-07 13:05 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-07 12:57 Stefan Kangas [this message]
2021-05-08  7:34 ` Bastien

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CADwFkm=Ec37gK-waoKcw9wAB1xz8_BbSpUUT++kDLjKOV9NpBw@mail.gmail.com' \
    --to=stefan@marxist.se \
    --cc=emacs-orgmode@gnu.org \
    --subject='Re: [PATCH] Make org-load-hook obsolete' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this inbox:

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).