From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?UTF-8?Q?Micha=C3=ABl_Cadilhac?= Subject: Re: [Patch] Hide the file column in a clock report. Date: Sat, 2 Sep 2017 10:14:50 +0100 Message-ID: References: <87shg5hmdf.fsf@alphapapa.net> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="f4030435bcd4b946820558315176" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:47905) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1do4Wi-0007Y2-5r for emacs-orgmode@gnu.org; Sat, 02 Sep 2017 05:15:45 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1do4Wd-00057o-52 for emacs-orgmode@gnu.org; Sat, 02 Sep 2017 05:15:40 -0400 Received: from cadilhac.name ([163.172.56.42]:44464) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1do4Wc-000552-Pt for emacs-orgmode@gnu.org; Sat, 02 Sep 2017 05:15:35 -0400 Received: from mail-ua0-f176.google.com (mail-ua0-f176.google.com [209.85.217.176]) by cadilhac.name (OpenSMTPD) with ESMTPSA id 5c6edd75 (TLSv1.2:ECDHE-RSA-AES128-GCM-SHA256:128:NO) for ; Sat, 2 Sep 2017 09:17:38 +0000 (UTC) Received: by mail-ua0-f176.google.com with SMTP id j46so5629027uag.5 for ; Sat, 02 Sep 2017 02:15:32 -0700 (PDT) In-Reply-To: <87shg5hmdf.fsf@alphapapa.net> List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: "Emacs-orgmode" To: Adam Porter Cc: emacs-orgmode@gnu.org --f4030435bcd4b946820558315176 Content-Type: text/plain; charset="UTF-8" On 2 September 2017 at 03:20, Adam Porter wrote: > One suggestion: > > +:hidefiles @r{Should the file column be hidden when multiple files are parsed?} > > It would be clearer if it said something like, "Hide file column when > multiple files are parsed." The other options mentioned there are > written like that, not as questions. :) While I definitely agree that question form is weird, I copied it from the ":level" option (arguably without thinking twice) which reads: :level @r{Should a level number column be included?} In any case, let's not repeat that oddity :-) I've changed the patch according to your suggestion. Cheers; M. --f4030435bcd4b946820558315176 Content-Type: text/x-patch; charset="US-ASCII"; name="0001-Add-the-option-of-hiding-the-file-column-in-a-clock-.patch" Content-Disposition: attachment; filename="0001-Add-the-option-of-hiding-the-file-column-in-a-clock-.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_j733dl1n0 RnJvbSBmMjUxYmYwZmE3NjRlMjQ1ZWFiZTg4ZTM5NTllODAxYWY1YzhmZDM3IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiA9P1VURi04P3E/TWljaGE9QzM9QUJsPTIwQ2FkaWxoYWM/PSA8 bWljaGFlbEBjYWRpbGhhYy5uYW1lPgpEYXRlOiBUaHUsIDMxIEF1ZyAyMDE3IDE5OjM3OjU1ICsw MTAwClN1YmplY3Q6IFtQQVRDSF0gQWRkIHRoZSBvcHRpb24gb2YgaGlkaW5nIHRoZSBmaWxlIGNv bHVtbiBpbiBhIGNsb2NrIHJlcG9ydAoKKiBjb250cmliL29yZ21hbnVhbC5vcmc6IERvY3VtZW50 IHRoZSBjaGFuZ2UuCiogZG9jL29yZy50ZXhpIChUaGUgY2xvY2sgdGFibGUpOiBEaXR0by4KKiBs aXNwL29yZy1jbG9jay5lbCAob3JnLWNsb2NrdGFibGUtZGVmYXVsdHMpOiBBZGQgZGVmYXVsdCB2 YWx1ZSBmb3IKICA6aGlkZWZpbGVzLgoob3JnLWRibG9jay13cml0ZTpjbG9ja3RhYmxlKTogRG8g bm90IG1ha2UgIm11bHRpbGluZSIgdHJ1ZSBpZgpoaWRlZmlsZXMgaXMuCiogbGlzcC9vcmctcGNv bXBsZXRlLmVsIChwY29tcGxldGUvb3JnLW1vZGUvYmxvY2stb3B0aW9uL2Nsb2NrdGFibGUpOgog IEFkZCA6aGlkZWZpbGVzIHRvIGNvbXBsZXRpb25zLgoKVElOWUNIQU5HRQotLS0KIGNvbnRyaWIv b3JnbWFudWFsLm9yZyB8IDQgKysrKwogZG9jL29yZy50ZXhpICAgICAgICAgIHwgMSArCiBsaXNw L29yZy1jbG9jay5lbCAgICAgfCA1ICsrKystCiBsaXNwL29yZy1wY29tcGxldGUuZWwgfCA1ICsr Ky0tCiA0IGZpbGVzIGNoYW5nZWQsIDEyIGluc2VydGlvbnMoKyksIDMgZGVsZXRpb25zKC0pCgpk aWZmIC0tZ2l0IGEvY29udHJpYi9vcmdtYW51YWwub3JnIGIvY29udHJpYi9vcmdtYW51YWwub3Jn CmluZGV4IDZjYzg4YTg2ZS4uZTE4NGZiNTFkIDEwMDY0NAotLS0gYS9jb250cmliL29yZ21hbnVh bC5vcmcKKysrIGIvY29udHJpYi9vcmdtYW51YWwub3JnCkBAIC02MjUzLDYgKzYyNTMsMTAgQEAg YnV0IHlvdSBjYW4gc3BlY2lmeSB5b3VyIG93biBmdW5jdGlvbiB1c2luZyB0aGUgfjpmb3JtYXR0 ZXJ+IHBhcmFtZXRlci4KIAogICBJbmRlbnQgZWFjaCBoZWFkbGluZSBmaWVsZCBhY2NvcmRpbmcg dG8gaXRzIGxldmVsLgogCistIDpoaWRlZmlsZXMgOjoKKworICBIaWRlIHRoZSBmaWxlIGNvbHVt biB3aGVuIG11bHRpcGxlIGZpbGVzIGFyZSB1c2VkIHRvIHByb2R1Y2VkIHRoZSB0YWJsZS4KKwog LSA6dGNvbHVtbnMgOjogICAKIAogICBOdW1iZXIgb2YgY29sdW1ucyB0byBiZSB1c2VkIGZvciB0 aW1lcy4gIElmIHRoaXMgaXMgc21hbGxlciB0aGFuCmRpZmYgLS1naXQgYS9kb2Mvb3JnLnRleGkg Yi9kb2Mvb3JnLnRleGkKaW5kZXggYTc0Zjk2N2Y1Li4yYzJmOGQwY2MgMTAwNjQ0Ci0tLSBhL2Rv Yy9vcmcudGV4aQorKysgYi9kb2Mvb3JnLnRleGkKQEAgLTY2ODksNiArNjY4OSw3IEBAIGJ1dCB5 b3UgY2FuIHNwZWNpZnkgeW91ciBvd24gZnVuY3Rpb24gdXNpbmcgdGhlIEBjb2Rlezpmb3JtYXR0 ZXJ9IHBhcmFtZXRlci4KICAgICAgICAgICAgICBAcnt0aGUgb3JnIHRhYmxlLiAgSWYgeW91IHdy aXRlIGl0IGxpa2UgQHNhbXB7NTAhfSwgdGhlbiB0aGV9CiAgICAgICAgICAgICAgQHJ7aGVhZGxp bmUgd2lsbCBhbHNvIGJlIHNob3J0ZW5lZCBpbiBleHBvcnQufQogOmluZGVudCAgICAgIEBye0lu ZGVudCBlYWNoIGhlYWRsaW5lIGZpZWxkIGFjY29yZGluZyB0byBpdHMgbGV2ZWwufQorOmhpZGVm aWxlcyAgIEBye0hpZGUgZmlsZSBjb2x1bW4gd2hlbiBtdWx0aXBsZSBmaWxlcyBhcmUgcGFyc2Vk Ln0KIDp0Y29sdW1ucyAgICBAcntOdW1iZXIgb2YgY29sdW1ucyB0byBiZSB1c2VkIGZvciB0aW1l cy4gIElmIHRoaXMgaXMgc21hbGxlcn0KICAgICAgICAgICAgICBAcnt0aGFuIEBjb2RlezptYXhs ZXZlbH0sIGxvd2VyIGxldmVscyB3aWxsIGJlIGx1bXBlZCBpbnRvIG9uZSBjb2x1bW4ufQogOmxl dmVsICAgICAgIEBye1Nob3VsZCBhIGxldmVsIG51bWJlciBjb2x1bW4gYmUgaW5jbHVkZWQ/fQpk aWZmIC0tZ2l0IGEvbGlzcC9vcmctY2xvY2suZWwgYi9saXNwL29yZy1jbG9jay5lbAppbmRleCA2 Yjk2N2M2NzMuLjA1YzQ2ZTE4YyAxMDA2NDQKLS0tIGEvbGlzcC9vcmctY2xvY2suZWwKKysrIGIv bGlzcC9vcmctY2xvY2suZWwKQEAgLTI5OCw2ICsyOTgsNyBAQCBzdHJpbmcgYXMgYXJndW1lbnQu IgogICAgOmxpbmsgbmlsCiAgICA6bmFycm93ICc0MCEKICAgIDppbmRlbnQgdAorICAgOmhpZGVm aWxlcyBuaWwKICAgIDpmb3JtdWxhIG5pbAogICAgOnRpbWVzdGFtcCBuaWwKICAgIDpsZXZlbCBu aWwKQEAgLTIzOTEsNiArMjM5Miw3IEBAIHRoZSBjdXJyZW50bHkgc2VsZWN0ZWQgaW50ZXJ2YWwg c2l6ZS4iCiAJICAgKHdzIChwbGlzdC1nZXQgcGFyYW1zIDp3c3RhcnQpKQogCSAgIChtcyAocGxp c3QtZ2V0IHBhcmFtcyA6bXN0YXJ0KSkKIAkgICAoc3RlcCAocGxpc3QtZ2V0IHBhcmFtcyA6c3Rl cCkpCisJICAgKGhpZGUtZmlsZXMgKHBsaXN0LWdldCBwYXJhbXMgOmhpZGVmaWxlcykpCiAJICAg KGZvcm1hdHRlciAob3IgKHBsaXN0LWdldCBwYXJhbXMgOmZvcm1hdHRlcikKIAkJCSAgb3JnLWNs b2NrLWNsb2NrdGFibGUtZm9ybWF0dGVyCiAJCQkgICdvcmctY2xvY2t0YWJsZS13cml0ZS1kZWZh dWx0KSkKQEAgLTI0NDUsNyArMjQ0Nyw4IEBAIHRoZSBjdXJyZW50bHkgc2VsZWN0ZWQgaW50ZXJ2 YWwgc2l6ZS4iCiAJICAgICA7OyBFdmVuIHRob3VnaCBgZmlsZS13aXRoLWFyY2hpdmVzJyBjYW4g Y29uc2lzdCBvZgogCSAgICAgOzsgbXVsdGlwbGUgZmlsZXMsIHdlIGNvbnNpZGVyIHRoaXMgaXMg b25lIGV4dGVuZGVkIGZpbGUKIAkgICAgIDs7IGluc3RlYWQuCi0JICAgICAoYW5kIChjb25zcCBm aWxlcykgKG5vdCAoZXEgc2NvcGUgJ2ZpbGUtd2l0aC1hcmNoaXZlcykpKSkpCisJICAgICAoYW5k IChub3QgaGlkZS1maWxlcykKKwkJICAoY29uc3AgZmlsZXMpIChub3QgKGVxIHNjb3BlICdmaWxl LXdpdGgtYXJjaGl2ZXMpKSkpKQogCiAJKGZ1bmNhbGwgZm9ybWF0dGVyCiAJCSBvcmlnaW4KZGlm ZiAtLWdpdCBhL2xpc3Avb3JnLXBjb21wbGV0ZS5lbCBiL2xpc3Avb3JnLXBjb21wbGV0ZS5lbApp bmRleCA2MWVjNWZhZDQuLmE5MmI0NGNiMiAxMDA2NDQKLS0tIGEvbGlzcC9vcmctcGNvbXBsZXRl LmVsCisrKyBiL2xpc3Avb3JnLXBjb21wbGV0ZS5lbApAQCAtMzc0LDggKzM3NCw5IEBAIENvbXBs ZXRlIGEgbGFuZ3VhZ2UgaW4gdGhlIGZpcnN0IGZpZWxkLCB0aGUgaGVhZGVyIGFyZ3VtZW50cyBh bmQgc3dpdGNoZXMuIgogCQkJICAgIjp0c3RhcnQiICI6dGVuZCIgIjpibG9jayIgIjpzdGVwIgog CQkJICAgIjpzdGVwc2tpcDAiICI6ZmlsZXNraXAwIgogCQkJICAgIjplbXBoYXNpemUiICI6bGlu ayIgIjpuYXJyb3ciICI6aW5kZW50IgotCQkJICAgIjp0Y29sdW1ucyIgIjpsZXZlbCIgIjpjb21w YWN0IiAiOnRpbWVzdGFtcCIKLQkJCSAgICI6Zm9ybXVsYSIgIjpmb3JtYXR0ZXIiICI6d3N0YXJ0 IiAiOm1zdGFydCIpKSkpCisJCQkgICAiOmhpZGVmaWxlcyIgIjp0Y29sdW1ucyIgIjpsZXZlbCIg Ijpjb21wYWN0IgorCQkJICAgIjp0aW1lc3RhbXAiICI6Zm9ybXVsYSIgIjpmb3JtYXR0ZXIiCisJ CQkgICAiOndzdGFydCIgIjptc3RhcnQiKSkpKQogCiAoZGVmdW4gb3JnLXBjb21wbGV0ZS1jYXNl LWRvdWJsZSAobGlzdCkKICAgIlJldHVybiBsaXN0IHdpdGggYm90aCB1cGNhc2UgYW5kIGRvd25j YXNlIHZlcnNpb24gb2YgYWxsIHN0cmluZ3MgaW4gTElTVC4iCi0tIAoyLjE0LjEKCg== --f4030435bcd4b946820558315176--