From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id gLf+N+vLol6YXwAA0tVLHw (envelope-from ) for ; Fri, 24 Apr 2020 11:22:19 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id MCNOGPLLol7kYAAA1q6Kng (envelope-from ) for ; Fri, 24 Apr 2020 11:22:26 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id A2B36941E55 for ; Fri, 24 Apr 2020 11:22:25 +0000 (UTC) Received: from localhost ([::1]:60682 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jRwPX-0005uD-Qm for larch@yhetil.org; Fri, 24 Apr 2020 07:22:23 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:34188) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jRwOD-00057R-7r for emacs-orgmode@gnu.org; Fri, 24 Apr 2020 07:21:01 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.90_1) (envelope-from ) id 1jRwOC-0007Sw-DW for emacs-orgmode@gnu.org; Fri, 24 Apr 2020 07:21:00 -0400 Received: from mail-ua1-f45.google.com ([209.85.222.45]:42955) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jRwOB-0007QU-PS for emacs-orgmode@gnu.org; Fri, 24 Apr 2020 07:21:00 -0400 Received: by mail-ua1-f45.google.com with SMTP id 36so4953424uaf.9 for ; Fri, 24 Apr 2020 04:20:59 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=qUFZT9jDiXX6I7IHaNFwkx9vdRsxYx+Fh8b8ifzSrzk=; b=cqQ4YKCmvqvThGIP+sP0K61brimx3saiOwhRDnHmtMqCdzwdnIdMRQrPnW0rdj/C9N Qv9oc84pibWClR/OgMLRJEHHl2vyQkHjoR7LBWNzH1esY50mGO0hjsX6kjIF+i36cuSi jvFrxkwopLBXa80BTtaBpGV9LbmB6I0F2eRq609Lj46werxS2N08qEZxYEtem0xkBh6J MB87k/gxeQVbZbxZWNimFJH9T9zqa0BXgUzN8sYQJDuKUBiC37J2Jeg29M5TkeTfWbCL IQLmasqRD+bS4VJghoJU0oi2CtFe+d42Qe1ChNVrYA3OedYjBw5uKWtQw02RxTZHFPwc oxZQ== X-Gm-Message-State: AGi0PuYtZ+4416lz4DISdNnp2vu5spCcXIpg3AZiBIi0xQua98q8ch3C iGciSR5NQLWvKVIbmkParDlUcfYU0fHuHOcEmU2c1kFhERg= X-Google-Smtp-Source: APiQypLS8ETM7ADO4+5mg67tucSku7C+YbvpkI2FtqRInHmaOqU3bGyp4ZCt9+XS/SQz48IZUnVpTehatxRtThR/6t0= X-Received: by 2002:a67:3293:: with SMTP id y141mr7120453vsy.54.1587727258281; Fri, 24 Apr 2020 04:20:58 -0700 (PDT) MIME-Version: 1.0 References: <875zfrtw6m.fsf@alphapapa.net> In-Reply-To: <875zfrtw6m.fsf@alphapapa.net> From: Carsten Dominik Date: Fri, 24 Apr 2020 13:20:41 +0200 Message-ID: Subject: Re: Debugging at least 2 regressions in org-mode master breaking ox-hugo To: Adam Porter Content-Type: multipart/alternative; boundary="0000000000003aeb6805a4078f8c" Received-SPF: pass client-ip=209.85.222.45; envelope-from=carsten.dominik@gmail.com; helo=mail-ua1-f45.google.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/04/24 07:20:58 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 209.85.222.45 X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: org-mode list Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Scanner: scn0 X-Spam-Score: -1.01 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=uva.nl (policy=none); spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Scan-Result: default: False [-1.01 / 13.00]; GENERIC_REPUTATION(0.00)[-0.56149706570782]; R_SPF_ALLOW(-0.20)[+ip4:209.51.188.0/24:c]; IP_REPUTATION_HAM(0.00)[asn: 22989(0.21), country: US(-0.00), ip: 209.51.188.17(-0.56)]; TO_DN_ALL(0.00)[]; MX_GOOD(-0.50)[cached: eggs.gnu.org]; RCPT_COUNT_TWO(0.00)[2]; MAILLIST(-0.20)[mailman]; FORGED_RECIPIENTS_MAILLIST(0.00)[]; RCVD_IN_DNSWL_LOW(-0.10)[209.51.188.17:from]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+,1:+,2:~]; ASN(0.00)[asn:22989, ipnet:209.51.188.0/24, country:US]; TAGGED_FROM(0.00)[larch=yhetil.org]; FROM_NEQ_ENVFROM(0.00)[dominik@uva.nl,emacs-orgmode-bounces@gnu.org]; ARC_NA(0.00)[]; RCVD_COUNT_FIVE(0.00)[6]; URIBL_BLOCKED(0.00)[alphapapa.net:email]; FROM_HAS_DN(0.00)[]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; PREVIOUSLY_DELIVERED(0.00)[emacs-orgmode@gnu.org]; HAS_LIST_UNSUB(-0.01)[]; RCVD_TLS_LAST(0.00)[]; FORGED_SENDER_MAILLIST(0.00)[]; DMARC_POLICY_SOFTFAIL(0.10)[uva.nl : SPF not aligned (relaxed), No valid DKIM,none] X-TUID: d/AWeYxc9qM5 --0000000000003aeb6805a4078f8c Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Fri, Feb 28, 2020 at 1:04 AM Adam Porter wrote: > Kaushal Modi writes: > > > Failure 1: org-get-outline-path has moved, and not mentioned in ORG-NEW= S > > > > Compiling ox-hugo.el now gives: > > > > ox-hugo.el:4284:1: Warning: the function =E2=80=98org-get-outline-path= =E2=80=99 is not > known to be defined. > > > > I see that defun has now moved to org-refile.el. I see that > > org-get-outline-path has nothing to do specific to refiling. Can that > > be moved back to org.el, or may be a separate library? Otherwise, > > ox-hugo.el will have to load org-refile.el too (yes, I don't use > > org-refile (yet), and that's how I discovered this :)) > > Yes, please move that function back. This is going to cause breakage in > a variety of packages that use that function but do not load > org-refile. I can hear the bug reports rumbling already... ;) > I support this. getting the outline path has more general applications that just refiling, so tugging it away into org-refile does not make sense. - Carsten --0000000000003aeb6805a4078f8c Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


=
On Fri, Feb 28, 2020 at 1:04 AM Adam = Porter <adam@alphapapa.net>= wrote:
Kaushal = Modi <kausha= l.modi@gmail.com> writes:

> Failure 1: org-get-outline-path has moved, and not mentioned in ORG-NE= WS
>
> Compiling ox-hugo.el now gives:
>
> ox-hugo.el:4284:1: Warning: the function =E2=80=98org-get-outline-path= =E2=80=99 is not known to be defined.
>
> I see that defun has now moved to org-refile.el. I see that
> org-get-outline-path has nothing to do specific to refiling. Can that<= br> > be moved back to org.el, or may be a separate library? Otherwise,
> ox-hugo.el will have to load org-refile.el too (yes, I don't use > org-refile (yet), and that's how I discovered this :))

Yes, please move that function back.=C2=A0 This is going to cause breakage = in
a variety of packages that use that function but do not load
org-refile.=C2=A0 I can hear the bug reports rumbling already...=C2=A0 ;)

I support this. getting the outline path= has more general applications that just refiling, so tugging it away into = org-refile does not make sense.

- Carsten
=C2=A0
--0000000000003aeb6805a4078f8c--