From mboxrd@z Thu Jan 1 00:00:00 1970 From: Carsten Dominik Subject: Re: org-fast-todo-selection window behaviour? Date: Mon, 21 Oct 2019 11:46:57 +0200 Message-ID: References: Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="00000000000060424905956891f3" Return-path: Received: from eggs.gnu.org ([2001:470:142:3::10]:37821) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iMUHT-0002U6-Ac for emacs-orgmode@gnu.org; Mon, 21 Oct 2019 05:47:16 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iMUHR-0002rN-SM for emacs-orgmode@gnu.org; Mon, 21 Oct 2019 05:47:15 -0400 Received: from mail-ed1-f52.google.com ([209.85.208.52]:33692) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iMUHR-0002r7-JR for emacs-orgmode@gnu.org; Mon, 21 Oct 2019 05:47:13 -0400 Received: by mail-ed1-f52.google.com with SMTP id c4so9520740edl.0 for ; Mon, 21 Oct 2019 02:47:12 -0700 (PDT) In-Reply-To: List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: "Emacs-orgmode" To: Matt Price Cc: Org Mode --00000000000060424905956891f3 Content-Type: text/plain; charset="UTF-8" Hi Matt, I made this change, because I found the previous way jarring. The window with the selection information showed up in different places depending on what the current window setup is. With the new implementation, the info window is always in the same predictable place. After the selection is done, the old window setup is restored to exactly what it was.... Carsten On Sun, Oct 20, 2019 at 8:46 PM Matt Price wrote: > I've recently noticed a slightly frustrating behavour on the part of > org-todo that I think is new and maybe was introduced in mid-August with > > f1c030bed54737319aeb1d592e3340d6a48cea3a > > In a split frame,calling org-todo with org-use-fast-todo-selection > enabled, ~C-c C-t~ now calls ~delete-other-windows~ before popping up the > org-todo keywords window. Is this necessary? I find this behaviour > visually confusing and distracting, and a slowdown to my workflow. Would > it make sense to introduce some kind of defcustom for this? For now I'm > just commenting out line 10614 of org.el, but if others want to be able to > customize the behaviour I will submit a patch. > > Maybe there's a reason delete-other-window is necessary, but i don't see > it in the commit message nor immediately in the other parts of this > otherwise very well-documented commit > > Thanks! > > --00000000000060424905956891f3 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi Matt,

I made this change, because I = found the previous way jarring.=C2=A0 The window with the selection informa= tion showed up in different places depending on what the current window set= up is. With the new implementation, the info window is always in the same p= redictable place.=C2=A0 After the selection is done, the old window setup i= s restored to exactly what it was....

Carsten

On Sun, Oct 20, 2019 at 8:46 PM Matt Price <moptop99@gmail.com> wrote:
I've recently notice= d a slightly frustrating behavour on the part of org-todo that I think is n= ew and maybe was introduced in mid-August with

f1c030bed54737319aeb1d592e3340d6a48cea3a

In a sp= lit frame,calling org-todo with org-use-fast-todo-selection enabled, ~C-c C= -t~ now calls ~delete-other-windows~ before popping up the org-todo keyword= s window.=C2=A0 Is this necessary? I find this behaviour visually confusing= and distracting, and a slowdown to my workflow.=C2=A0 Would it make sense = to introduce some kind of defcustom for this? For now I'm just commenti= ng out line 10614 of org.el, but if others want to be able to customize the= behaviour I will submit a patch.

Maybe there= 's a reason delete-other-window is necessary, but i don't see it in= the commit message nor immediately in the other parts of this otherwise ve= ry well-documented commit

Thanks!
--00000000000060424905956891f3--