emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed

From: Lorenzo Bolla <lbolla@gmail.com>
To: emacs-orgmode@gnu.org
Subject: Bug: Caching org-publish-find-date [8.2.10 (release_8.2.10 @ /opt/emacs/lisp/org/)]
Date: Wed, 27 Dec 2017 16:54:49 +0000	[thread overview]
Message-ID: <CADjgTRzfekmjgsdVY3+bjZ0AS9qHKD2X6=y+F6EgZoLxbqNArg@mail.gmail.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 1780 bytes --]

Remember to cover the basics, that is, what you expected to happen and
what in fact did happen.  You don't know how to make a good report?  See

     http://orgmode.org/manual/Feedback.html#Feedback

Your bug report will be posted to the Org-mode mailing list.
------------------------------------------------------------------------

When using `org-publish-project` I noticed that generating a sitemap
sorted (anti-)chronologically is very slow. It turns out that the
slowness is due to the sorting of sitemap entries, which calls
`org-publish-find-date` during the comparison. But
`org-publish-find-date` is not cached therefore it is called over and
over for each file during the sorting process.
By contrast, `org-publish-find-title` is cached and sorting
alphabetically is faster.

To test this assumption, I've modified `ox-publish.el` to cache
   `org-publish-find-date`, too, obtaining a substantial speed-up:

   (defun org-publish-find-date (file)
     (or
      (org-publish-cache-get-file-property file :date nil t)
      (let ((date (org-publish-find-date-uncached file)))
        (org-publish-cache-set-file-property file :date date)
        date)))

   (defun org-publish-find-date-uncached (file)
     "Find the date of FILE in project.
   This function assumes FILE is either a directory or an Org file.
   If FILE is an Org file and provides a DATE keyword use it.  In
   any other case use the file system's modification time.  Return
   time in `current-time' format."
   ...

Is there a reason why we should not cache the date of a file, in the
same way as we cache its title?

Thanks,
Lorenzo

Emacs  : GNU Emacs 25.1.1 (x86_64-unknown-linux-gnu, GTK+ Version 2.24.23)
 of 2016-11-01
Package: Org-mode version 8.2.10 (release_8.2.10 @ /opt/emacs/lisp/org/)

[-- Attachment #2: Type: text/html, Size: 2101 bytes --]

next             reply	other threads:[~2017-12-27 16:54 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-27 16:54 Lorenzo Bolla [this message]
2017-12-27 22:48 ` Bug: Caching org-publish-find-date [8.2.10 (release_8.2.10 @ /opt/emacs/lisp/org/)] Nicolas Goaziou

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CADjgTRzfekmjgsdVY3+bjZ0AS9qHKD2X6=y+F6EgZoLxbqNArg@mail.gmail.com' \
    --to=lbolla@gmail.com \
    --cc=emacs-orgmode@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).